From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79B3FA0544; Fri, 18 Nov 2022 16:19:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1419540041; Fri, 18 Nov 2022 16:19:17 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2051.outbound.protection.outlook.com [40.107.94.51]) by mails.dpdk.org (Postfix) with ESMTP id 51A294003F for ; Fri, 18 Nov 2022 16:19:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XMei+1s5/MCne88caqK+0UzwaDlv8cK5ee1CF9pq7ThUjvMCSIzK+PnPYqiTKDMiMcWXij4D7GzivuQ2COLVgTtysGeCBxpOVskMK6cdSb5vHLqX4+wXlMJslCfh98QeTxNcIa3IfWicDTrExz94ULA0M//Rr28WF7ZeZTbYXbCL2VLcfYHuHnIc4mFYcDTvwhf8pUZbSSDaz1r2gHb3MFPR0ZVlqe/WW1GZWZDWX+LA+ftsmdY2DnMko8AaQPWC16JU1IcmP2xYW29rbaFwDDIwZQWUH6GV9TWVSPkpv4s/vat71FyPy1HPKpJZHQrOvsNFmVyWvTAXFTqqbtfoXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=33jRw4tnFGdmdbc4sX0J5PB8e0vkUh/yxrqNV2GB4rw=; b=IWJQPCWMk5xcRLKyqgY3govuCXPCAwETltbMB2a9hv+H//Xbg3/DxDm6AOaYPqROmO/uFWJzaNsJmO4agP4Z3YSGYg5NW49RMBTHY+s0HOCdFYyY0XV7QSjG62zkk02cP7a0wYrVcLrBzeZroRAQOYnHvTB4wKd0IzvE/2cHjXSz8FOrSMGaqb4mzRzvpftLpSWyDqy75BFInX16VfqSlE1evHZx/id2yWtM7gX2+ErHPm8HssxxeO66AXIMk8ofKsTzk9d5bQeYpz0hgZmMJU46R8wMh71nFGkbzjr0H7XYxm7cCsO0ncPjdjZxy2eNSscpeb+RA3kSzgiKBHMQpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=33jRw4tnFGdmdbc4sX0J5PB8e0vkUh/yxrqNV2GB4rw=; b=VtsfZg7Dy3Gx/mwcDYNrtX/Dvb4oDSn2rMjpjSUzA+bVAQTlTBPXnj/NnxBEMcxLtF5k8dRd1BGD4woRVexxhtc+g4RJDxwaw5FeuHms4hOCp14yiy+Jso9pDeOc8vjsAyqV9AOrsCCx5mMvihXoUbOyFrSSuBwYfog55Ze5Ef0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BN9PR12MB5258.namprd12.prod.outlook.com (2603:10b6:408:11f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Fri, 18 Nov 2022 15:19:12 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5813.020; Fri, 18 Nov 2022 15:19:12 +0000 Message-ID: <0c58d816-cc7c-721d-00f0-e90362e5a0a4@amd.com> Date: Fri, 18 Nov 2022 15:19:07 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Suanming Mou , "david.marchand@redhat.com" , Aman Singh , Yuying Zhang Cc: "dev@dpdk.org" References: <20221117085537.24372-1-suanmingm@nvidia.com> <4cdd1d8f-69ed-a97f-32f5-65289642fef2@amd.com> From: Ferruh Yigit Subject: Re: [PATCH] app/testpmd: fix action destruction memory leak In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0262.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::34) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BN9PR12MB5258:EE_ X-MS-Office365-Filtering-Correlation-Id: b1414a09-66c4-4667-d95b-08dac9783f58 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /KnOqup62xhb1hdXIzAMnaikZyvfjdUBEmj3gGoebkEV7SC7AceY0Sywnm8aaG3y3cmwftBI4FQkJI1IFX7MtfHr50uNbqJ5O+JoqWY38pW5pQMhPRkuUvVuKlHVJxrjtSH1upAHD9Rivc0FCiKZLWaIT32jvwbqRBSsKaJs6YHllv/pSYyyXvElQyRggvvM4AeQI1o0ojbm2Qzvt/VTYimsQms887pLT4NkLalCjHr2ku5wOpOVv9+WxcCifE2ReZVpigkJrhWJ6jBmuJNYh56KC/zCA6PQM6rBGoPbmL0ry2ZYo6Keu1dmnxe0GaLhvFqinOhrqOGQxTBVK7Fu40uYURNrF4X9DHCqZRlsWPJIc+kw2RKdEZ9x+2oLQqwHHBcIcgdDcCEkNLaV8b1VYpyuqaFY38B1FXzXZWnloURz+3DSyivSRq5i0y2NrBHsMFzn1DaDF+vo3AD2u0R+Fw+jeHvfVdo2alyZH9t39Sm5SuWB7niarm1VYdW4bOI1En3lC+gEToVa132eFKJXzDE/hRN/f0n0WJktT+yPTc3y3HWAv8yRkl63eh7icY9sY8hAe4B2BHIU5BLhLK51dXHxRY31mCAUDdiRJkgqUUOL1f223Te/laqndE2Nrp0sKoVHg4o7sD6HQVOcEohJHo3nJsza6lQpAY9gQQaKvVkyqIiucFordmoEfQJjjfWvmqGg4EBgw84sBwXuRx1CAm2g/9RtroKyIxx7HtxAAK0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(366004)(136003)(376002)(39860400002)(451199015)(2906002)(31686004)(83380400001)(186003)(41300700001)(36756003)(2616005)(8676002)(4326008)(86362001)(31696002)(38100700002)(53546011)(5660300002)(66946007)(44832011)(66476007)(6486002)(66556008)(8936002)(478600001)(316002)(110136005)(26005)(6512007)(6506007)(6666004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWpSeCswMlNXWm9ZclljSUZQMjE1N2VqMHJTRzJsaFhWZnJXdTYrQkJLNVJU?= =?utf-8?B?Y0JJVzRhL1Y2NWUwTGlwbllVc3VLeTVER3JHV2NCanFBRW9XY2dzN0ZDdU1x?= =?utf-8?B?VFRMZzdqazM3bUIwNmtCNU1DZUcrM1pQa281OEVUcDdEbzgrOGs2L0txalZr?= =?utf-8?B?UmpEcHNCZnp2NnkvdW52ZTA4WXhjY1RTR1AxSFJYK3hQQ3AyTlBEUytvUzV2?= =?utf-8?B?UFFldmZxYTQ0THJHdHArVnZwNlp3ZnlScjkvaWVhYTBHRWdOSVVKQmtDWEY3?= =?utf-8?B?akk1S0xOZmxrVFFmcGtJVnhsUS9TSVhrYjdDK3lZY2ZVMHA1YmpGSzh6U1gw?= =?utf-8?B?VS9leS91V0prM29YV2c3Rk1GTkFwZFdya1FyK3dLRzJ1bDF2R05GS3FDZWdt?= =?utf-8?B?NkVleVV2Z2pkajYwYkdmdTBmWit5WlVJOG1KNDg0bVlwTnlLNS9hUHZuQnkz?= =?utf-8?B?QjNsM0Z5cUI4MXZqSWtxQXNXTGljZ29lWnd6ODRrWmF1Y0VlMWNTclBHelNj?= =?utf-8?B?QmQvME1WU1YyejdkNUFBd2lIakd2a3JVQ2FKVjJHY2dMN2Yra1l5aGF6TkYz?= =?utf-8?B?eExJT0czbkYrWElDdHlubElHc1lWVFBHMEJNZ1J2TzUwY2M5WWVYczJBUmNm?= =?utf-8?B?emczeWhCbndnZXJuNEF5RVh6b2kwbERQR3hwLytBdklPS2d0b1RkYVBMTEln?= =?utf-8?B?SlNiNG1HaFlNUmo4VjYwUW5kV1FOeFZuZ2RGMlJLM1VFSC95ZEVqWmp5aTdj?= =?utf-8?B?RklpYVZYWkVSeDBCYkZtSFpDU1Bwdm9hNnZTNk9jSDBRSWk0YlV0bFRtUTQ0?= =?utf-8?B?L2FYWlpNMHJyR3hlKy8yQllCbFNYOW5DYnpsNmVQU1g0SXE2bEM3QkJFTkNy?= =?utf-8?B?cDdzQTErb09UUStycUdzTHZCcmlqWmhSNzFMK2pJazBXRGJIb1M4OTA3YU9m?= =?utf-8?B?d3k1Vnc3RHA4MFlFWU1OYm5OUWJRNFk3QjkzdVBVeURoOFNZTUVZWjM2SnR6?= =?utf-8?B?U2NsTmZYYWZTYjNjQmVzVkVkcUVLRnRERDF4dnYwWTJwbWxqSmYrRlhtblJR?= =?utf-8?B?a3NaL2VTTmVwMnBKM2dhcWNEbEZvY2NXMld3TWpEUU9MM0V6Uno4aXBGTm93?= =?utf-8?B?SDc2RGx6bkdsejFoYnQvR1dNbDFIcmxiUVlVWVZvczhvdGgzb202VHE4MFg0?= =?utf-8?B?NFd6M1lLLzF2YzBZNU5IMVZ1M1RENlBOc1UrNC9pbFMzSGNWeFhsYWIyT1NT?= =?utf-8?B?T3crc2JVMyt4cDRIMnJqR2E0bDV1QmY2SWhRUWJNTllvb0YwdXc2NWNRczlU?= =?utf-8?B?b280OWx4V2FqeDM5bzBNZngyM1I1WVdhdjFPeExrTGFRbTdmSkJNT25hT1oy?= =?utf-8?B?OSt4N29ZV0lvWXdrR01BblNJei9idzNZaDgwSGMvakdxaDhuMkNveDZNNkh5?= =?utf-8?B?SGdFeWZKRUYwNUJDVGQ5NGo1cEEzRjJVN1ZhbEZLUnBQbTI3SmZ5dVlUV05u?= =?utf-8?B?RVZVN09mc1Z5UVAxVHJMWHVyS0NZemF6MlFoWURCRmRuQTNEdGNkSWt6VzVw?= =?utf-8?B?S01FM2RESW85cDRaeDNqR0hjcENoZzhTTUJBQ1RudzRMRjRiNjlrdWpjbEMw?= =?utf-8?B?UTFRcGc5Yk9BQXNKdXR5TW4wanl5NlB6WEk2OTVqbTQwMkVUL2JHTHBVamdR?= =?utf-8?B?K3VRUWxtZWpOMFUwK3MyVjR1Z0UzTWJOUlBTRFl5Zzgvb3JiM2xtOVFWcC9t?= =?utf-8?B?U2ZWVmMrdkIyZXg4NVBnaVVXTnQvVlBrTlppQ1pzdDJkdENYUWpPRlQrOFVO?= =?utf-8?B?WDlhemVuZWdlZ2F6Q2pkKzFCV0Z5d2xYWFgyUG5ya3o4ejZEWFdnREVUQ1Az?= =?utf-8?B?NEpPSndBMGUzdExhbU41L2Y3Z2ZiMUMrSS9uRDExSDhTNDA4N0toOWlZSUgv?= =?utf-8?B?bnI0cnY1VEhZNU5FYmdDY3dZclhmOVdBcENBZ0xSNjIvUE5QV0wyb0dXUzZI?= =?utf-8?B?bXJCKzIvRzhpbGdjQ3REZUNpSmNwOUpIY24zTmxaU2lzaHJCclFacE5pcXhs?= =?utf-8?B?bk50MnpwODN3VVlzRktxVGg4RnhYZks5S3lNVGV3cngrOVNjK3ZiRnpEV3Vq?= =?utf-8?Q?Ic5XgsgouWH4bP1/czZt0DWs6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1414a09-66c4-4667-d95b-08dac9783f58 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 15:19:12.4892 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bC1tkjka0POGTXo228TUawNzxu+5DoEramxZn3IakSzsV9b21QrDqnKf0yxRbCjD X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5258 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/18/2022 12:21 PM, Suanming Mou wrote: > Hi, > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, November 18, 2022 6:40 PM >> To: Suanming Mou ; david.marchand@redhat.com; >> Aman Singh ; Yuying Zhang >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH] app/testpmd: fix action destruction memory leak >> >> On 11/17/2022 8:55 AM, Suanming Mou wrote: >>> In case action handle destroy fails, the job memory was not freed >>> properly. This commit fixes the possible memory leak in the action >>> handle destruction failed case. >>> >>> Fixes: c9dc03840873 ("ethdev: add indirect action async query") >>> >>> Signed-off-by: Suanming Mou >>> --- >>> app/test-pmd/config.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index >>> 982549ffed..719bdd4261 100644 >>> --- a/app/test-pmd/config.c >>> +++ b/app/test-pmd/config.c >>> @@ -2873,9 +2873,9 @@ port_queue_action_handle_destroy(portid_t >> port_id, >>> job->type = QUEUE_JOB_TYPE_ACTION_DESTROY; >>> job->pia = pia; >>> >>> - if (pia->handle && >>> - rte_flow_async_action_handle_destroy(port_id, >>> + if (rte_flow_async_action_handle_destroy(port_id, >> >> Why 'pia->handle' check removed, was it unnecessary to check it at first place? This seems already discussed and agreed in other thread, so proceeding. Applied to dpdk-next-net/main, thanks.