From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AC5CA04B1; Thu, 24 Sep 2020 10:05:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14A3A1DD5F; Thu, 24 Sep 2020 10:05:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 8E27C1DD5B for ; Thu, 24 Sep 2020 10:05:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600934717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6VNV+1Rn1Hwxkc8/iO/zYodRGqTiEHcum4ykInFlYF4=; b=ZElL0Y/9QidKT9DmdqinxpYLRiALDqWOki8Btqh2g9lxHUywe+hn5/npZ8rsfF1BpZLx1E BoYYPMEIXN4z/60nHjdVeiTH6E48aFk28UrrqfmMYyQy+/EEu+JbUgFeYVKTS3M5Ckiu2f H8dyJ5UYFoV4efjCs/p9Gq/cfEDRWOQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-95-dmnnFG9CNl-EpTfGLmlJdg-1; Thu, 24 Sep 2020 04:05:13 -0400 X-MC-Unique: dmnnFG9CNl-EpTfGLmlJdg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC6F4186DD28; Thu, 24 Sep 2020 08:05:12 +0000 (UTC) Received: from [10.36.110.9] (unknown [10.36.110.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 03DF57368A; Thu, 24 Sep 2020 08:05:09 +0000 (UTC) To: "Xia, Chenbo" , "dev@dpdk.org" , "Fu, Patrick" , "amorenoz@redhat.com" References: <20200911150805.79901-1-maxime.coquelin@redhat.com> <20200911150805.79901-5-maxime.coquelin@redhat.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <0c61e246-a11e-6ce8-8930-3f54e9dfea56@redhat.com> Date: Thu, 24 Sep 2020 10:05:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 4/7] net/virtio: adapt Virtio-user status size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/24/20 7:25 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: dev On Behalf Of Maxime Coquelin >> Sent: Friday, September 11, 2020 11:08 PM >> To: dev@dpdk.org; Fu, Patrick ; amorenoz@redhat.com >> Cc: Maxime Coquelin >> Subject: [dpdk-dev] [PATCH 4/7] net/virtio: adapt Virtio-user status size >> >> Set proper payload size for set/get status message. The payload >> size varies according to backend types. >> >> Signed-off-by: Maxime Coquelin >> Signed-off-by: Patrick Fu >> --- >> .../net/virtio/virtio_user/virtio_user_dev.c | 19 +++++++++---------- >> 1 file changed, 9 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c >> b/drivers/net/virtio/virtio_user/virtio_user_dev.c >> index 93274b2a94..753611ef42 100644 >> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c >> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c >> @@ -838,14 +838,18 @@ virtio_user_send_status_update(struct >> virtio_user_dev *dev, uint8_t status) >> enum virtio_user_backend_type backend_type = >> virtio_user_backend_type(dev->path); >> >> - /* Vhost-user only for now */ >> - if (backend_type != VIRTIO_USER_BACKEND_VHOST_USER) >> + if (!(dev->protocol_features & (1ULL << >> VHOST_USER_PROTOCOL_F_STATUS))) >> return 0; >> >> - if (!(dev->protocol_features & (1ULL << >> VHOST_USER_PROTOCOL_F_STATUS))) >> + if (backend_type == VIRTIO_USER_BACKEND_VHOST_USER) >> + ret = dev->ops->send_request(dev, >> + VHOST_USER_SET_STATUS, &arg); >> + else if (backend_type == VIRTIO_USER_BACKEND_VHOST_VDPA) >> + ret = dev->ops->send_request(dev, >> + VHOST_USER_SET_STATUS, &status); >> + else >> return 0; >> >> - ret = dev->ops->send_request(dev, VHOST_USER_SET_STATUS, &arg); >> if (ret) { >> PMD_INIT_LOG(ERR, "VHOST_USER_SET_STATUS failed (%d): %s", ret, >> strerror(errno)); >> @@ -858,7 +862,7 @@ virtio_user_send_status_update(struct virtio_user_dev >> *dev, uint8_t status) >> int >> virtio_user_update_status(struct virtio_user_dev *dev) >> { >> - uint64_t ret; >> + uint8_t ret; > > If you use uint8_t here, for vhost-vdpa, it's ok. But for vhost-user, with Adrian's > patch, it takes the status as uint64_t, and with below logic, it may overflow, right? > > switch (req) { > case VHOST_USER_GET_FEATURES: > case VHOST_USER_GET_STATUS: > case VHOST_USER_GET_PROTOCOL_FEATURES: > if (msg.size != sizeof(m.payload.u64)) { > PMD_DRV_LOG(ERR, "Received bad msg size"); > return -1; > } > *((__u64 *)arg) = msg.payload.u64; > break; Yes, it could. I can add a dedicated case for GET_STATUS, so that it can check it does not overflow 8bits. Thanks, Maxime > Thanks! > Chenbo > >> int err; >> enum virtio_user_backend_type backend_type = >> virtio_user_backend_type(dev->path); >> @@ -876,11 +880,6 @@ virtio_user_update_status(struct virtio_user_dev *dev) >> strerror(errno)); >> return -1; >> } >> - if (ret > UINT8_MAX) { >> - PMD_INIT_LOG(ERR, "Invalid VHOST_USER_GET_STATUS " >> - "response 0x%" PRIx64 "\n", ret); >> - return -1; >> - } >> >> dev->status = ret; >> PMD_INIT_LOG(DEBUG, "Updated Device Status(0x%08x):\n" >> -- >> 2.26.2 >