From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 475221B452 for ; Mon, 9 Jul 2018 17:13:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2018 08:13:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,330,1526367600"; d="scan'208";a="53063119" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.102]) ([10.237.220.102]) by fmsmga007.fm.intel.com with ESMTP; 09 Jul 2018 08:13:30 -0700 To: Qi Zhang , thomas@monjalon.net Cc: konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, benjamin.h.shelton@intel.com, narender.vangati@intel.com References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20180709033706.27858-1-qi.z.zhang@intel.com> <20180709033706.27858-5-qi.z.zhang@intel.com> From: "Burakov, Anatoly" Message-ID: <0c85210f-7dd3-1e8c-648a-e64daf8cd710@intel.com> Date: Mon, 9 Jul 2018 16:13:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: <20180709033706.27858-5-qi.z.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v10 04/19] vfio: remove uneccessary IPC for group fd clear X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 15:13:35 -0000 On 09-Jul-18 4:36 AM, Qi Zhang wrote: > Clear vfio_group_fd is not necessary to involve any IPC. > Also, current IPC implementation for SOCKET_CLR_GROUP is not > correct. rte_vfio_clear_group on secondary will always fail, > that prevent device be detached correctly on a secondary process. > The patch simply removes all IPC related stuff in > rte_vfio_clear_group. > > Signed-off-by: Qi Zhang > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly