From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40A0443C9F; Wed, 13 Mar 2024 12:28:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2F2942DDA; Wed, 13 Mar 2024 12:28:41 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 5BB5442DD9; Wed, 13 Mar 2024 12:28:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K3MHLXs6bZjxI+hCk9EJI9aMmZITkSUp2hAWEygt5xbl6zQOqRvttGyGnIcfp8/Zrr+ETSs9Acx8C/rBms6q7qmRHT+Iu0aGQyb510JsaYq4ZU4NTtJLREcjlQovXJ5mLTKuYTF94LmKO0ra2Bu7ylsuPoMHNcN9YKt8aMSvNIxCj8BRmiFvcekkWx7WQSqjiAU5XN5bSKTBlQUuAg66H2XGLasQeK3EA+O+cjRyTj72UJxRE53QaLjeew1ZAdCh3KwGyQUt1zGoW1tXOi71QJdVtjYsRpLE1AeY6MaVEvLnTuipagQTchN5DL8G9ZfkQvYOVRz5z6yKceRZGFF/uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uVILFmU2YxuMjlKJAtoYI8w3kgN7aYCE0rWHBBqnszE=; b=MrUneGulcfuTinfCLulB+hLRTpsT8eQ6xnUzGEtJy7pNFoL2LKottXd0w1/uTe+MkJFFNyAhogfZ9pEL4xYIz5yZrIFI0WkjFWe5imzxLsUiupSf0/R13352bDv4GiC8D8drzegJdAnwvzssWynxtfbIzid+NAW1lvQGW8uh0KsG9GxHZyniyux5gT5286Md27pkLuRNB+mV8ZoOA62g2uw/RA/g28syk3NjOcBtXfFy8AFv2ys/HhVGPSRLVZ3C8Ao3kgdHQS414L/IPgJqFS6gIlaOijs2SV7akHu/VEzj4kmDE9kE4vPa0zQl41+Umh1kXeZVgkaowe7KoXjOUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uVILFmU2YxuMjlKJAtoYI8w3kgN7aYCE0rWHBBqnszE=; b=JVWrxmXXuEKjsgN2GNR86s49Qx7huxQvZfIq2hzqwFe/WiZOOGeY4mUoE1fuf03AqU/ICCikBwyxxrBmElkGjdgCKyWB6/II+I5mYEucEy6ti3gj9hn5G38RKrjrR4A6FjkwVqCQryhjMzr73nu+tymF4TSfyj5tAgxU5IkTeZM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7371.namprd12.prod.outlook.com (2603:10b6:806:29a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Wed, 13 Mar 2024 11:28:38 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 11:28:38 +0000 Message-ID: <0c862b9e-d913-4f61-bf66-0da9562be186@amd.com> Date: Wed, 13 Mar 2024 11:28:37 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/33] net/ena: fix fast mbuf free Content-Language: en-US To: "Brandes, Shai" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20240306122445.4350-1-shaibran@amazon.com> <20240306122445.4350-6-shaibran@amazon.com> <3047c09e-9403-46ee-a13f-f269ed81f78b@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0104.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7371:EE_ X-MS-Office365-Filtering-Correlation-Id: df8b7a5f-9c0a-407b-63e0-08dc4350ba94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BlM7uk4+WQ/JYL6PAKwYhIq1HEqhfrRtkLwclSTTwCqThxV/c7mKR0fkSs9DS+dzm/JgY5hZ3VxpuoO76P4Kw0EMX35aI3tueJv3WEWEc2mGgCHafghnBxInKlSgcvnhxY87QJSjWJWFhE8FMXxXlT7ugCO+UmGkq5q+PWCs9TTXScex5Mgqj3zcuHX/xTx8iz0xTt8bZ0l0KQVKGVsYJUqPQ5enKDpTdKJQ/ZsccAGFeP9n7BG1IPtZBTSCWrHyaJ7uJMoXHpEshF7SjGXunhNjh63YkHZD30JMn+pNWyucVHwV50CEpvC6Y6nFKEyXEBL+gq+NiSwfj7vOLGysD9RMhmh3FPJmWLOlytzhBKxnKxlcM6zCVUh7/hoZBAg0NhFKrL4hfYuHvEIEiwRAsz+rEg9WEyquLSK98a8lftv7yOxg9WkN9cOpbGH1a0Y3sLm7rypXpK/cGptvaam2CgKMUnanbPmvuZhpS8CbiYskmWEsjFEv3N7VKYBCMWi0tUzL/6BH7vF7mVQKIRpmFGm2F3l4O4ptE66S8tPpHI57odXfDBBeS+JRCRSXHMlFm0XMGPD+57c3xvwTiiQc6U4DJ4A5VGTH1ftyIaM8I809S7TGOxKDBUf+VSS+DWdYTG2095WmjzOPk653c0fFZM/8IUHn9UJxpL4hMcAg75Y= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cndycGhseGVVYTBkTWxOOTNlQzllQU5mL3VrNVFHUXpUemVpN0drOGxzTFkz?= =?utf-8?B?Q2lXQW9VUzcrVCtyMWJ0UTN4RUU4dTJqM0FCTjdkeFkvcmV0Z0ZZc3lUV1cx?= =?utf-8?B?MVFXdGxaN3ljT3IvekUwNCtaK0NwaDFuOXM5ZlZiKzJiVVp3bnRhWVlDbldD?= =?utf-8?B?UDZZcjNzWWlIU2tFcndHZkR2MEd0cEVIVGRqSjFQMUR5c2lNcXpxUHY4dGlk?= =?utf-8?B?dEhxT0JXKzNtTnBCcHpSQ21pNDJKb1lrcWV0ZkZOVi9tMzl4eDdtNGNCa2xV?= =?utf-8?B?NHgyRHZrM1dpUkNTY0d5bnMvRCtHcFp6WDdqZ2ZZWFJMMEVPQXE4S21VSFVq?= =?utf-8?B?MXkycFlnTkc2OEt0UEFZeVBrOWUvWFpQci9NdkZLNlZTSVRRbE52SUxVZ0FV?= =?utf-8?B?UmJmaCtPZ3VvMURHWWNwS2VOd045U2FLQWNYSi9nTGZMN0xvN3NkdXhXak9K?= =?utf-8?B?NWVhSTd2VU04dStRbzgzSWxNdXB6TDhQcHpIWUdoZVhrTnJ6bk5MT0xHZ0Vn?= =?utf-8?B?bUVRS21UeFp4SmxBQzF1T2VYTFV0bkE0Q3ZGYXA5S0w0QnVxeE9WV0dmbjAv?= =?utf-8?B?LzZ5N21YYVVoWXh4a1Fucm5GcFlOMHpKT0RxN0l2WnFsNVFtaFpXQ0txUERR?= =?utf-8?B?M1pSUy9QTmJqU3RxY3NBVVpNbDlSbTNHS3NQSXZTczNtSWFMa2tVbjNqUllv?= =?utf-8?B?VWVMN3dtdzJSRGdwYWF1OVVjeUdDcnM3NWdlWkQ4aXBhRGdkT3ZWOUlGeURE?= =?utf-8?B?ZGlYeW5BeDBJNU44cnN4K3l2RzJHMy9GSDQzd29mcitqcGZ6WG41SXVGUDZX?= =?utf-8?B?RkF0MERKWkJWbXluYVhDREp0TnF2eGNPcWt1cmRXd1hIeTVGQXVKcHYxTzVZ?= =?utf-8?B?TmkwZGxDS0c2dHYwUEFpV0xEZ0MxM1dHUlM1cFBNY0Z1WlhzVWZ4NWdsQmdY?= =?utf-8?B?VTc1R0xGN2JTOVAxeFVzT01YMzVWRDBNaW5XT1cxT3lSa2JXYmdrajVObnhs?= =?utf-8?B?WUVtSERoNDJ5dWM3SHBUZlBTQ1o5K1ExQnFEY25HSnNXZ0JCMGJWMlNqelVh?= =?utf-8?B?dXBnMW1uMG84VEFOeStpK0YxZ1JmQlNRN01USERFcCt5K0djYUlBL1BOSWRx?= =?utf-8?B?WGVCbGl1eWpmU01SUXpEYXFTRStYRUlsWGRCRUsveC9SOGpKYXhiQ3VQUXlU?= =?utf-8?B?Z1JRSktGaTVOdWV2YnJ2NzI4cDZWUFd0cVNqQ1RGbWRqOVRHQkc2RjVQUHFh?= =?utf-8?B?VVhwUXBiWjZ5NkJjVE5zeUNmeGl2VjNuYU9sWHcwRVUrcThQWGZXQU10Z1o1?= =?utf-8?B?OTNiWEhiZnFHUjk5RTJhWHk0aGlaUnV4RllDdkRubSs4VVphaWZCbWJYMWpn?= =?utf-8?B?WWhDRVBnaEJ4QU1aSUxFWEdnMGJxKy9yOUhsazRuQ296Qm56SXg3aDhpQ05X?= =?utf-8?B?SVIyOEl3T1hGUzJtdG0zRDRlcmdoMVlXSzRFbVNDSElLRjVXVENNMXlpZmk0?= =?utf-8?B?eHdLcXY0QVBjK0h1ejlHSGhIUTFjQXJzekFkSTZ5T1IyZGRsODZSWnVCRzYx?= =?utf-8?B?ZmJqYXEwSkVaU2toWE1PM3Job2Vabi9rQWVwMTFqV3R4WksyR0hoVlB4b1ps?= =?utf-8?B?YkdUQ0pDNzNtRVl5QnRKMHF5MHhHYzlOclpNK1E4TWxNYjZNOFFEeFFvL2RX?= =?utf-8?B?dytyRnRQenQvMW8waTI0VWhBNzdnbWFNSXFaWU5aUjBDQWg0WlpKRHNPQjNs?= =?utf-8?B?TjFlcVppb0ZDcmZicXN3MGcxaHVta0ZZa3d0bC9TNzc5bldKSCtVT3ZyTG96?= =?utf-8?B?eENVenl2OWtOMXpGZUZxVTdSdkJMaFY2NUQzNnB5NnFQU3NDSXI4MXJyTmM1?= =?utf-8?B?MUU2YkZGTllINW9oTVplYTZqVmNsZWVjMDVERVF1TWlrbEVOb3hSN3VYU1NZ?= =?utf-8?B?ekhoQU9GSzAvaGxFRnJ1UHNjMWE4RFlFRGpxaGlmNEFsNDNEdVl5L1g4dXBY?= =?utf-8?B?eEFDOXQrWW1WRUFCempNdXk4RkdhYXlhMnZrUnA1c0ZMZ2IyNnpZbC9zc0Jy?= =?utf-8?B?c0I1WGRzY1VHaGg2RUlyY1lUZ0NybVVsYUk5RzNxcnVzMjIwQ04vTXY3aHdu?= =?utf-8?Q?T328V5IVM/su2ZtqxXH1B5FDX?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: df8b7a5f-9c0a-407b-63e0-08dc4350ba94 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 11:28:38.7247 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T+sYXTe7+RHPRw4BqVQusNLMR7TrV5dG68nn/HkRJWvSeN+6QXPBgaM4je+XxBBp X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7371 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/10/2024 2:58 PM, Brandes, Shai wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, March 8, 2024 7:23 PM >> To: Brandes, Shai >> Cc: dev@dpdk.org; stable@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v3 05/33] net/ena: fix fast mbuf free >> >> CAUTION: This email originated from outside of the organization. Do not click >> links or open attachments unless you can confirm the sender and know the >> content is safe. >> >> >> >> On 3/6/2024 12:24 PM, shaibran@amazon.com wrote: >>> From: Shai Brandes >>> >>> In case the application enables fast mbuf release optimization, the >>> driver releases 256 TX mbufs in bulk upon reaching the TX free >>> threshold. >>> The existing implementation utilizes rte_mempool_put_bulk for bulk >>> freeing TXs, which exclusively supports direct mbufs. >>> In case the application transmits indirect bufs, the driver must also >>> decrement the mbuf reference count and unlink the mbuf segment. >>> For such case, the driver should employ rte_pktmbuf_free_bulk. >>> >> >> Ack. >> >> I wonder if you observe any performance impact from this change, just for >> reference if we encounter similar decision in the future. > [Brandes, Shai] we did not see performance impact in our testing. > It was discovered by a new latency application we crafted that uses the bulk free option, which transmitted one by one packets copied from a common buffer, but showed that there are missing packets. > ack.