Re: [dpdk-dev] [PATCH v2] eal: warn on legacy memory allocation requirement

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 22-Jul-19 6:03 PM, Thomas Monjalon wrote:
> 22/07/2019 18:55, Thomas Monjalon:
>> When using --no-huge mode, dynamic allocation is not supported.
>> Because of this limitation, the option --legacy-mem is implied
>> and -m may be needed to specify the amount of memory to allocate.
>> Otherwise the default amount MEMSIZE_IF_NO_HUGE_PAGE will be allocated.
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>> v2:
>> 	- user-oriented message
>> 	- trigger warning on any legacy mem option
>> ---
>> --- a/lib/librte_eal/common/eal_common_options.c
>> +++ b/lib/librte_eal/common/eal_common_options.c
>> +	if (internal_cfg->legacy_mem && internal_cfg->memory == 0) {
>> +		RTE_LOG(NOTICE, EAL, "Selected memory layout is static, "
>> +			"allocation can be increased with the option -m\n");
> 
> Or better:
> 
> "Static memory layout is selected,"
> "allocation can be increased with the option -m\n"
> 


Allocation of what? :) Without context, the message makes little sense. 
How about:

"Selected memory layout is static, amount of reserved memory can be 
adjusted with the option -m or --socket-mem".

The slight issue there is, --socket-mem works with legacy mem, but not 
with no-huge. However, i think --socket-mem will produce its own error 
on attempt to use it with --no-huge, so i don't think it's a big deal.

-- 
Thanks,
Anatoly