From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 13AACDE3 for ; Wed, 23 Jan 2019 16:52:34 +0100 (CET) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190123155233euoutp0115fde7aa36352c2f39c888ebfe0204c9~8hSIqRNov2869728697euoutp01Z for ; Wed, 23 Jan 2019 15:52:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190123155233euoutp0115fde7aa36352c2f39c888ebfe0204c9~8hSIqRNov2869728697euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1548258753; bh=V1/YMcDYibXQ4+kJaXRDzZWvC1pkjiELX226OhU4iRc=; h=Subject:To:From:Date:In-Reply-To:References:From; b=Omrq2Uez32+Vv7r71mstsQZnhQ0j8N0N51/sod1BDPJ2bSPud0ByIMkapHXI4V5z6 Qclcx8U56XP/bUpCeUJuhdHiymv35xB1lqmx2j3tSsXfGKeM+WV8IPFsFWcd+AsaLQ qHuD7gYcugTBfMdy5Z6KUvAJ44a3sAA1brfMqD2I= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190123155233eucas1p13289090670a41867712576daf03fe374~8hSIPEuQ-1455114551eucas1p12; Wed, 23 Jan 2019 15:52:33 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 84.F5.04294.0CD884C5; Wed, 23 Jan 2019 15:52:32 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190123155232eucas1p28bdd3a5c220452b81e21e48c19f3e5a7~8hSHTjQ0b2318223182eucas1p2l; Wed, 23 Jan 2019 15:52:32 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190123155232eusmtrp13d258897bd9f15eab312430b9a92fc19~8hSHFZ9hs1586215862eusmtrp1j; Wed, 23 Jan 2019 15:52:31 +0000 (GMT) X-AuditID: cbfec7f4-c77a99c0000010c6-4f-5c488dc0679b Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 5F.9C.04284.FBD884C5; Wed, 23 Jan 2019 15:52:31 +0000 (GMT) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20190123155231eusmtip24a2967602fd78b47c1b67977792e4a02~8hSGfzpF72090320903eusmtip2m; Wed, 23 Jan 2019 15:52:31 +0000 (GMT) To: Tiwei Bie , maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org From: Ilya Maximets Message-ID: <0cae3258-1004-4a93-a124-e8c92be7aaa1@samsung.com> Date: Wed, 23 Jan 2019 18:52:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190122170143.5650-4-tiwei.bie@intel.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsWy7djP87oHej1iDDZe1bB492k7k8WV9p/s Fsc697BYbG34z2Sx+eIkJgdWj18LlrJ6LN7zksnj/b6rbB59W1YxBrBEcdmkpOZklqUW6dsl cGW87vrLVjCLu+LK08/MDYyLObsYOTkkBEwkWhv/s3QxcnEICaxglNjQ9JwZwvnCKDFn9RZW COczo8SmN3uBMhxgLRMv6EPElzNKPHx0gxHC+cgosXBCHzvIXGEBB4lXvYcZQWwRgXSJX1Pu gcXZBHQkTq0+AhbnFbCT+DTtMFicRUBV4tf+g2C2qECERMf91WwQNYISJ2c+YQGxOQUsJDae egwWZxYQl2j6spIVwpaX2P52DtjZEgKT2SWedCxigXjORWLe0T/MELawxKvjW9ghbBmJ05N7 oGrqJe63vGSEaO5glJh+6B8TRMJeYsvrc+wgLzMLaEqs36UPEXaUWLX2IAskJPgkbrwVhLiB T2LStunQAOKV6GgTgqhWkfh9cDnUBVISN999hrrAQ+LmkamsExgVZyH5chaSz2Yh+WwWwg0L GFlWMYqnlhbnpqcWG+WllusVJ+YWl+al6yXn525iBKaZ0/+Of9nBuOtP0iFGAQ5GJR5ejkKP GCHWxLLiytxDjBIczEoivK4X3WKEeFMSK6tSi/Lji0pzUosPMUpzsCiJ81YzPIgWEkhPLEnN Tk0tSC2CyTJxcEo1MC5iEl925cHdPuZ+/lCWZeur3pszSTGeVS22Kns3Z/al7ukfV8+6f3a6 cO2pR2xpfKXJ16+6afpz+uu0F8x1El53ZMrsbv/fb0Run/kvKqFxJyymd+6yfRe/iytWTFqS OM+TeR3bgaSYLt/TlbJ385OsFIrX1p51+s485dUf//kv0pO4q20WrFZiKc5INNRiLipOBABH ufn/LwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t/xe7r7ez1iDN5tt7R492k7k8WV9p/s Fsc697BYbG34z2Sx+eIkJgdWj18LlrJ6LN7zksnj/b6rbB59W1YxBrBE6dkU5ZeWpCpk5BeX 2CpFG1oY6RlaWugZmVjqGRqbx1oZmSrp29mkpOZklqUW6dsl6GW87vrLVjCLu+LK08/MDYyL ObsYOTgkBEwkJl7Q72Lk4hASWMoocXTdU/YuRk6guJTEj18XWCFsYYk/17rYIIreM0osvPcd LCEs4CDxqvcwI4gtIpAusfb6TLBmIQFziW//PzOD2GwCOhKnVh8Bq+EVsJP4NO0wWA2LgKrE r/0HwWxRgQiJsy/XQdUISpyc+YQFxOYUsJDYeOoxG4jNLKAu8WfeJWYIW1yi6ctKVghbXmL7 2znMExgFZyFpn4WkZRaSlllIWhYwsqxiFEktLc5Nzy021CtOzC0uzUvXS87P3cQIjJ9tx35u 3sF4aWPwIUYBDkYlHt4NeR4xQqyJZcWVuYcYJTiYlUR4XS+6xQjxpiRWVqUW5ccXleakFh9i NAV6biKzlGhyPjC280riDU0NzS0sDc2NzY3NLJTEec8bVEYJCaQnlqRmp6YWpBbB9DFxcEo1 MCZb1POt3jCRiyN5btv2KSprFQ2nn7Jgbk80XREro/zlwY2t/Tuark8UTIvd8Uz71eoPbbvP 7983hafxT8fZieUry+9fbdt5TF2h3mP7b8uMLOudPacYb67L5PQ6aLWVmfOsoNDsVz/fPxAo yBCVfS11MlD/5ZzU9Tnp8VPFa3Ke7wyPfs0ox6vEUpyRaKjFXFScCAA7y2ZGtQIAAA== X-CMS-MailID: 20190123155232eucas1p28bdd3a5c220452b81e21e48c19f3e5a7 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190123155232eucas1p28bdd3a5c220452b81e21e48c19f3e5a7 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190123155232eucas1p28bdd3a5c220452b81e21e48c19f3e5a7 References: <20190122170143.5650-4-tiwei.bie@intel.com> Subject: Re: [dpdk-dev] [3/4] net/virtio: use virtio barrier in packed ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2019 15:52:35 -0000 On 22.01.2019 20:01, Tiwei Bie wrote: > Always use the virtio variants which support the platform > memory ordering. > > Fixes: 9230ab8d7913 ("net/virtio: support platform memory ordering") > > Signed-off-by: Tiwei Bie > --- Thanks. For some reason rte_smp_* barriers used directly here instead of virtio_*. So, I missed them while rebasing on top of packed rings. Acked-by: Ilya Maximets > drivers/net/virtio/virtio_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c > index ebb86ef70..cc476b898 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -425,7 +425,7 @@ virtqueue_enqueue_recv_refill_packed(struct virtqueue *vq, > vq->vq_desc_head_idx = dxp->next; > if (vq->vq_desc_head_idx == VQ_RING_DESC_CHAIN_END) > vq->vq_desc_tail_idx = vq->vq_desc_head_idx; > - rte_smp_wmb(); > + virtio_wmb(hw->weak_barriers); > start_dp[idx].flags = flags; > if (++vq->vq_avail_idx >= vq->vq_nentries) { > vq->vq_avail_idx -= vq->vq_nentries; > @@ -687,7 +687,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie, > > vq->vq_avail_idx = idx; > > - rte_smp_wmb(); > + virtio_wmb(vq->hw->weak_barriers); > head_dp->flags = head_flags; > } > >