From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Hyong Youb Kim <hyonkim@cisco.com>
Cc: dev@dpdk.org, John Daley <johndale@cisco.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] net/enic: a couple new features
Date: Thu, 10 Oct 2019 13:19:34 +0100 [thread overview]
Message-ID: <0cba4efc-4405-ff83-9da2-80a0436eaaee@intel.com> (raw)
In-Reply-To: <20190923144134.19066-1-hyonkim@cisco.com>
On 9/23/2019 3:41 PM, Hyong Youb Kim wrote:
> The first patch enables Geneve offload that supports Geneve header
> options. Previous Geneve offload does not work when options are
> present.
>
> The second patch adds the new flow implementation based on Flow
> Manager. So the driver now has two implementations: one based on the
> old filter API, and this new one based on Flow Manager. Flow Manager
> is newer firmware interface with more actions and match items than the
> filter API. enic_fm_flow.c is quite large but self contained. We tried
> to break it up into multiple patches, but it did not really make sense
> in the end. So sending the whole file in one patch.
>
> checkpatches complains about these errors. We checked and found it
> safe to ignore them (false positives).
>
> CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
> ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
>
> Thanks.
> -Hyong
>
> v2: add FMOP_NOP to the flowman header, which was missing in v1
>
> Hyong Youb Kim (2):
> net/enic: enable Geneve with options offload
> net/enic: add flow implementation based on Flow Manager API
Series applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2019-10-10 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 14:41 Hyong Youb Kim
2019-09-23 14:41 ` [dpdk-dev] [PATCH v2 1/2] net/enic: enable Geneve with options offload Hyong Youb Kim
2019-09-23 14:41 ` [dpdk-dev] [PATCH v2 2/2] net/enic: add flow implementation based on Flow Manager API Hyong Youb Kim
2019-10-10 12:19 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cba4efc-4405-ff83-9da2-80a0436eaaee@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=hyonkim@cisco.com \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).