From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE408A09D3; Thu, 12 Nov 2020 17:52:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 82380569B; Thu, 12 Nov 2020 17:52:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 296084CA6 for ; Thu, 12 Nov 2020 17:52:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605199933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/OcVE8C9jciqhqZqdpEQLT2oTv3xz4P9bcDaYcyyAVM=; b=ebwcwHSp364zWwKt16B7BuLsUMCZHa4WR/pqHyepFt4TXVcaTbzkh333AhtwpR7VM/tNj0 TSSQzBCJCu+n/dPWm/90THWBa7yIImseSTSeaaCiI8E5HH5spD6OjsxoRS9otLBuSCRJ4M bQX2aUwXns0sNOr5aJ6GTm7+znjjbRI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-88-NjbOcDGZP5-nAlwYk2X6HA-1; Thu, 12 Nov 2020 11:52:08 -0500 X-MC-Unique: NjbOcDGZP5-nAlwYk2X6HA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8BCCA64088; Thu, 12 Nov 2020 16:52:07 +0000 (UTC) Received: from [10.36.110.32] (unknown [10.36.110.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B90F96EF75; Thu, 12 Nov 2020 16:52:00 +0000 (UTC) To: Cheng Jiang , chenbo.xia@intel.com Cc: dev@dpdk.org, patrick.fu@intel.com, YvonneX.Yang@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, Jiayu.Hu@intel.com References: <20201111111957.46090-1-Cheng1.jiang@intel.com> <20201112154902.54383-1-Cheng1.jiang@intel.com> From: Maxime Coquelin Message-ID: <0cbe0d15-b682-cf20-ab54-057b952253f4@redhat.com> Date: Thu, 12 Nov 2020 17:51:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201112154902.54383-1-Cheng1.jiang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] examples/vhost: fix ioat dependency issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/12/20 4:49 PM, Cheng Jiang wrote: > Fix vhost-switch compiling issue when ioat dependency is missing. > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file. > Use 'RTE_RAW_IOAT' to control conditional compiling in source file. > Clean some codes. > > Fixes: abec60e7115d ("examples/vhost: support vhost async data path") > Fixes: 3a04ecb21420 ("examples/vhost: add async vhost args parsing") > > Signed-off-by: Cheng Jiang > --- > v5: > * Cleaned macro conditional compilation in ioat.c. > > v4: > * Use macros in ioat.c for conditional compilation instead of changing Makefile. > > v3: > * Added fixes lines in commit log. > > v2: > * Cleaned some codes > * Changed RTE_RAW_IOAT check method in Makefile > * Added ioat function definition when RTE_RAW_IOAT is missing > > examples/vhost/Makefile | 2 +- > examples/vhost/ioat.c | 6 +++++- > examples/vhost/ioat.h | 32 +++++++++++++++++++++++++------- > examples/vhost/main.c | 22 +++++++++++----------- > examples/vhost/meson.build | 2 +- > 5 files changed, 43 insertions(+), 21 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime