From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7469B42643; Tue, 26 Sep 2023 15:09:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6465E40698; Tue, 26 Sep 2023 15:09:34 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2071.outbound.protection.outlook.com [40.107.237.71]) by mails.dpdk.org (Postfix) with ESMTP id 4809240271 for ; Tue, 26 Sep 2023 15:09:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g/9rKeq+64XbGBT6j/xpTxhqDoKPJ4YRv3kNSSbOx+9kdL/3Rple+9yAENUnrqmkDxjeyoJlAJ1b6WsALGFB0n4DUo3PJB03X1HlD6T0+Y/IUGquLW3oTdypy9Tk1QytqPCsyJxa1zJu7QXTKF+f3SQAWOQcwDWw1gUC/eYdCNYU/pfAHMxyjJ02f5qzQs+NpMjfuQYfzwrWpjV+jiX5/20nNgH4pW3gHFKWYUPaCCv6Ws39lfzK4Q8koMDiq10IpJPBd95cEHr470dBFBaMGGJ945vM7La2a12bDvWAxLMvmLqR7vzZ/Skih/nWcpa5wyptIBB0vI0vCu1zBdIcvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0DG9A9bBr4wAuTWlbQfGyGad4qkpGrq0ax/FH3N6ZBo=; b=VAgQJxT4rfYDnos+3veQlzoZf9P/jv9J5/Es2tw+VgAO2T2RGGEC/Wm73zhJCb8Gzhv6LLtHs/K/DNbCppwDpOOHBE7Dm4/b4CU4S1phTja9b54gHJ79jQWYF9HAqX9p+IH3j8AppKw1kdUAsMOQ42MkkNHgnp9vG08aFbxqxfSH6ES6/0keH89av01Q+22vEE1dp0ogPnpzMXbCnC3FlTCsrUKba94w/AE3aH9bpKasiATqGhBWxD9+hr2Z3ifBqYPN57BwIimykdqkElSRWcOFPfQhQKsbIvPZ7i6pGozapCcdBmZSPEac9l5Q7Ai3SsKr3xq4N2jAcGjKqsVrHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0DG9A9bBr4wAuTWlbQfGyGad4qkpGrq0ax/FH3N6ZBo=; b=j/EFy3xWwatjOEoS3/7qYvyb36lIrRR2eXXSOPaWTgX76iPyzr2Ygj2qxyprGHxq2tVeDqO1gE9/aFIB/E+iiSz1lrluxbkuqFifJGhmCKmhm+83Gqhu/5atNyoZOOZ9vSwS+u3NVuQCpelvRXH+SYA977GGoS0KNBUacmGGIkA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB7680.namprd12.prod.outlook.com (2603:10b6:8:11c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Tue, 26 Sep 2023 13:09:30 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6813.027; Tue, 26 Sep 2023 13:09:30 +0000 Message-ID: <0ccd594f-e002-4b2a-a421-e9e9a41cffbc@amd.com> Date: Tue, 26 Sep 2023 14:09:29 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 20/32] net/sssnic: support dev close and reset Content-Language: en-US To: wanry@3snic.com, dev@dpdk.org Cc: Steven Song References: <20230904045658.238185-1-wanry@3snic.com> <20230904045658.238185-21-wanry@3snic.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230904045658.238185-21-wanry@3snic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0489.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB7680:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a503f11-ce02-40f9-bca7-08dbbe91d206 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UrobimkvTtQJgXL+Ix8xuLgi1oHse/C4uvAxlAk9nNONL0zin4mr4wsVhUC+jUL8LTB+nGADVQ/V9hWmfoHPV8nG825RcBw1JPADDB0TaFKWEv3g6xvDVOBt9g2wGOkLb53MrhMR+dsEXrxKZcE7cZO6CyCK1i74qHC3B1eVa1eGAVsbaOpGm6TZTiB3TX0c4Gp/Jwxz2xfXWMODVc9ftS/komc1MI+6nNCpy+pX9alkHrZFOqL1TWu70aWcIP98ein7vKYDKuMppNjrAhT8s8ZUq8QUQKEaTEarlGzB6B3mPzWpSnF+0A1B2Esz4cSD0hO37abBNAu12CLohNXK2uSjoJrN+WMNmFm9+quoIOVK68SPQXwlj/5bcLxF7U7R7XEmHYLkUc/2lEWmpdpApu1hmRrrzfhch4m+iuUwHfinQWKrAAbeIn5p3VYF0kH36dV3spMuRRLmSvMURLScuzNQrcQ1LVjjYecnCoGbmei9NsrvTvmNhihwT8BvJyGgzlUjQ1aJ57jMEAt+dmZkdhzVQcYnc4aK2KRO6zhSM/FznwxwjdXN4ouYg3REFr+TRKYVq422VzW44mze4f8kYuGTXv2ZCLgywo7+OKAp3n6bEvxxgdaZ8zt0CWx8/RW+jWKYmvtfj3sISXdNRJieTw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(39860400002)(396003)(366004)(346002)(230922051799003)(1800799009)(186009)(451199024)(2906002)(53546011)(6512007)(6506007)(6486002)(2616005)(38100700002)(66556008)(66476007)(31696002)(86362001)(478600001)(83380400001)(26005)(4744005)(36756003)(44832011)(5660300002)(41300700001)(316002)(8676002)(4326008)(8936002)(66946007)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N01uZHFxajNnU3ZZTzJ5YW1IVjlIUjFJSnRPOXFOVDhRWW1oT0xZMmRCRXgw?= =?utf-8?B?Q1F0NU9uRWR6dDlURGdpdGRnVUw1TlpUMmVwQ2JBMXJvbjUyY3kwbmlhN1c5?= =?utf-8?B?TWFHMjZGRm5jM0FqbzFWbUxMb2c1TUsyUlRwMFFyUUd1dlRPOFFlUWF2RUJF?= =?utf-8?B?UVBRRUhYcW43ZXFxUkErWkNMUXZLY0lFRDdkZjBJNkV2aU4yVTgvQ2R6T3lG?= =?utf-8?B?SWtMVjJadm5ZcUZKTFNESjZFMVkrQXJHVTVwMXo5bHhlbms5dHNIaTJ2T3dP?= =?utf-8?B?b0JaYkhlNGpaeUpyUm5LODFoRkZKelJrL2NLQitzNWdxTURIZ2Z0Y21ubStO?= =?utf-8?B?MXNJWjM0ZWJHVWhYekJ6ZmVGaWRHcEpaaUdxc0tTa09MZkdvN2V5R3U0RXli?= =?utf-8?B?YXJ3bHRQNWViV01tSmluNzlkbWlPK1VURG5BbnJTbDRLS25heEdjOGtWVnlX?= =?utf-8?B?MEhBUkFOL3ZwZTFNS0o0MDBta0V0MFUyQ0RTck1EL3ZkVkF0aDREM3ZuUnA5?= =?utf-8?B?Q0tzOVdNWUJKcEhOV2wxL1hzZEJyN245dW0yMlZxWGl6dXBsTDhIbGVxK0Fp?= =?utf-8?B?azZnb3djK2htZXhpK21zQktoTXErZEx3Qncwd2lZb2NrYUNjL2o2UWk3QWxo?= =?utf-8?B?cXdmY2QzTlhhc2NlazQ2WkZHbE9XUEFwT2pqdWdQZ2ZCR0Nua0sza2FjVk5D?= =?utf-8?B?eHB3aGdEaWRLSjJmbWgrNjdzRU5ZeTg0am04SVVFNlYzR2J0MENFV2FkVW5o?= =?utf-8?B?VUZSMzdqVmpNOXE1Q2NKMWNWazQvSW9WQXdjcitvWjdJbHUwYlkyM05uVHdu?= =?utf-8?B?K3FMUFhZUTFjNlZVK1hMRmhpQW8vamV4UDVsZHZnRW80b3pnWmZOSFlqYXN4?= =?utf-8?B?Mlh0dHd1Tk13Q0xqaTFVREtZZDZRQ1BydUcrdmdUTVRZS253V001dU56emRG?= =?utf-8?B?b1pIbEpZemJXQ1FQajIyM2hKVUNTQ3dZZXpKcWF6cFNjZTdwQVdwT0hVZXQx?= =?utf-8?B?ZXQzL1dCekxIcmd2R0V0QjZwMUhVd2xDUEo1dUJiWEk1N0Y2WTk1VEdHRVdJ?= =?utf-8?B?ZVU4VVZKT1NFdDMxWHUyYlU3cnNUa2w5VG5hWVRJSjBaQ0N3b1RyNmhDZ1Uw?= =?utf-8?B?Q2hNQ283NkIyR2NHSFBDMThJYUpQdHVJRlM5clhJVlY4T2kxVndsbU5yQkRD?= =?utf-8?B?SFE1aTJXOSt0NGtGUDJCclZ2TENndzlnSzMvaXgySTViNHRvT3I1YjFQZVF3?= =?utf-8?B?Z096RytEY3BlUnBZVGVvdkVtV0RQU2NnaWZMN0dDcG1Kd01PTWRzTlhCb2cr?= =?utf-8?B?WnJLSHpJYkNHektLdUxldUlKTFNRVFE4M0RnWklYUHAydkxEY0FFRVhMZ2xT?= =?utf-8?B?V2JrYTRVdGJ1MXFlbVY2RmlnYWs0VHdkQ3FNQmdkRGNuYXVpeFZPdW9yWkZj?= =?utf-8?B?SnhNQjhjYTlUYWd0V2hwTjdxbWNKODZhQTdGVTVJMnBpZktjME9xWFZJSDYw?= =?utf-8?B?UVhuK2RkTXhBTmR1VTBHQ214eXZRWDh3NFl6SUw0ZFo1NUdRRVpmc0xPbk1N?= =?utf-8?B?MG5aemF5RjlmNEVsclRpNnBKVUNQcG1RREpVUlN4UUpVSk5EQzREV1R5Mzlk?= =?utf-8?B?TGYvR1lmMnUrc2JHWHZNdFRCb2tGRlMrWWtnL2kzKzdRMVUrYmtpRmovL1A4?= =?utf-8?B?TUUxaXUwZE5YU0VxazRHOGJ2S1htT2I1ZHphV3dnTXZrQVhISVBWQkoxWGl3?= =?utf-8?B?aWtTbEt0T01nYWJGS2lCc1MwR1h1U2d2bzBHTUUyOFlqb2JwSkszOFFob0tJ?= =?utf-8?B?MUsvZVFpMEVmckE0VjFQRURXSW1ZU1Y1Q0pGQ2h4cjV1TzR2UHk3WW9GSk5j?= =?utf-8?B?bEJuZm9FWVJ0NjFGVXczVVdzZkVHZTQ3ZHhmdGFKQ253eFpkbE5ramxNVEw5?= =?utf-8?B?alk1VmcvTUdJUHdvMHhmRzlJWEN1Z3ZOclJ5WGNzeWFBM3N2V05GcnluSnRl?= =?utf-8?B?UzUvZXdySkFTb2FZSm02aEYvMzNUSDdFNGZyZXZ4WVhjZVhoOUZyNGk1ZUVY?= =?utf-8?B?bERNeGFqREwvbnVmMHR6WDJoelFFcHFJNWx0eE5jeDg4SCtzbWF4ZlBZY1ZU?= =?utf-8?Q?WZeUCgHGPIUFB2WXm1hABPA9b?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a503f11-ce02-40f9-bca7-08dbbe91d206 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 13:09:30.8328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7RD45711+sunpK0Hpop9ylBEP/Ym6p4mLpQkPvJNGEvx/xmlMhUOI+Uc1SAjXl3s X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7680 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/4/2023 5:56 AM, wanry@3snic.com wrote: > From: Renyong Wan > > Signed-off-by: Steven Song > Signed-off-by: Renyong Wan > <...> > +static int > +sssnic_ethdev_close(struct rte_eth_dev *ethdev) > +{ > + sssnic_ethdev_release(ethdev); > + > As close() is mostly empty, I just want to remind that all resources should be freed in this function. I am not aware anything missing, but can you please double check all driver allocated memory is freed in this function?