From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2C8FA04C8; Fri, 18 Sep 2020 19:24:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFFCC1DAFE; Fri, 18 Sep 2020 19:24:43 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EA5691DAE9 for <dev@dpdk.org>; Fri, 18 Sep 2020 19:24:42 +0200 (CEST) IronPort-SDR: KcayNlII3DtAKgrU1pEyDAr06Ju4tokFvT9mATBYLquhXx+xSXvckf+JyG0R0opXOoQGQg1eOx fRIM/zwQPnuA== X-IronPort-AV: E=McAfee;i="6000,8403,9748"; a="157389592" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="157389592" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 10:24:42 -0700 IronPort-SDR: v2uy3X0n+ojjCG2PR5lNyByuP0cWn+mXkSXxdDK9U8158o8a/N0LbxMwsX7rhfq/vXdikESXab xMQ8EElJIn2A== X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="484287109" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.248]) ([10.213.227.248]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 10:24:35 -0700 To: =?UTF-8?Q?Morten_Br=c3=b8rup?= <mb@smartsharesystems.com>, i.dyukov@samsung.com, dev@dpdk.org, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> <CGME20200915190746eucas1p2c80920f3eaff2844faf836eaea4c1d42@eucas1p2.samsung.com> <20200915190728.18143-3-i.dyukov@samsung.com> <98CBD80474FA8B44BF855DF32C47DC35C612EE@smartserver.smartshare.dk> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <0ce90bfe-8b38-95d8-f6b2-215b32aac1cb@intel.com> Date: Fri, 18 Sep 2020 18:24:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C612EE@smartserver.smartshare.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v11 02/24] ethdev: format a link status text X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 9/15/2020 9:44 PM, Morten Brørup wrote: >> From: Ivan Dyukov [mailto:i.dyukov@samsung.com] >> Sent: Tuesday, September 15, 2020 9:07 PM >> >> There is new link_speed value introduced. It's INT_MAX value which >> means that speed is unknown. To simplify processing of the value >> in application, new function is added which convert link_speed to >> string. Also dpdk examples have many duplicated code which format >> entire link status structure to text. >> >> This commit adds two functions: >> * rte_eth_link_speed_to_str - format link_speed to string >> * rte_eth_link_to_str - convert link status structure to string >> >> Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com> > > Great work, Ivan! > +1 > Acked-by: Morten Brørup <mb@smartsharesystems.com> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>