From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17962A0548; Tue, 27 Apr 2021 04:57:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80CF940143; Tue, 27 Apr 2021 04:57:28 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5717F4003E for ; Tue, 27 Apr 2021 04:57:25 +0200 (CEST) IronPort-SDR: +QxJRFYc8KquQqWf95qFJfJ0f0iobcgUqDvmCy2sGBwABs1atu7Z9MAKKlKAp2Bqk8/rarOwO3 XSasl2DRd3wA== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="196550252" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="196550252" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 19:57:23 -0700 IronPort-SDR: nn7XzC+/pyzdIQbmIymq+SdRfF3UEjhCTK4dyrtOD895E75kQZ2sPX3ADoO+LK4Zkj+cPPOa/7 vZltIGB+m0pw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="454488930" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by FMSMGA003.fm.intel.com with ESMTP; 26 Apr 2021 19:57:23 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 26 Apr 2021 19:57:22 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 10:57:21 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Tue, 27 Apr 2021 10:57:21 +0800 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/iavf: fix performance drop Thread-Index: AQHXOl1AdFJRx8jiXEa2nY87MeuTbKrGf/GggACUwwCAAJfCIA== Date: Tue, 27 Apr 2021 02:57:20 +0000 Message-ID: <0cff5b06a6294e5e9cad58e71553d11d@intel.com> References: <1619414983-131070-1-git-send-email-wenzhuo.lu@intel.com> <0e87d690425949c3839a1ac48dc0406b@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Lu, Wenzhuo > Sent: 2021=1B$BG/=1B(B4=1B$B7n=1B(B27=1B$BF|=1B(B 9:51 > To: Zhang, Qi Z ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix performance drop >=20 > > > +use_sse =3D true; > > > +if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) =3D=3D 1 || > > > + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) =3D=3D 1) && > > > + rte_vect_get_max_simd_bitwidth() >=3D RTE_VECT_SIMD_256) > > > +use_avx2 =3D true; > > > > > > Not sure if the right path will be selected when avx512 is not true, > > (CC_AVX512_SUPPORT is disable) while check_ret is > > IAVF_VECTOR_OFFLOAD_PATH? > > > > Currently we have > > > > if (!use_sse && !use_avx2 && !use_avx512) goto normal; > > > > Should we also add below check? > > > > if (!use_avx512 && check_ret =3D=3D IAVF_VECTOR_OFFLOAD_PATH) > > goto normal; > Not necessary. As explained in the commit log, AVX2 and SSE support the > offload features. The purpose of this patch is to let AVX2 be chosen when > offload needed and AVX512 disable. OK, now I understand it, I will suggest to change the commit log. From=20 AVX2 and SSE don't have the offload path. To=20 AVX2 and SSE Tx path already support offloads but can't selected. If you agree, will apply above during change during patch merge.