From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 9CA852BB1 for ; Wed, 1 Mar 2017 11:06:07 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2017 02:06:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,224,1484035200"; d="scan'208";a="829669685" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.69]) ([10.237.221.69]) by FMSMGA003.fm.intel.com with ESMTP; 01 Mar 2017 02:06:04 -0800 To: Bruce Richardson References: <1485163480-156507-2-git-send-email-david.hunt@intel.com> <1487647073-129064-1-git-send-email-david.hunt@intel.com> <1487647073-129064-9-git-send-email-david.hunt@intel.com> <20170224141442.GJ106392@bricha3-MOBL3.ger.corp.intel.com> Cc: dev@dpdk.org From: "Hunt, David" Message-ID: <0d268a98-120e-b709-90b4-38ee6996a3cd@intel.com> Date: Wed, 1 Mar 2017 10:06:03 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170224141442.GJ106392@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 08/17] test: change params to distributor autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 10:06:08 -0000 On 24/2/2017 2:14 PM, Bruce Richardson wrote: > On Tue, Feb 21, 2017 at 03:17:44AM +0000, David Hunt wrote: >> In the next few patches, we'll want to test old and new API, >> so here we're allowing different parameters to be passed to >> the tests, instead of just a distributor struct. >> >> Signed-off-by: David Hunt >> --- >> app/test/test_distributor.c | 64 +++++++++++++++++++++++++++++---------------- >> 1 file changed, 42 insertions(+), 22 deletions(-) >> >> diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c >> index 6a4e20b..fdfa793 100644 >> --- a/app/test/test_distributor.c >> +++ b/app/test/test_distributor.c >> @@ -45,6 +45,13 @@ >> #define BURST 32 >> #define BIG_BATCH 1024 >> >> +struct worker_params { >> + char name[64]; >> + struct rte_distributor_v20 *dist; >> +}; >> + >> +struct worker_params worker_params; >> + >> /* statics - all zero-initialized by default */ >> static volatile int quit; /**< general quit variable for all threads */ >> static volatile int zero_quit; /**< var for when we just want thr0 to quit*/ >> @@ -81,7 +88,8 @@ static int >> handle_work(void *arg) >> { >> struct rte_mbuf *pkt = NULL; >> - struct rte_distributor_v20 *d = arg; >> + struct worker_params *wp = arg; >> + struct rte_distributor_v20 *d = wp->dist; > The cover letter indicated that using new vs old API was just a matter > of passing a different parameter to create. I therefore would not expect > to see references to v20 APIs or structures in any code outside the lib > itself. Am I missing something? > > /Bruce > Patchset has now been reworked so the api switches over and apps migrated to new SPI in one step, so _v20 never exposed. Dave.