From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6ED3841C61; Fri, 10 Feb 2023 21:29:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CE1E410D3; Fri, 10 Feb 2023 21:29:06 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2066.outbound.protection.outlook.com [40.107.92.66]) by mails.dpdk.org (Postfix) with ESMTP id 7207040687; Fri, 10 Feb 2023 21:29:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aQeHSy0ZGk+frt+cUfQgeo3YJ3Iuwlmlp6u4WngCIXIQ1a1jDoSsHfCn/rwBQRvp98owKWtK2Mjd/uLW2OdFWtZHvq5SC1Z/BT48K6MDBGOVwTU7ABrfjdHYCDl2CU7cTXD/HkLFxUm+4m9vpneYPru5iFKivXPvthh5VhvTDsylVnN8tfxvBig/3v/ChZ3jZZYghUIF4JaXYTdZznmyOrdyV9RVH5k8ELZX5tTZtaDiW1WZBHsry5X05a7S1GcAgUiptn2BmgsA9EhBB0pdp79SAsNC45LwqPa+A6YzGa4zFv+MAJ/qk/xvjbZPU07nKpKwaFPWZ9g3iX6IrtcLHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RXKGLpxOSSi4KI2pb1UK23p2WvE6aKXBPvBoPcWOL9o=; b=gTzPPBY5ElyOTWIjjixpbe//gNlHapCdvOFKrNuhVq1Msge2FUySun3jGDebwbEcJ5Q83LHBOxDGw+LsBrBsHg0Y4OFbElzGfsHwNQJv9a5LPB1fxba915ctsL2j/E7XfaA1wJcanaabCh0SB4uysY7H1zBgHY4r9iM1/4HB8TANniwosD/G4Z1JVbZXRz37OyoB5NnGiBCXYcxg5o3t8lTXpIB2UNLFpT08RIVCymyQS27AT58PAKa+x1YRXN30hFx5jl95tzOrpIVmmAU4IV2spe0GyGkLYKto9vEJmKWo/46AicblrZBrKEAQI8C57NNFw0bJfngrPrFASgZZFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RXKGLpxOSSi4KI2pb1UK23p2WvE6aKXBPvBoPcWOL9o=; b=Z8Mhrc17WCzYXbpK92pO6jjEJeWwgnxis+4txWtcIsmF9CxPi8aoGzPhXTxuhi2vK6DgV6OWGC27jDLFJOXbeIi8ya+K1w3tnmC41dbKCbBBkCD+Xpuq9HJe74Al5FcH/Pgj07K8R+JS5KnNoMHL9vdmadDPVj57cdpk+e0px4w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB6581.namprd12.prod.outlook.com (2603:10b6:8:d3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Fri, 10 Feb 2023 20:29:02 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6086.021; Fri, 10 Feb 2023 20:29:00 +0000 Message-ID: <0d366cd7-a22e-51cf-935c-ddfcf6a20c5f@amd.com> Date: Fri, 10 Feb 2023 20:28:54 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Peng Zhang , stable@dpdk.org References: <20230203013617.36358-1-chaoyong.he@corigine.com> <20230203015926.5235-1-chaoyong.he@corigine.com> From: Ferruh Yigit Subject: Re: [PATCH v2] net/nfp: advertise no support for keeping flow rules In-Reply-To: <20230203015926.5235-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0538.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB6581:EE_ X-MS-Office365-Filtering-Correlation-Id: ad652ef1-58ca-4269-be4c-08db0ba57111 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /M7UPmGxSUiz4ZPxD2T8MDYL6ckI9YngwJlsj0DMBBwirFHslCf0hSGQ4RbyOgSl+vLAQW9bDsAo/WnY8ueKDu6UeBL5PXtrbSHXv7FYjW8zw7ouroGrcCqcIhnPl2nFQTac1TLSLLyP7oqBc9Gd0XHY1gYoHPvWfNiRelK3ycZS7VORndBXtD5oStNbQp2P0DXJMv3vcb4v9GYJ0k1V6WUZ28aOshha/HPsrY2w+aiTNWumyff/W2g932HBo2BH16A/k6jKY1UW8HcIchLeU9UNFwySYgi5HxQIbrtyCeV/lDooyYNxcG2wESZry16I0RSmLqpFCi1gDER4QP5B3Cf1xyRY3HnwPktls3CtTtOwcxMLlSdcZvSr66i3nNxawvRLFv6nodk9GpT76RzgZv9WhZlZMCbYDF3SscGN59RNgGF3o8Z4qHuDh3+qEh5W1Gxhfm3os89RrW4RQMFj1EaZOCFRBGb/fDEvIDCgIjpUyiunN5XK9HV5x0dkd6Dn9Yy1qnyZnbewUq7DiEQW54wPb7wDiTU9p6VgzWBjFXUFyXM8LrzqsM4vb0VOVwlUJdTdYR65YnNURpFwknuBYZ/utJZaRoq68sxcX3kbdWeIaeiUS0SQFXA3MABjf1w+5jh79qEyD1enBL3XfY4gzXZcKxNbeod7mqTYOAxRv9MLmBRVOA9rvGzuuPm1trNnI1+JghYqPEZvNVlat7tDzWsS5GovBFYxRfu4nZEBzu0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(451199018)(38100700002)(316002)(66556008)(8936002)(8676002)(41300700001)(2906002)(44832011)(5660300002)(53546011)(6666004)(6506007)(66946007)(4326008)(6486002)(66476007)(2616005)(478600001)(6512007)(186003)(31696002)(86362001)(36756003)(31686004)(26005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WndKbSt2cktxQzFkU1JwRVFtbGVtejBqT1NkQ1F4YzJyTTBqc0RiTFd3Yjhw?= =?utf-8?B?YmU0NFlOdktrMUNxRitPdzZhZHJ4bTd3NU1zSlZKbTloMHQrNnlaUTZOSDQw?= =?utf-8?B?Q3pqejJoSEZIaStkL3N1blNzSjZHNVZmYzc1aGtCaG9IKzF1Z21PQndSWUdx?= =?utf-8?B?UUVDMGNvU0tTR3I5ckR1NHlRL3hBbGJwcFdmdThFYUpuVHExV2RPRmxhU2ox?= =?utf-8?B?Wk5hSy84WitoNFhaQlJOK0cxbUlybEZQL2xsd1pUZTV6Y0NvcWF0RGJCVGtR?= =?utf-8?B?T3ZPbUdwUG5NNGdGMHI3bWFvejgzNmZTM0xHLzZlVVA2eDk4MnBBSjd3TE1j?= =?utf-8?B?cDBqVUR6VE4vbWRacUZKRHcwZnFnQlZyVWk3ZGlDSmNkR2R0eDR2T29QVi9p?= =?utf-8?B?N1pEeGl4WWh0OVBxYmJyU2wra3lheDYzSzBRc2pwU1FIUXg1bjYwK2tsNkNO?= =?utf-8?B?TG91YS96R09FekpwVzREMWwreEdFNmZPTzB2UWxSdEJlTXRNK0FYU1JZNVRs?= =?utf-8?B?VjNER3NKN2VTdFVGMDkvR1lCWTl4VXRVMW1BNWdVSEZKTitUakwwT0J4MWtn?= =?utf-8?B?SzBuVVhFbm9qYjd5all3M1VVNkpzcWdUUmk1RDdmckJqQlBWTmxodWNpS1Rx?= =?utf-8?B?TEdTSTZFUzRMSFVSd0NuYm5IakQvZHFFUCsxR3VHVCs4bHBrSXlac0RmSUpx?= =?utf-8?B?WW9DSFFFR1FaWVpFQVJsU0FES1Qvd3NWVVRzTG9yVEVMZTMrRUFhQjF5VU1B?= =?utf-8?B?UmQvT3A2QUVrNm4wa2xFMEFSUGkrc2hVNytncVp1NWtGVkxuZmZLemYvNlBF?= =?utf-8?B?OTVFUVNMOE5Nc3hpQUhweTYwaWgwSmdVM0ZwcDd5RUwrZFl5U2dCWVdvWjll?= =?utf-8?B?S2tMbWduUmcxZjZ6R2IrdCs4OTFnZWg0WUxKTjd2K1FDVm1Xa3cvclpMa0hs?= =?utf-8?B?VEhDaHh5V0ZwSDRKcmVocm1OK1M4ekx3NTgydk9TQytjYXR5MnZhTG1oV1VQ?= =?utf-8?B?VEJtZXJFV3JiR2p3cTlSVlhtdmkrVXhVUndvSkZHbytaRE9LNVkvbjhrSHha?= =?utf-8?B?U3pFdVpKMWszYllEakNPcW9kRTRqbVFHZ0YzRTJ0UWNjandudFc1NHEvcnBR?= =?utf-8?B?YnU3MnR5dDQxMU1HSGlTK3IzUjNpWkt1dU1SVDBlcGJwSG55RkYzdGtTN3U4?= =?utf-8?B?M1hSZnRMQTE0YllSRFJ6YlhndEMxRDVrNzIrQ2JuVGg4aGcvYUJPM0tqUGtS?= =?utf-8?B?d0l5QVFaTWhOOGhCa2FVd210K3dIeTArdENvZDVFdVVtSXp6MDV4anppWjVj?= =?utf-8?B?MWdaaUNPR3FxVnM1YzE1bWhnYncxSnBzVzAzSmlTUGlHelZjaXY0LzZZTkxP?= =?utf-8?B?WDNTZ20wMXFwQkVFRUpGSUE5VXRzTTJFWHZkbUR0Zk8xdkxROElOaXQ3V1lV?= =?utf-8?B?aW9UNHJ1b0JiWmdWcXczOG4rS0QrSjZ3anNyblhmaUtTaWg2SXVKQ1hTY2Nq?= =?utf-8?B?VVpNMHY2YisvZVI4YlFHSzVRZEcyR2FWVzZHR0xXQmg2eDQ4d2F5YTlPajhY?= =?utf-8?B?QnI5VC9oeE5HWmorQXUxN3hpbzRGZTdNUjhkQUhTSTNHM0dhVExDSTN4dTRo?= =?utf-8?B?NTNUME1EMTZRcS9tYWFQRFVKeWlzN2dxVnhsUzhUMXdJcXdndXFJS3NMbGho?= =?utf-8?B?U3RJSnB4UEYyYVlPQ0x6ZUh2MkJ2dlh4MExNdTRpSG5xU2N6bFZSWXZmakRx?= =?utf-8?B?OEhCUG9sL3NHUEZTSlBMY0tTRDg4L2NWZ2pMazgyc2RRLzV6a3RuKzlPSGZB?= =?utf-8?B?K1Y3bVVqR3lnZElyTU00ZHJZNVBKLy8rcGFWaXdOK3l4aXhPSHB3U3dsMHpW?= =?utf-8?B?SkhHTnNtOElsbFdjRnFxdnhTSW9mZXZDeUxQZzF6ZFZOTy9Sek9DSjFuVGJU?= =?utf-8?B?NEFoc0dDcUNmN3QzNjRYR0htWFpEM096T1VmWng3d3JUTitUZFp1SHQvQ2dr?= =?utf-8?B?RjE2WEJ0VHhweFpXWGdEVEhSbkxtQVBEOHQvdDVqWGRJRjAvc1FxaEE1dEhD?= =?utf-8?B?dTEzcmEwUjB4N1dOcFRNaUt5Y2Rhby9QWUVLYldWYWtTMmZDdHg4NXFpMVl6?= =?utf-8?Q?ryDH5IDXPxFzWh+inIoOpgNER?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad652ef1-58ca-4269-be4c-08db0ba57111 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 20:29:00.0366 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0TRp28W1e5uGHYEP9ckC+iQ+cpzK+J8czxAHJc4LKlkZdB9D6KuEdolOBd+i7nZ0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6581 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/3/2023 1:59 AM, Chaoyong He wrote: > From: Peng Zhang > > Explicitly clear the RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability > bit to match behavior of other PMDs. This was missed when first > adding flow support for the NFP PMD. > > Fixes: 30ecce522732 ("net/nfp: support flow API") > Cc: chaoyong.he@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Peng Zhang > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > --- > v2: > * Fix the wrongly 'Reviewed-by' tag. > --- > drivers/net/nfp/nfp_common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c > index 71711bfa22..5c191b01ef 100644 > --- a/drivers/net/nfp/nfp_common.c > +++ b/drivers/net/nfp/nfp_common.c > @@ -794,6 +794,7 @@ nfp_net_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > dev_info->speed_capa = RTE_ETH_LINK_SPEED_1G | RTE_ETH_LINK_SPEED_10G | > RTE_ETH_LINK_SPEED_25G | RTE_ETH_LINK_SPEED_40G | > RTE_ETH_LINK_SPEED_50G | RTE_ETH_LINK_SPEED_100G; > + dev_info->dev_capa &= ~RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP; > > return 0; > } Nack Above code has no impact, it has been added to drivers to highlight this feature to driver maintainers. This feature is added to ethdev layer and requires driver support, but driver maintainer may miss that this feature exists at all. With above change driver maintainer can chose to remove that line meaning they are aware but not prefer to support this feature or properly add support it. For your case, no need to add it explicitly, if driver doesn't support RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP, no action is needed.