From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 602F0A04FD; Wed, 22 Jun 2022 12:29:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F02ED4069C; Wed, 22 Jun 2022 12:29:47 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 1439C40689; Wed, 22 Jun 2022 12:29:45 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LSfgG669ZzShBg; Wed, 22 Jun 2022 18:26:18 +0800 (CST) Received: from [10.67.103.235] (10.67.103.235) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 22 Jun 2022 18:29:42 +0800 Subject: Re: [PATCH V2 2/2] net/hns3: support backplane media type To: Ferruh Yigit , , , References: <20220611074227.30276-3-liudongdong3@huawei.com> <20220622030957.20615-1-liudongdong3@huawei.com> <8689c6e8-935b-e2dc-3276-d2970a8bd982@xilinx.com> CC: , Chengwen Feng , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou From: Dongdong Liu Message-ID: <0d623060-71ef-df8a-49c5-9f6973994a4c@huawei.com> Date: Wed, 22 Jun 2022 18:29:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <8689c6e8-935b-e2dc-3276-d2970a8bd982@xilinx.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.235] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh On 2022/6/22 18:06, Ferruh Yigit wrote: > On 6/22/2022 4:09 AM, Dongdong Liu wrote: >> From: Chengwen Feng >> >> The 802.11 physical PMA sub-layer defines three media: copper, fiber and >> backplane. For PMD, the backplane is similar to the fiber, the main >> differences are that backplane doesn't have optical module. >> >> Because the interface of firmware fiber is also applicable to the >> backplane, this patch supports the backplane only through simple >> extension. >> >> Cc: stable@dpdk.org >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Dongdong Liu >> --- >> v1->v2: >> - document new 'backplane' media type support in release notes. >> --- >> doc/guides/rel_notes/release_22_07.rst | 4 ++ >> drivers/net/hns3/hns3_ethdev.c | 54 ++++++++++++++------------ >> 2 files changed, 34 insertions(+), 24 deletions(-) >> >> diff --git a/doc/guides/rel_notes/release_22_07.rst >> b/doc/guides/rel_notes/release_22_07.rst >> index dd371952c3..7884ecfd09 100644 >> --- a/doc/guides/rel_notes/release_22_07.rst >> +++ b/doc/guides/rel_notes/release_22_07.rst >> @@ -172,6 +172,10 @@ New Features >> * Added support for yt8531s PHY. >> +* **Updated HiSilicon hns3 driver.** >> + >> + * Added support for backplane media type. >> + > > We are sorting PMD updates on vendor name, so can you please move update > above Intel updates. will do > > Except above minor release notes location order, patch looks good to me, > but it requires hns3 maintainers ack/review to proceed. (Same for both > patches.) Lijun Ou and Min Hu current do not work for the hns3 driver. I will do the work. I will send a patch to update the hns3 maintainers. Thanks, Dongdong > > Thanks, > ferruh > . >