From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E110425FF; Thu, 21 Sep 2023 13:06:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C4FB4067E; Thu, 21 Sep 2023 13:06:46 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2072.outbound.protection.outlook.com [40.107.93.72]) by mails.dpdk.org (Postfix) with ESMTP id 910B5402C7 for ; Thu, 21 Sep 2023 13:06:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U4IJsZmVdwaX6Gw6mIaIvYjvDxw1B4akclty8AxTIkVc3vuSXSDMFRK7f+mVYqrfs+8adMaoL51rF/gldFDcZEgCOZI041wz618uTXokw9A9VlngWbH1Zu1GnQ2CMhRAEqIj5c/bhHquro2W45rvw9bgH4tXNr80lcgh9+TeTpDhYHiRB//fuizMWhgw0CQrSyiOLCUsIBtkQmJyBf341U5MbeDqfXXrlf6dyldeqBaPi198gfTIQ7UKTsgMmFOhBizsTDxqopVjtxwdOTMt5GSPVs1APxKukf/ossVvjOZInJehxZhUs6m/WegQMzJT4RYAJZJwGJDjISIpBH3b5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=938Yjl2jvx4CBAoxrhAd17mWfbaNJQP3W7S/Z/lrGSs=; b=lzqUzR5frBI9rB5JmsH4dhZun3kGfGEjYu6IHi3Ecdq7Ia5w08/GWKKVtb/aFT3JyG5GI28Uuk8XhUHT3r4Gqx+oBveJ3/m70ZIZwC7woQu5lRv7alPfQL3HbbaMP44FRkw44qISa/mgNFO5KuTW14YuuDWJo9ItzbPrOZOUvM8+krFJjfjW5RdeFdmZNgdDa0pJs9XW2oi+pjSYj4y20Oe0UWN0kNJj5tG1tcUNtxAbK/Wx/QXVrmDwsqTsq6iqgawJIWq+b1AP/Bj6K5df/7EIfGWTjoIlKLmSqxAR9QdB80EOMqunbjC62xEnKeIaHIsYAy6a2qt54BEyGFA7+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=938Yjl2jvx4CBAoxrhAd17mWfbaNJQP3W7S/Z/lrGSs=; b=XPHpO2jNQb8QgNL5nTJEOPrkoP75VETNcEmYwF1tbw/VmR91cX3Oi1lD+9k1/AZ1rtx3R0QYBDKN4eKy703e62mgnxAryIlkfGlB6r7O0Q9d37tO51GyGt3+kcyLHxxvuIc0J2Jl0y7S67RBAGZDNHpU6eIXQk7pUatkcAuwG7Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5325.namprd12.prod.outlook.com (2603:10b6:5:390::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Thu, 21 Sep 2023 11:06:42 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.026; Thu, 21 Sep 2023 11:06:42 +0000 Message-ID: <0d7f429c-8862-4f16-b7e5-46d69581f54f@amd.com> Date: Thu, 21 Sep 2023 12:06:35 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] ethdev: add the check for PTP capability Content-Language: en-US To: "lihuisong (C)" , dev@dpdk.org, Gagandeep Singh , Hemant Agrawal Cc: thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, liuyonglong@huawei.com References: <20220628133959.21381-1-liudongdong3@huawei.com> <20230817084226.55327-1-lihuisong@huawei.com> <1834a6a9-ef92-4a67-a987-490151cf5380@amd.com> <242e8583-969e-d8ca-2dd4-80e8cf73a662@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <242e8583-969e-d8ca-2dd4-80e8cf73a662@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0132.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::24) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5325:EE_ X-MS-Office365-Filtering-Correlation-Id: 63fc104e-723a-47ca-6306-08dbba92d62b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h9c4g/lAalA2k4X5kHbHpIXoZYLNP8iHFlccxhIKXrvoClR4skGH7JzFzcVjFrvG7ddRQgqHcojE4cj2ZBHVoeWQrq81RyceV9g050YrFJvpq0RTpM1rLC7jScA+/LOuWj585t9fbJGoHgyUeFZpF5aVcnsv7iKkPuSiP0JOCIhPRaG3awuqh2flvHtounTefFEr/mPE7WEJc3UBc24Gk7Ka25rPCOKhQq7HFvN8WER5K94+QyTJSOOr5CWqSD2WW4AlHDPuSc5vxyuz42Ri8GWEqOV5CF/aLpDxzy9f5HTfaWCO2RJoS/yLrTrnBe5+WHmu6azoI6oKWJFGj0aUbigYXrd1MDeQsA5DxV/P+OBITzWeoVEKSEbvgomnqDZFezSufPwsvJCPmgz5A4JHqMVKAH4VLEZOpvGwR30tDIZR6Y/19xMiSwo9/ML31gA/eX4LqNCNfrfwdHUoqYJ0ymZ5XKUAupXzRT6AZ66uVKbPyrduBPCaS+uiBI55NiGib0i6/WO89VIPdpdmuPpxXD3d5vDJUy+438dgDW+UIYoYX4xWgiRGIwW2gdLnzosm2zqYbF6YpLMh3NR0LBPMw+q9ykUYXHpz86Zb3Wps0vkLuMCsA08QXgUWYL8dtVh01qO4/mu49hJeJSi1KASeFg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(376002)(136003)(346002)(366004)(1800799009)(186009)(451199024)(83380400001)(53546011)(316002)(66556008)(66946007)(66476007)(6512007)(6666004)(6486002)(6506007)(2616005)(26005)(31686004)(36756003)(478600001)(44832011)(110136005)(5660300002)(2906002)(31696002)(8936002)(38100700002)(4326008)(8676002)(86362001)(41300700001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVBnM1hqalhsNVNqais1MTgvdFpVSU1lOXVYWVh4RmtxSEZnNVN3bDdEV3Vk?= =?utf-8?B?YndJSGltMUFiOFB1RUVVWTdra1VlMzBtUGpVRExNUHExUCtlRzNGbzRDTDRW?= =?utf-8?B?VE4wM3NkSnJGbTljdFo1OGtLemQ1Q2lva01wVk9tMjRmY3Q1ZzJLK2lkYlIz?= =?utf-8?B?TWdDa1UvckRkVDhnKytPMWxOeUQzcVRGRXFLQ1luRWFPUlpodjFZV1F2RFhs?= =?utf-8?B?WkNGOEtUUCtQTURBZlBYcy9GWVNaUmVIQ3hPREV6ZENMMW5HbWI0bnoyb0hL?= =?utf-8?B?WkNad1FMQjVoUG1XNW1VNDZ1aG4zeFJBWlRIdXd1RHJ0cURmblhialkxcGdV?= =?utf-8?B?OTFrNWtlcUJMcHFiZW90SjY4bTN0eGJIbU81bTkzNkpiQjVkYTkybUVORWdN?= =?utf-8?B?OXNSdTkwQTVVY2VnSlhxOHRnYkp0Q1BGN25jM3hpd1B6Y2N1THcrMlhFVmpB?= =?utf-8?B?TkdpUjU0c1BYVzlJQTV6Y1FySmhwUlp3SXA3VEs2NzcydWtkaUlZRGlNV3RV?= =?utf-8?B?NVdsenZIalgwMGpoQ3FwNHFESnNmNDZSM3BXV2ZZMFc4MXhjSFUyN3piY050?= =?utf-8?B?Wk5Sekc3b2VSZmh0YjNVOStIc0pGM0xQdld6bUlVZ0cvOWFZV1A2bTBzaDR5?= =?utf-8?B?UGYzU0lWdm9IMkJFd3A1UVd4Z0Z2RTF5ZTEvRWFWNllWbFZUZjdzQmRoNE5G?= =?utf-8?B?ODNmV3NUOEFYWllEblI5QmhiREc4YlNDRkpJYW1WdDJMSEdHMEFXUGN6b0hW?= =?utf-8?B?Mm5UUmZYWWVwSUtOVDYwM0drV1IzOU9aTk5Pd1BRWFhONlk2bzhHYmduVmI3?= =?utf-8?B?Y1NPWkhVdjRmRk1GdzlNWmhjUWJWTkVGL3FMamtqeW5hRmk4MzBEQlh3WFNG?= =?utf-8?B?TG9hTTVGM2xsYlFkUmM3SU5ZVjRlZ21oODZLUzRQM252bTc0R2pzazVWSkNV?= =?utf-8?B?bkRuVk4yaDhYTkFKajJqUmEzTysrUFpIWmZFVjUzYWZlSkE4UjF5WU9JWElK?= =?utf-8?B?cjVROGhpTVczVmFYWkNXbTJ4aFp2ZFVpT3lFMEVpZ2ZDL09uSkhDcFUzMXlh?= =?utf-8?B?ZksvMzVyOEpZWCt4YkplMXEwZ3IzMkVFNGIrMEZWbHZtMzZnbW5WWWhxbnpx?= =?utf-8?B?NUlIaWFmK1VOeWk2VnovMjR6d3BwNGZyOEZYek0xSUt4WXplVGYxT1JxUU93?= =?utf-8?B?eDlFUXFQNHBHVGFWZzlPTmM5NWJBWGNBOVlmQ2cxOWZZTnloQ1VWZk9vbVQw?= =?utf-8?B?UEgwNXNPSUNnZGJJSmRSNDFyRk13VVlkRlA4N0NFUFRNMWhSd3IrMkQxRHo3?= =?utf-8?B?UjRRNkF4eVdlQjBiMU5pS1lMWE1HdDk0b0J6N0d6WTlqWGxYM1ZNdVluTG84?= =?utf-8?B?ZVlmVHVIZGYzQ0NtOVBvT2JvQS8zS2tPMHRKaHk0T215OWdWTzNhdjFXRnNv?= =?utf-8?B?M0ZWWTVWaGRTd1J0ZEkzYytCT1hsTmlPQ3p3djBYZnBtSDZhYWYwUCtFdlFh?= =?utf-8?B?MitaTXpSVk9ySG9ZeGsvRjc0UFE5WWpxdjE4Ryt2cUNKRDJPa1J0QzdpSC82?= =?utf-8?B?cCszK3ZKc0J3TFVOcFRCY0FkRE9FSEU3NURqbHFKSTNqS1hIMEZKb0VyVHVh?= =?utf-8?B?T241UDNhcHhleEs3Q3Q5U2VMZUU0WDBSbWk3TzRuNHBpaDdiQlhaOTJnamxE?= =?utf-8?B?KzAxQWNjNVdESnBXdUxFMUNQS3R4Ui9Qek1KTis5dzNhSHJEL0JaWkpsRWNW?= =?utf-8?B?N0dMM0FLTjM4aFoyVExkTExsbUFVQkY5UldVTFpGLzRaMUVKMnN3WElJUjND?= =?utf-8?B?NWk5NW1oQ0xkSE42NVp6Vk5QR2VtUVZSek5oL2dabkppTFNJNGN5eWlaR3p4?= =?utf-8?B?MUtWdGhXUHYrWTZZN2JzUHNVcytFcy9XSUpsZkxoUzVSQXdzNURvNjhEQjFM?= =?utf-8?B?TWFtc3ZxdE5HaCsrZXV6bUFScUt6cHVjcmU4bFRBQTk1TDd0Q2dRR3lXOEVw?= =?utf-8?B?Tlg4UjlXWllCb2ZqWnpiSGVCU2h3a0Z0SUZ6QWg1aElKV2R5dFVvUU50cVdQ?= =?utf-8?B?RUhSa2RzTGluMFRNZDF5TlgrZkRiK05YVzUzdFM3NGkySGRCZkZXQkQ1UTZY?= =?utf-8?Q?pB51dLwjPsC2nIj+l2xaxUEkH?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63fc104e-723a-47ca-6306-08dbba92d62b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 11:06:42.6094 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b1jTSlD83YvLae3orG8a7cMfLZ48i7pKoxSEDDRmb/KO4enbpJK/y5o8dUxjL1OV X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5325 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/21/2023 11:02 AM, lihuisong (C) wrote: > Hi Ferruh, > > Sorry for my delay reply because of taking a look at all PMDs > implementation. > > > 在 2023/9/16 1:46, Ferruh Yigit 写道: >> On 8/17/2023 9:42 AM, Huisong Li wrote: >>>  From the first version of ptpclient, it seems that this example >>> assume that >>> the PMDs support the PTP feature and enable PTP by default. Please see >>> commit ab129e9065a5 ("examples/ptpclient: add minimal PTP client") >>> which are introduced in 2015. >>> >>> And two years later, Rx HW timestamp offload was introduced to enable or >>> disable PTP feature in HW via rte_eth_rxmode. Please see >>> commit 42ffc45aa340 ("ethdev: add Rx HW timestamp capability"). >>> >> Hi Huisong, >> >> As far as I know this offload is not for PTP. >> PTP and TIMESTAMP are different. > If TIMESTAMP offload cannot stand for PTP, we may need to add one new > offlaod for PTP. > Can you please detail what is "PTP offload"? >> >> PTP is a protocol for time sync. >> Rx TIMESTAMP offload is to ask HW to add timestamp to mbuf. > Yes. > But a lot of PMDs actually depand on HW to report Rx timestamp releated > information > because of reading Rx timestamp of PTP SYNC packet in read_rx_timestamp > API. > HW support may be required for PTP but this doesn't mean timestamp offload is used. >> >>> And then about four years later, ptpclient enable Rx timestamp offload >>> because some PMDs require this offload to enable. Please see >>> commit 7a04a4f67dca ("examples/ptpclient: enable Rx timestamp offload"). >>> >> dpaa2 seems using TIMESTAMP offload and PTP together, hence they updated >> ptpclient sample to set TIMESTAMP offload. > There are many PMDs doing like this, such as ice, igc, cnxk, dpaa2, hns3 > and so on. > Can you please point the ice & igc code, cc'ing their maintainers, we can look together? >> >> We need to clarify dpaa2 usage. >> >>> By all the records, this is more like a process of perfecting PTP >>> feature. >>> Not all network adaptors support PTP feature. So adding the check for >>> PTP >>> capability in ethdev layer is necessary. >>> >> Nope, as PTP (IEEE1588/802.1AS) implemented as dev_ops, and ops already >> checked, so no additional check is needed. > But only having dev_ops about PTP doesn't satisfy the use of this feature. > For example, > there are serveal network ports belonged to a driver on one OS, and only > one port support PTP function. > So driver needs one *PTP* offload. >> >> We just need to clarify TIMESTAMP offload and PTP usage and find out >> what is causing confusion. > Yes it is a little bit confusion. > There are two kinds of implementation: > A： ixgbe and txgbe (it seems that their HW is similar) don't need > TIMESTAMP offload，and only use dev_ops to finish PTP feature. > B:  saving "Rx timestamp related information" from Rx description when > receive PTP SYNC packet and >     report it in read_rx_timestamp API. > For case B, most of driver use TIMESTAMP offload to decide if driver > save "Rx timestamp related information. > What do you think about this, Ferruh? >> I would be great if you can help on clarification, and update >> documentation or API comments, or what ever required, for this. > ok >> >>> --- >>> v3: >>>   - patch [2/3] for hns3 has been applied and so remove it. >>>   - ops pointer check is closer to usage. >>> >>> Huisong Li (2): >>>    examples/ptpclient: add the check for PTP capability >>>    ethdev: add the check for the valitity of timestamp offload >>> >>>   examples/ptpclient/ptpclient.c |  5 +++ >>>   lib/ethdev/rte_ethdev.c        | 57 +++++++++++++++++++++++++++++++++- >>>   2 files changed, 61 insertions(+), 1 deletion(-) >>> >> .