* [PATCH] build: enable developer mode for all working trees
@ 2022-08-10 17:40 Dmitry Kozlyuk
2022-08-10 19:26 ` Stephen Hemminger
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Kozlyuk @ 2022-08-10 17:40 UTC (permalink / raw)
To: dev; +Cc: Dmitry Kozlyuk, stable, Bruce Richardson
Developer mode was detected if `.git` was a directory.
Linked git working trees created by `git worktree add`
contain `.git` file instead of `.git` directory.
Developer mode was not detected for such directories.
Detect developer mode by the presence of `.git` path.
Fixes: bc4617433845 ("build: enable a developer mode setting")
Cc: stable@dpdk.org
Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index a32f14024b..7d6643da3a 100644
--- a/meson.build
+++ b/meson.build
@@ -20,7 +20,7 @@ developer_mode = false
if get_option('developer_mode').auto()
if meson.version().version_compare('>=0.53') # fs module available
fs = import('fs')
- developer_mode = fs.is_dir('.git')
+ developer_mode = fs.exists('.git')
endif
else
developer_mode = get_option('developer_mode').enabled()
--
2.33.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] build: enable developer mode for all working trees
2022-08-10 17:40 [PATCH] build: enable developer mode for all working trees Dmitry Kozlyuk
@ 2022-08-10 19:26 ` Stephen Hemminger
2022-08-16 8:51 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2022-08-10 19:26 UTC (permalink / raw)
To: Dmitry Kozlyuk; +Cc: dev, stable, Bruce Richardson
On Wed, 10 Aug 2022 20:40:58 +0300
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> Developer mode was detected if `.git` was a directory.
> Linked git working trees created by `git worktree add`
> contain `.git` file instead of `.git` directory.
> Developer mode was not detected for such directories.
> Detect developer mode by the presence of `.git` path.
>
> Fixes: bc4617433845 ("build: enable a developer mode setting")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] build: enable developer mode for all working trees
2022-08-10 19:26 ` Stephen Hemminger
@ 2022-08-16 8:51 ` Ferruh Yigit
2022-08-29 10:47 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2022-08-16 8:51 UTC (permalink / raw)
To: Stephen Hemminger, Dmitry Kozlyuk; +Cc: dev, stable, Bruce Richardson
On 8/10/2022 8:26 PM, Stephen Hemminger wrote:
> On Wed, 10 Aug 2022 20:40:58 +0300
> Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
>> Developer mode was detected if `.git` was a directory.
>> Linked git working trees created by `git worktree add`
>> contain `.git` file instead of `.git` directory.
>> Developer mode was not detected for such directories.
>> Detect developer mode by the presence of `.git` path.
>>
>> Fixes: bc4617433845 ("build: enable a developer mode setting")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] build: enable developer mode for all working trees
2022-08-16 8:51 ` Ferruh Yigit
@ 2022-08-29 10:47 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2022-08-29 10:47 UTC (permalink / raw)
To: Dmitry Kozlyuk
Cc: Stephen Hemminger, dev, stable, Bruce Richardson, Ferruh Yigit
16/08/2022 10:51, Ferruh Yigit:
> On 8/10/2022 8:26 PM, Stephen Hemminger wrote:
> > On Wed, 10 Aug 2022 20:40:58 +0300
> > Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> >
> >> Developer mode was detected if `.git` was a directory.
> >> Linked git working trees created by `git worktree add`
> >> contain `.git` file instead of `.git` directory.
> >> Developer mode was not detected for such directories.
> >> Detect developer mode by the presence of `.git` path.
> >>
> >> Fixes: bc4617433845 ("build: enable a developer mode setting")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
Good catch!
I am a user of the "git worktree" feature, it is very convenient
to do some parallel work and not mess recompilation.
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-29 10:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-10 17:40 [PATCH] build: enable developer mode for all working trees Dmitry Kozlyuk
2022-08-10 19:26 ` Stephen Hemminger
2022-08-16 8:51 ` Ferruh Yigit
2022-08-29 10:47 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).