From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 53B0AA0471 for ; Fri, 21 Jun 2019 09:30:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1EB21D53D; Fri, 21 Jun 2019 09:30:16 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 22BE51D539 for ; Fri, 21 Jun 2019 09:30:15 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 874E030BB54B; Fri, 21 Jun 2019 07:30:14 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9DBED19722; Fri, 21 Jun 2019 07:30:13 +0000 (UTC) To: Tiwei Bie Cc: dev@dpdk.org, zhihong.wang@intel.com References: <20190620200712.9187-1-maxime.coquelin@redhat.com> <20190621045148.GA29479@___> From: Maxime Coquelin Message-ID: <0dab583a-ecb6-4f85-8b4f-d53c94debb0f@redhat.com> Date: Fri, 21 Jun 2019 09:30:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190621045148.GA29479@___> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 21 Jun 2019 07:30:14 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: log Virtio and Vhost-user negotiated features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/21/19 6:51 AM, Tiwei Bie wrote: > On Thu, Jun 20, 2019 at 10:07:12PM +0200, Maxime Coquelin wrote: >> Having this info logged by default when analysing bug reports >> has proved to be useful. >> >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/vhost_user.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c >> index c9e29ece8..370864865 100644 >> --- a/lib/librte_vhost/vhost_user.c >> +++ b/lib/librte_vhost/vhost_user.c >> @@ -284,6 +284,8 @@ vhost_user_set_features(struct virtio_net **pdev, struct VhostUserMsg *msg, >> } else { >> dev->vhost_hlen = sizeof(struct virtio_net_hdr); >> } >> + RTE_LOG(INFO, VHOST_CONFIG, >> + "Negotiated Virtio features: 0x%" PRIx64 "\n", dev->features); > > Might be better to use lowercase for "Negotiated", and we will > get more consistent messages like this: > > VHOST_CONFIG: new vhost user connection is 278 > VHOST_CONFIG: new device, handle is 0 > VHOST_CONFIG: read message VHOST_USER_SET_OWNER > VHOST_CONFIG: read message VHOST_USER_GET_FEATURES > VHOST_CONFIG: read message VHOST_USER_SET_VRING_CALL > VHOST_CONFIG: vring call idx:0 file:279 > VHOST_CONFIG: read message VHOST_USER_SET_VRING_CALL > VHOST_CONFIG: vring call idx:1 file:280 > VHOST_CONFIG: read message VHOST_USER_SET_FEATURES > VHOST_CONFIG: negotiated Virtio features: 0xd10008000 > VHOST_CONFIG: read message VHOST_USER_SET_MEM_TABLE > VHOST_CONFIG: guest memory region 0, size: 0x20000000 > ...... > > instead of: > > VHOST_CONFIG: new vhost user connection is 278 > VHOST_CONFIG: new device, handle is 0 > VHOST_CONFIG: read message VHOST_USER_SET_OWNER > VHOST_CONFIG: read message VHOST_USER_GET_FEATURES > VHOST_CONFIG: read message VHOST_USER_SET_VRING_CALL > VHOST_CONFIG: vring call idx:0 file:279 > VHOST_CONFIG: read message VHOST_USER_SET_VRING_CALL > VHOST_CONFIG: vring call idx:1 file:280 > VHOST_CONFIG: read message VHOST_USER_SET_FEATURES > VHOST_CONFIG: Negotiated Virtio features: 0xd10008000 > VHOST_CONFIG: read message VHOST_USER_SET_MEM_TABLE > VHOST_CONFIG: guest memory region 0, size: 0x20000000 > ...... > Right, I'll fix it while applying. >> VHOST_LOG_DEBUG(VHOST_CONFIG, >> "(%d) mergeable RX buffers %s, virtio 1 %s\n", >> dev->vid, >> @@ -1406,6 +1408,9 @@ vhost_user_set_protocol_features(struct virtio_net **pdev, >> } >> >> dev->protocol_features = protocol_features; >> + RTE_LOG(INFO, VHOST_CONFIG, >> + "Negotiated Vhost-user protocol features: 0x%" PRIx64 "\n", >> + dev->protocol_features); > > Ditto. > > Other than that, > Reviewed-by: Tiwei Bie Thanks, Maxime > Thanks, > Tiwei > >> >> return RTE_VHOST_MSG_RESULT_OK; >> } >> -- >> 2.21.0 >>