DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Xiaoyu Min <jackmin@mellanox.com>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"Ferruh Yigit" <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API
Date: Tue, 14 May 2019 10:34:22 +0300	[thread overview]
Message-ID: <0dabe886-8cca-1d8a-b204-824393c8f240@solarflare.com> (raw)
In-Reply-To: <20190514071829.5251-1-jackmin@mellanox.com>

On 5/14/19 10:18 AM, Xiaoyu Min wrote:
> Add GRE's checksum, key, and sequence field to the
> struct rte_flow_item_gre in order to match.
>
> Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
> ---
>   lib/librte_ethdev/rte_flow.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index 63f84fca65..fb04af3268 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -847,6 +847,10 @@ struct rte_flow_item_gre {
>   	 */
>   	rte_be16_t c_rsvd0_ver;
>   	rte_be16_t protocol; /**< Protocol type. */
> +	rte_be16_t checksum; /**< chksum for the header and payload, optional.*/
> +	rte_be16_t rsvd1; /**< present when C bit is set, optional. */
> +	rte_be32_t key; /**< application specific key value, optional. */
> +	rte_be32_t sequence; /**< sequence num for the GRE packet, optional. */
>   };
>   
>   /** Default mask for RTE_FLOW_ITEM_TYPE_GRE. */

What is the purpose to match checksum, reserved and sequence number?

  parent reply	other threads:[~2019-05-14  7:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14  7:18 Xiaoyu Min
2019-05-14  7:18 ` Xiaoyu Min
2019-05-14  7:34 ` Andrew Rybchenko [this message]
2019-05-14  7:34   ` Andrew Rybchenko
2019-05-14  9:00   ` Adrien Mazarguil
2019-05-14  9:00     ` Adrien Mazarguil
2019-05-15  8:55     ` Jack Min
2019-05-15  8:55       ` Jack Min
2019-05-14 15:25 ` Stephen Hemminger
2019-05-14 15:25   ` Stephen Hemminger
2019-05-15  8:56   ` Jack Min
2019-05-15  8:56     ` Jack Min
2019-05-15 13:24 ` [dpdk-dev] [RFC v2] ethdev: add GRE key field " Xiaoyu Min
2019-05-15 13:24   ` Xiaoyu Min

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dabe886-8cca-1d8a-b204-824393c8f240@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jackmin@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).