From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id C84714CA7 for ; Tue, 14 May 2019 09:34:35 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id BE7644C0071; Tue, 14 May 2019 07:34:33 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 14 May 2019 08:34:26 +0100 To: Xiaoyu Min , Adrien Mazarguil , Thomas Monjalon , "Ferruh Yigit" CC: References: <20190514071829.5251-1-jackmin@mellanox.com> From: Andrew Rybchenko Message-ID: <0dabe886-8cca-1d8a-b204-824393c8f240@solarflare.com> Date: Tue, 14 May 2019 10:34:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190514071829.5251-1-jackmin@mellanox.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24612.003 X-TM-AS-Result: No-10.458500-8.000000-10 X-TMASE-MatchedRID: hls5oAVArl/mLzc6AOD8DfHkpkyUphL9NV9S7O+u3KYlfe31Kb3l/xFA +ewA1AiFrdoLblq9S5orfOKkKZ+OWo1pcgBT/7NsYJF0zuzVwRQGchEhVwJY36cxvibtoCq3XWj vA8TpWFjNsfGypshROnb29HKyf4Wf4ouBraSr19/J/bVh4iw9hnzIY7d2+Tz9Vxt8iPZNr2w/zi v0u4cpYY0ogGHrw9oBa5GL+Yxi3LHoFAS0KSTy0i+PrAd8gbHJI/HS+JSZ167hbCsoFPacnXlED b1OO87oNTcc+FGtHL3/voIzhn8wZuVHGbcDbAq6OX/V8P8ail1ZDL1gLmoa/PoA9r2LThYYvJqH 1oJhQIc6ls+EGDXRyUZxrbuFsll0hqp6g3ev9N9HSyPOsaV74PQ4SQk0ed0R+6ahNDwdoQ6WB7F AftAthbR7aTBYH/bD5lSqFBJAACs= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--10.458500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24612.003 X-MDID: 1557819274-0GjwNXIxewek Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 May 2019 07:34:36 -0000 On 5/14/19 10:18 AM, Xiaoyu Min wrote: > Add GRE's checksum, key, and sequence field to the > struct rte_flow_item_gre in order to match. > > Signed-off-by: Xiaoyu Min > --- > lib/librte_ethdev/rte_flow.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index 63f84fca65..fb04af3268 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -847,6 +847,10 @@ struct rte_flow_item_gre { > */ > rte_be16_t c_rsvd0_ver; > rte_be16_t protocol; /**< Protocol type. */ > + rte_be16_t checksum; /**< chksum for the header and payload, optional.*/ > + rte_be16_t rsvd1; /**< present when C bit is set, optional. */ > + rte_be32_t key; /**< application specific key value, optional. */ > + rte_be32_t sequence; /**< sequence num for the GRE packet, optional. */ > }; > > /** Default mask for RTE_FLOW_ITEM_TYPE_GRE. */ What is the purpose to match checksum, reserved and sequence number? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7BAF7A00E6 for ; Tue, 14 May 2019 09:34:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A1624CC3; Tue, 14 May 2019 09:34:37 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id C84714CA7 for ; Tue, 14 May 2019 09:34:35 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id BE7644C0071; Tue, 14 May 2019 07:34:33 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 14 May 2019 08:34:26 +0100 To: Xiaoyu Min , Adrien Mazarguil , Thomas Monjalon , "Ferruh Yigit" CC: References: <20190514071829.5251-1-jackmin@mellanox.com> From: Andrew Rybchenko Message-ID: <0dabe886-8cca-1d8a-b204-824393c8f240@solarflare.com> Date: Tue, 14 May 2019 10:34:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190514071829.5251-1-jackmin@mellanox.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24612.003 X-TM-AS-Result: No-10.458500-8.000000-10 X-TMASE-MatchedRID: hls5oAVArl/mLzc6AOD8DfHkpkyUphL9NV9S7O+u3KYlfe31Kb3l/xFA +ewA1AiFrdoLblq9S5orfOKkKZ+OWo1pcgBT/7NsYJF0zuzVwRQGchEhVwJY36cxvibtoCq3XWj vA8TpWFjNsfGypshROnb29HKyf4Wf4ouBraSr19/J/bVh4iw9hnzIY7d2+Tz9Vxt8iPZNr2w/zi v0u4cpYY0ogGHrw9oBa5GL+Yxi3LHoFAS0KSTy0i+PrAd8gbHJI/HS+JSZ167hbCsoFPacnXlED b1OO87oNTcc+FGtHL3/voIzhn8wZuVHGbcDbAq6OX/V8P8ail1ZDL1gLmoa/PoA9r2LThYYvJqH 1oJhQIc6ls+EGDXRyUZxrbuFsll0hqp6g3ev9N9HSyPOsaV74PQ4SQk0ed0R+6ahNDwdoQ6WB7F AftAthbR7aTBYH/bD5lSqFBJAACs= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--10.458500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24612.003 X-MDID: 1557819274-0GjwNXIxewek Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC] ethdev: add GRE optional fields to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190514073422.Kw7CN784RImvaM9m3DqG4TbfiuzL7tUG1OFFXei7XUA@z> On 5/14/19 10:18 AM, Xiaoyu Min wrote: > Add GRE's checksum, key, and sequence field to the > struct rte_flow_item_gre in order to match. > > Signed-off-by: Xiaoyu Min > --- > lib/librte_ethdev/rte_flow.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index 63f84fca65..fb04af3268 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -847,6 +847,10 @@ struct rte_flow_item_gre { > */ > rte_be16_t c_rsvd0_ver; > rte_be16_t protocol; /**< Protocol type. */ > + rte_be16_t checksum; /**< chksum for the header and payload, optional.*/ > + rte_be16_t rsvd1; /**< present when C bit is set, optional. */ > + rte_be32_t key; /**< application specific key value, optional. */ > + rte_be32_t sequence; /**< sequence num for the GRE packet, optional. */ > }; > > /** Default mask for RTE_FLOW_ITEM_TYPE_GRE. */ What is the purpose to match checksum, reserved and sequence number?