From: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
To: Harry van Haaren <harry.van.haaren@intel.com>, dev@dpdk.org
Subject: Re: [PATCH 1/2] docs/bpf: fix formatting and link
Date: Sat, 28 May 2022 12:09:05 +0100 [thread overview]
Message-ID: <0dae6881-5668-24c7-7a57-a71207d33e3c@yandex.ru> (raw)
In-Reply-To: <20220527134501.2209817-1-harry.van.haaren@intel.com>
27/05/2022 14:45, Harry van Haaren пишет:
> Small improvements to the documentation based on Sphinx HTML doc output.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> ---
>
> Cc: konstantin.v.ananyev@yandex.ru
>
> ---
> doc/guides/prog_guide/bpf_lib.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/doc/guides/prog_guide/bpf_lib.rst b/doc/guides/prog_guide/bpf_lib.rst
> index 1feb7734a3..1cf2d59429 100644
> --- a/doc/guides/prog_guide/bpf_lib.rst
> +++ b/doc/guides/prog_guide/bpf_lib.rst
> @@ -10,7 +10,7 @@ user-space dpdk application.
>
> It supports basic set of features from eBPF spec.
> Please refer to the
> -`eBPF spec <https://www.kernel.org/doc/Documentation/networking/filter.txt>`
> +`eBPF spec <https://www.kernel.org/doc/Documentation/networking/filter.txt>`_
> for more information.
> Also it introduces basic framework to load/unload BPF-based filters
> on eth devices (right now only via SW RX/TX callbacks).
> @@ -48,9 +48,9 @@ For example, ``(BPF_IND | BPF_W | BPF_LD)`` means:
> .. code-block:: c
>
> uint32_t tmp;
> - R0 = rte_pktmbuf_read((const struct rte_mbuf *)R6, src_reg + imm32,
> - sizeof(tmp), &tmp);
> - if (R0 == NULL) return FAILED;
> + R0 = rte_pktmbuf_read((const struct rte_mbuf *)R6, src_reg + imm32, sizeof(tmp), &tmp);
> + if (R0 == NULL)
> + return FAILED;
> R0 = ntohl(*(uint32_t *)R0);
>
> and ``R1-R5`` were scratched.
Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
next prev parent reply other threads:[~2022-05-28 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 13:45 Harry van Haaren
2022-05-27 13:45 ` [PATCH 2/2] docs: improve ordering and remove old header titles Harry van Haaren
2022-05-28 11:09 ` Konstantin Ananyev [this message]
2022-06-08 8:13 ` [PATCH 1/2] docs/bpf: fix formatting and link Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dae6881-5668-24c7-7a57-a71207d33e3c@yandex.ru \
--to=konstantin.v.ananyev@yandex.ru \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).