From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 67C271BEA3 for ; Wed, 27 Jun 2018 15:58:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 06:58:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="61857515" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.83]) ([10.237.221.83]) by fmsmga002.fm.intel.com with ESMTP; 27 Jun 2018 06:58:38 -0700 To: ido goshen , Bruce Richardson , John McNamara , Marko Kovacevic Cc: dev@dpdk.org References: <1530101043-97249-1-git-send-email-ido@cgstowernetworks.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: <0de1f427-26f5-1fbc-23a0-ae56dcca8e6f@intel.com> Date: Wed, 27 Jun 2018 14:58:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1530101043-97249-1-git-send-email-ido@cgstowernetworks.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3] net/pcap: rx_iface_in stream type support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 13:58:42 -0000 On 6/27/2018 1:04 PM, ido goshen wrote: > From: ido g > > Support rx of in direction packets only > Useful for apps that also tx to eth_pcap ports in order to not see them > echoed back in as rx when out direction is also captured Can you please add your command, which was in previous mails, on how to re-produce the issue of capturing transferred packets in Rx path; for future. And overall looks good, there are a few syntax comments below. > > Signed-off-by: ido g > --- > v3: > * merge to updated dpdk-next-net code > * pcap_ring doc update > > v2: > * clean checkpatch warning > > doc/guides/nics/pcap_ring.rst | 25 ++++++++++++++++++++++- > drivers/net/pcap/rte_eth_pcap.c | 45 ++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 66 insertions(+), 4 deletions(-) > > diff --git a/doc/guides/nics/pcap_ring.rst b/doc/guides/nics/pcap_ring.rst > index 7fd063c..6282be6 100644 > --- a/doc/guides/nics/pcap_ring.rst > +++ b/doc/guides/nics/pcap_ring.rst > @@ -71,11 +71,19 @@ The different stream types are: > tx_pcap=/path/to/file.pcap > > * rx_iface: Defines a reception stream based on a network interface name. > - The driver reads packets coming from the given interface using the Linux kernel driver for that interface. > + The driver reads packets from the given interface using the Linux kernel driver for that interface. > + The driver captures both the incoming and outgoing packets on that interface. This is only true if tx_iface parameter given for that interface, right? I can be good to clarify to not confuse people. I am for keeping first sentences, and add a note about this special case, something like (feel free to update): " The driver reads packets coming from the given interface using the Linux kernel driver for that interface. When tx_iface argument given for same interface, Tx packets also captured. " > The value is an interface name. > > rx_iface=eth0 > > +* rx_iface_in: Defines a reception stream based on a network interface name. > + The driver reads packets from the given interface using the Linux kernel driver for that interface. > + The driver captures only the incoming packets on that interface. Again I am for keeping "... reads packets coming from the given interface ..." and clarify the difference in next sentences specific to tx_iface usage. > + The value is an interface name. > + > + rx_iface_in=eth0 > + > * tx_iface: Defines a transmission stream based on a network interface name. > The driver sends packets to the given interface using the Linux kernel driver for that interface. > The value is an interface name. > @@ -122,6 +130,21 @@ Forward packets through two network interfaces: > $RTE_TARGET/app/testpmd -l 0-3 -n 4 \ > --vdev 'net_pcap0,iface=eth0' --vdev='net_pcap1;iface=eth1' > > +Enable 2 tx queues on a network interface:> + > +.. code-block:: console > + > + $RTE_TARGET/app/testpmd -l 0-3 -n 4 \ > + --vdev 'net_pcap0,rx_iface=eth1,tx_iface=eth1,tx_iface=eth1' \ > + -- --txq 2 > + > +Read only incoming packets from a network interface: This title is confusing, the sample is not for "read only incoming packets" it Tx also J. I understand what you mean, but I believe it would be better to clarify this. > + > +.. code-block:: console > + > + $RTE_TARGET/app/testpmd -l 0-3 -n 4 \ > + --vdev 'net_pcap0,rx_iface_in=eth1,tx_iface=eth1' > + > Using libpcap-based PMD with the testpmd Application > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c > index b21930b..9c31cef 100644 > --- a/drivers/net/pcap/rte_eth_pcap.c > +++ b/drivers/net/pcap/rte_eth_pcap.c > @@ -26,6 +26,7 @@ > #define ETH_PCAP_RX_PCAP_ARG "rx_pcap" > #define ETH_PCAP_TX_PCAP_ARG "tx_pcap" > #define ETH_PCAP_RX_IFACE_ARG "rx_iface" > +#define ETH_PCAP_RX_IFACE_IN_ARG "rx_iface_in" > #define ETH_PCAP_TX_IFACE_ARG "tx_iface" > #define ETH_PCAP_IFACE_ARG "iface" > > @@ -83,6 +84,7 @@ struct pmd_devargs { > ETH_PCAP_RX_PCAP_ARG, > ETH_PCAP_TX_PCAP_ARG, > ETH_PCAP_RX_IFACE_ARG, > + ETH_PCAP_RX_IFACE_IN_ARG, > ETH_PCAP_TX_IFACE_ARG, > ETH_PCAP_IFACE_ARG, > NULL > @@ -739,6 +741,26 @@ struct pmd_devargs { > } > > static inline int > +set_iface_direction(const char *iface, > + pcap_t *pcap, > + pcap_direction_t direction) Can you please follow same syntax in the code, like: set_iface_direction(const char *iface, pcap_t *pcap, pcap_direction_t direction) > +{ > + const char *direction_str = (direction == PCAP_D_IN) ? "IN" : "OUT"; > + if (pcap_setdirection(pcap, direction) < 0) { > + PMD_LOG(ERR, > + "Setting %s pcap direction %s failed - %s\n", > + iface, > + direction_str, > + pcap_geterr(pcap)); Can you please fix the indentations above, lines can be joined: PMD_LOG(ERR, "Setting %s pcap direction %s failed - %s\n", iface, direction_str, pcap_geterr(pcap)); > + return -1; > + } > + PMD_LOG(INFO, "Setting %s pcap direction %s\n", > + iface, > + direction_str); Same here, one tab is enough for next line and can join lines > + return 0; > +} > + > +static inline int > open_iface(const char *key, const char *value, void *extra_args) > { > const char *iface = value; > @@ -761,7 +783,17 @@ struct pmd_devargs { > static inline int > open_rx_iface(const char *key, const char *value, void *extra_args) > { > - return open_iface(key, value, extra_args); > + int ret = open_iface(key, value, extra_args); > + if (ret < 0) > + return ret; > + if (strcmp(key, ETH_PCAP_RX_IFACE_IN_ARG) == 0) { > + struct pmd_devargs *pmd = extra_args; > + unsigned int qid = pmd->num_of_queue - 1; > + set_iface_direction(pmd->queue[qid].name, > + pmd->queue[qid].pcap, > + PCAP_D_IN); > + } Can you please put an empty line after variables and before return. > + return 0; > } > > /* > @@ -964,12 +996,18 @@ struct pmd_devargs { > is_rx_pcap = rte_kvargs_count(kvlist, ETH_PCAP_RX_PCAP_ARG) ? 1 : 0; > pcaps.num_of_queue = 0; > > - if (is_rx_pcap) > + if (is_rx_pcap) { > ret = rte_kvargs_process(kvlist, ETH_PCAP_RX_PCAP_ARG, > &open_rx_pcap, &pcaps); > - else > + } else { > ret = rte_kvargs_process(kvlist, ETH_PCAP_RX_IFACE_ARG, > &open_rx_iface, &pcaps); > + if (ret == 0) > + ret = rte_kvargs_process(kvlist, > + ETH_PCAP_RX_IFACE_IN_ARG, > + &open_rx_iface, > + &pcaps); Here if RX_IFACE_ARG and RX_IFACE_IN_ARG used mixed (nothing seems prevents this), the queue order can be not same as argument order, do you think is this a problem? > + } > > if (ret < 0) > goto free_kvlist; > @@ -1035,6 +1073,7 @@ struct pmd_devargs { > ETH_PCAP_RX_PCAP_ARG "= " > ETH_PCAP_TX_PCAP_ARG "= " > ETH_PCAP_RX_IFACE_ARG "= " > + ETH_PCAP_RX_IFACE_IN_ARG "= " > ETH_PCAP_TX_IFACE_ARG "= " > ETH_PCAP_IFACE_ARG "="); > >