From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 17BED20F; Tue, 10 Jan 2017 10:35:38 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 10 Jan 2017 01:35:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,343,1477983600"; d="scan'208";a="211614484" Received: from dwdohert-dpdk.ir.intel.com ([163.33.210.152]) by fmsmga004.fm.intel.com with ESMTP; 10 Jan 2017 01:35:36 -0800 To: Piotr Azarewicz , pablo.de.lara.guarch@intel.com, dev@dpdk.org References: <1483973136-154458-1-git-send-email-piotrx.t.azarewicz@intel.com> Cc: stable@dpdk.org From: Declan Doherty Message-ID: <0df6fc09-6d6e-f9fd-40e4-caae605469ff@intel.com> Date: Tue, 10 Jan 2017 09:28:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1483973136-154458-1-git-send-email-piotrx.t.azarewicz@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 09:35:39 -0000 On 09/01/17 14:45, Piotr Azarewicz wrote: > EVP_CIPHER_CTX_set_padding() function always returns 1, so the check is > unneeded. > > Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") > > Signed-off-by: Piotr Azarewicz > --- > drivers/crypto/openssl/rte_openssl_pmd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c > index 832ea1d..312154a 100644 > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > @@ -522,8 +522,7 @@ > if (EVP_DecryptInit_ex(ctx, algo, NULL, key, iv) <= 0) > goto process_cipher_decrypt_err; > > - if (EVP_CIPHER_CTX_set_padding(ctx, 0) <= 0) > - goto process_cipher_decrypt_err; > + EVP_CIPHER_CTX_set_padding(ctx, 0); > > if (EVP_DecryptUpdate(ctx, dst, &dstlen, src, srclen) <= 0) > goto process_cipher_decrypt_err; > Acked-by: Declan Doherty