* [dpdk-dev] [PATCH] crypto/caam_jr: fix incorrect check
@ 2018-10-29 12:15 Gagandeep Singh
2018-11-02 11:28 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Gagandeep Singh @ 2018-10-29 12:15 UTC (permalink / raw)
To: dev; +Cc: Gagandeep Singh
Check should be on parameter uio_fd instead of
local variable job_ring
Fixes: e7a45f3cc2 ("crypto/caam_jr: add UIO specific operations")
Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
---
changes:
* fixed incorrect check in free_job_ring (comment by Ferruh)
drivers/crypto/caam_jr/caam_jr_uio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/caam_jr/caam_jr_uio.c b/drivers/crypto/caam_jr/caam_jr_uio.c
index c07d9db01..d94101c2f 100644
--- a/drivers/crypto/caam_jr/caam_jr_uio.c
+++ b/drivers/crypto/caam_jr/caam_jr_uio.c
@@ -332,7 +332,7 @@ free_job_ring(uint32_t uio_fd)
struct uio_job_ring *job_ring = NULL;
int i;
- if (!job_ring->uio_fd)
+ if (!uio_fd)
return;
for (i = 0; i < MAX_SEC_JOB_RINGS; i++) {
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] crypto/caam_jr: fix incorrect check
2018-10-29 12:15 [dpdk-dev] [PATCH] crypto/caam_jr: fix incorrect check Gagandeep Singh
@ 2018-11-02 11:28 ` Akhil Goyal
2018-11-02 11:33 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Akhil Goyal @ 2018-11-02 11:28 UTC (permalink / raw)
To: Gagandeep Singh, dev
On 10/29/2018 5:45 PM, Gagandeep Singh wrote:
> Check should be on parameter uio_fd instead of
> local variable job_ring
>
> Fixes: e7a45f3cc2 ("crypto/caam_jr: add UIO specific operations")
>
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> ---
> changes:
> * fixed incorrect check in free_job_ring (comment by Ferruh)
You should add Reported-by
Will add it while merging.
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] crypto/caam_jr: fix incorrect check
2018-11-02 11:28 ` Akhil Goyal
@ 2018-11-02 11:33 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2018-11-02 11:33 UTC (permalink / raw)
To: Gagandeep Singh, dev
On 11/2/2018 4:58 PM, Akhil Goyal wrote:
>
> On 10/29/2018 5:45 PM, Gagandeep Singh wrote:
>> Check should be on parameter uio_fd instead of
>> local variable job_ring
>>
>> Fixes: e7a45f3cc2 ("crypto/caam_jr: add UIO specific operations")
>>
>> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
>> ---
>> changes:
>> * fixed incorrect check in free_job_ring (comment by Ferruh)
> You should add Reported-by
> Will add it while merging.
>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-02 11:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-29 12:15 [dpdk-dev] [PATCH] crypto/caam_jr: fix incorrect check Gagandeep Singh
2018-11-02 11:28 ` Akhil Goyal
2018-11-02 11:33 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).