From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A438A04FD; Wed, 22 Jun 2022 10:12:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DBE34069C; Wed, 22 Jun 2022 10:12:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7100440689 for ; Wed, 22 Jun 2022 10:11:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655885518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cVGOyfDlBNXR0JvMIykXZ4H15zzRnkWMx+Ly30gGPic=; b=ix6Hk9OWpjkKrdFETFkzk5LFyDIN0rn0qBmH9OTmdUkqTaCAJV+lXbfsrFnjgo4uVDUD+/ RfObAHgSLG7D5Tg3nisTMHQ4RHq/HXJ/T9Fg1Iadnqn3rPrO+sqlJ08gR3iy+S6W6uSJon FmHFcl0zQQ4C1S+J3sZUa8Pav4dKCC4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-596-ET-t23MXNcuJm68Wqjbh8w-1; Wed, 22 Jun 2022 04:11:55 -0400 X-MC-Unique: ET-t23MXNcuJm68Wqjbh8w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 323AB1C006A7; Wed, 22 Jun 2022 08:11:55 +0000 (UTC) Received: from [10.39.208.40] (unknown [10.39.208.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 55C952166B26; Wed, 22 Jun 2022 08:11:54 +0000 (UTC) Message-ID: <0dfe8a28-869b-1454-8fec-7634e7a87f8d@redhat.com> Date: Wed, 22 Jun 2022 10:11:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed To: Matan Azrad , "dev@dpdk.org" Cc: "835703180@qq.com" <835703180@qq.com>, "NBU-Contact-Thomas Monjalon (EXTERNAL)" References: <640b6f87-fa5f-4a94-3228-a2c880861a53@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Matan, On 6/22/22 10:03, Matan Azrad wrote: > Hi > > I put here again the comment the putted on another version of this commit. > > I saw it is already integrated but still not in master. > > But please look. Thanks for the heads-up, I missed your initial comment. > From: Maxime Coquelin >> Hi newsky647, >> >> On 6/12/22 16:09, 835703180@qq.com wrote: >>> From: newsky647 <835703180@qq.com> >>> >>> After function rte_intr_instance_alloc failed, we should return ENOMEM >>> for error code. >>> >>> Fixes: 5fe068bf7a2 ("vdpa/mlx5: reuse resources in reconfiguration") >>> >>> Signed-off-by: newsky647 <835703180@qq.com> >>> --- >>> drivers/vdpa/mlx5/mlx5_vdpa_event.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c >>> b/drivers/vdpa/mlx5/mlx5_vdpa_event.c >>> index 7167a98db0..6223afaae8 100644 >>> --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c >>> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c >>> @@ -395,6 +395,7 @@ mlx5_vdpa_err_event_setup(struct mlx5_vdpa_priv >> *priv) >>> rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED); >>> if (priv->err_intr_handle == NULL) { >>> DRV_LOG(ERR, "Fail to allocate intr_handle"); >>> + rte_errno = ENOMEM; > > Shouldn't rte_intr_instance_alloc set it? I think it makes sense, Thomas could you drop the patch while pulling my branch? Or do you prefer I remove it directly from my tree? Shiqi, can you send a new version of the patch taking Matan comment into account? Thanks, Maxime >>> goto error; >>> } >>> if (rte_intr_fd_set(priv->err_intr_handle, priv->err_chnl->fd)) >> >> The patch looks good to me, but I would need your real name for the sign-off. >> >> Reviewed-by: Maxime Coquelin >> >> Thanks, >> Maxime >