From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CB7842503; Tue, 5 Sep 2023 17:34:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E59C40E72; Tue, 5 Sep 2023 17:34:44 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2089.outbound.protection.outlook.com [40.107.244.89]) by mails.dpdk.org (Postfix) with ESMTP id E339140E72 for ; Tue, 5 Sep 2023 17:34:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDax19mClSg9uXTHWZLaTXKCKOvkCgFei5+XZRBifOrYQuAsBXWgUt+B/1ttSmIPSOdJhCM5JFOBu/FcIHmSA0WklaKbBAtG97d0Lotxd7xtA9jNPdX8UZD22x8Hm3mjDvYsbI3RW4ZWFxFXTYa0X+/RYFdwi2idbmfq01dnCh8fVVwh6/roi6VRZH1IvHHkFmV/raFu+oBlYThTUWxrS/WrEr+0t7LTvTrJyQ8XZxdPe/SovkYPQjeGZaB4AI5H87aa0HTXYnELSy3Wn3p4JlWfycN7UNKLkyPANzV8gFfaGKJrkU0vJGg429yiik7EhdbSFWGypcvIJC6eevpncw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jSJw6Uql+o1Qc3OTwP+xGuy9q8B5Fgr1yWAmCPw6NoI=; b=af1g0iJRs3Q242axrPUU/JBNoVkrpy5SeBmJWVGG/f1J+6Uh7G4JbeTPNvifOsG8BjxFrWkH9RuEn7JmQ6tdAh+G0eFE3zLIOc4xr6ip4JKwBDvQ6OkxBLfPM/9Aa533a9vtTZL+s1jmBthsI4tjiQzlS7hfehnR3nLil45hQswFw8+9Vn5TVjFsTmTg/tVFGmAyD9mIv+ADo6VseU1b6BQBv8S3qDfQdPtJAmX4UPqRBURaLDRP/OQxbhyMB12G7Q58ulmKhYDellpIALN2Y3nT7VVZFDOSyD8qeEgJYCGX25KEfIO0bX/p729WVZGkb3ieAjcbsN3LOXq8mPytxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jSJw6Uql+o1Qc3OTwP+xGuy9q8B5Fgr1yWAmCPw6NoI=; b=VZqOuSLiT1zhjnwbfyj98qf3hsDInzHPuaG2aabVFe8BKZLVlzs8RjnOrmAzOKRfRm3T2YnRusAip3k0qq1V+YgRwlQSB1e7pOXy2EwBjHg44XibfBO4KQd3/13gCShVOyiaC4SL/YJACdyWW+IBh6R8Qm7eLQZnsDZI3jDiFpo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4953.namprd12.prod.outlook.com (2603:10b6:610:36::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.33; Tue, 5 Sep 2023 15:34:40 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::49e9:2bf6:7f06:bbbd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::49e9:2bf6:7f06:bbbd%3]) with mapi id 15.20.6745.030; Tue, 5 Sep 2023 15:34:40 +0000 Message-ID: <0e0509ea-1da7-76a1-fe5d-dabb6b3c735a@amd.com> Date: Tue, 5 Sep 2023 16:34:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: Wenbo Cao Cc: dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, yaojun@mucse.com References: <20230901023050.40893-1-caowenbo@mucse.com> From: Ferruh Yigit Subject: Re: [PATCH v6 0/8] [v6]drivers/net Add Support mucse N10 Pmd Driver In-Reply-To: <20230901023050.40893-1-caowenbo@mucse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P265CA0012.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4953:EE_ X-MS-Office365-Filtering-Correlation-Id: eb020a40-ca8c-4105-a009-08dbae259eac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zqKiNCbWD+KR3wAXi/WBzy5JcLIFAYvNTG+mdVGR0xMVzFHVVU2R9eN0G58J+0lzmyAyOnCHMovGIcOVyeKUn30CUSRD+CcnsTij53GywpDCVunEKemknWqErDBHIF8nUfEjSyq9JF6rLY4VzF2vVGe1nMqN+aNnxISpcYMRCDb7ybAURp942nmv0NXlmRMTsN0UsUKva3f6NzVnrxb1KVj514+umFfgDfba7i9T3HGT36Zxxm+TJbh1v0Iwb4bYmISXJ4NGt31EuRbzNBbYDTPW7MRRBOnuRhpgloP6GjbRKlLtBROEDzf6Hu9Ui2CeWXWparc8S3kcl2CE9TcVIEwJbLvYxgo4Kb2DtoWHLFHl9hi7xk/LrD5wciZLPm0woOiTgy2YOX0kjnJHddE4yZymp/7CrHuBegzx3uGSQlpjbUiNxpndB8cZ/KOXxBL2DVe/oRrDWEBpdot9Lc3cagQsvQPizxlAXQzBfMR0ph6E5anv6YL2jZZWvbo+R5HvWFP5km7SKyQQZ+Puq44jpqePc22r1vH5d60RBQVUjvZ7qnKITvWPEn8Esmjt+f3lhYIEzpV1C18e0eldo39D74+N0foZ5YEwbyhoxturhO0LGCkU+FOX4G/aCg52wOwRuF4M9cuOSPP9XEEVQpvxzma3VsckH38mk6cgtgjO2gQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(396003)(346002)(136003)(366004)(186009)(451199024)(1800799009)(6666004)(53546011)(66556008)(66946007)(66476007)(6916009)(44832011)(6486002)(6506007)(316002)(41300700001)(6512007)(966005)(478600001)(31686004)(4326008)(8676002)(2616005)(26005)(5660300002)(36756003)(38100700002)(2906002)(8936002)(86362001)(83380400001)(31696002)(403724002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aElUUWtCV3RFd25HSENnYkFCZ0FEVlg2QlRzTWpHbW1LczVwdlhSbkExYmQ5?= =?utf-8?B?OGpEUDVRQ3JhT1VJdGliTzNBTUdYQnVnRHJVb0tzamR0NWQ0L1YraEdGbWg5?= =?utf-8?B?UU90cmo1MTlES3JpZURuY29pY3dtQzRVSCtsLzRvZmwzbEJ4ZDBoQTZORWN3?= =?utf-8?B?YWwwRDhtNjMwcnpEZmVPVGlBbXh2aENoY1VZcGJKa2ZpcGxjNk53cVFHUVNC?= =?utf-8?B?MHVWSkxCOFl6eWJSUTBaUXdIU1I3Uklma0tXN29NaWt5YmxiTk45NWt3eDFL?= =?utf-8?B?RlcvN1ZHTkhCUkF0UWlBVmRtdVhPY2VacTNrV1lmblJaVndBK1d1bDVaUHVt?= =?utf-8?B?R29UbDZSQkxZc2QwbEFyYlh6UDVGU09KdVozNGlERFdJdlpGOURtSndIYUJY?= =?utf-8?B?M1R3d0g2SVF0RGthWDI4OVRWRXFRcFlhMFMwc1NZYWRGTEVFeDRBeHhoR2RP?= =?utf-8?B?NHpmamx2UEVNQzVaN3BNZTJhamQ3WktUZ1Ixd1lkNWZVNk9QU0VhZ05sVDBZ?= =?utf-8?B?WmpiSE1aRy9LOU4wYmVLUHV3VTFyS2NvRnYxN0Y0VU80bGQ5bmpQTCtUeFpy?= =?utf-8?B?TEhXcW45WnY1a2puQzBRdGJCM2JlQXM1SWxQM3JRVzUrVkRRZ3BsMmFvc2M3?= =?utf-8?B?Zmk5Y3VYNU5hV244WkpUKzVMOS9GL21KN2lQbWk1MU9EdzlxSmc2dmoxUVc0?= =?utf-8?B?eks3V25WSmxYT2lxdU9NbWFYZE4zNytDZnltZGFLb25ldWg0YndwRTlGRDgx?= =?utf-8?B?b0ZhSWNQbjlBSU5HNEgzZEhyMjdDNTVsSndSbjEwTmdGQkZnRXBwZUhOdFB5?= =?utf-8?B?SDN4WkVFd2N6am8vdVBkMVExT0lya0Z0bysvMXF3K2tOeWtVRDlvb1NmZDVM?= =?utf-8?B?UVhrUEtteWIvU3J5UUFkTnNOaVpVemJEWUc5WFlxSXFJd05rdWNPL2RNQ2pP?= =?utf-8?B?UVN2VlJ6THdXRGh0dmExYXpCaHZ1b0xGSWl1dER6b2E2dUV5c3dLcHRXengy?= =?utf-8?B?RUw2ZXFzQlk5NHNEQVNuMzEzN2JzQnk2R1lJZ0VmaHJiYldsQW9jc1dtdlN3?= =?utf-8?B?dlJFcFROU0E0OVF6NlloQkhuSEt2OUl6MHNGYVc3ajBqRzBSeGl3Y21XU2tP?= =?utf-8?B?VWxjcW83WkpiUFFFNXJrYUxpeEcvMVlKeXcwMGwrbkNXQnpzMVgrcmtrWm1K?= =?utf-8?B?NlJZR2lTTDNkNGVRR0tvMjl1RVIvRU16bnpxVm9ZRjdZVkE2dFZuVERQdnJL?= =?utf-8?B?d082MGJ5ekxLZzNYdEFKajZDdXE3M214Lzd4UURYZ085N2tvUmZ1TnMyamlN?= =?utf-8?B?eDdJcmx1ZnRFSG9DQmlWbnVhSzFPQVd0eWM5dFlVQWs3dXNPcHl5TTN3K2x0?= =?utf-8?B?SFN5dUMvOVNxSTJxMzJGT1FzMDBhSmdWV3drWFdMRFBtcnAySElIeEc1UVcz?= =?utf-8?B?eTNWZGF5bFdmbS9ENWo0Yk1BeFhSUWxIR3V0d1J2akJKN3F1ZmFGck1DMTNu?= =?utf-8?B?SkZFZjhZRXo1RlpaYURpVEdxa1psQzRiRTJFRjFjbkdFVFBveTc1eklQNjlX?= =?utf-8?B?bG9xNW4yekR4aXB6WkZmRnE5NGUvWjh3UUNlSUZyZVVuMm90ZEVXMGh4ZUJm?= =?utf-8?B?bks0THR0R1FnZFhDdVl0R2RESFh1a3FIcTZiMXhNUzM5MUlBNWdsY09EOE9G?= =?utf-8?B?RkVDZm5yTGYxQnFiRTNlTHVia1lWNmEyLytOSGdyV1JmZk9VZC9WRDlXdW5H?= =?utf-8?B?SENRY0I5QWxpUDRyNEZtK0lkVmtDM1ZKNnE3cjNHN2F1NUhqQnBkTzljZ1FO?= =?utf-8?B?amF2bDRoNDB0VEt4TGlTZUU2YmJwemRCd3hMZVVDbFVma0wvcHhtaUtibXdk?= =?utf-8?B?Vk5rME81cjIyZFFJdStiRkwxc2tvVEJiNlpSVWhHZURFNlNqNXZzYlRpUWsv?= =?utf-8?B?SjZlcTdrOXc3WCtwbG1OSjBIQmkxZDJKbXpZOFppTTBsRFNXd3A4Yy82SXBq?= =?utf-8?B?dTVrOS9kUFZYK3QvVE5zaHlCcldoUS9qUXJZamxIZXhVYnB4OVJmaFJreWpO?= =?utf-8?B?MzdUWDdKNUsxbEREZXJpWlFqTEZseFQ4N0pIYUFKVnlYOTJhWkk4ZU8zQXU0?= =?utf-8?Q?buIJXcOVG1JIjEt7UrA8t7AMQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb020a40-ca8c-4105-a009-08dbae259eac X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2023 15:34:40.4148 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3fd2aKA3i99J/UKBIJiRxq6AVv+Prr30AVd22UlnI0RDMHmvAeuTuYKsPv3iP5/B X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4953 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/1/2023 3:30 AM, Wenbo Cao wrote: > For This patchset just to support the basic chip init work > and user can just found the eth_dev, but can't control more. > Hi Wenbo, After this patch, driver doesn't implement any of the dev_ops (struct eth_dev_ops), so I assume it is not functional at all. But meanwhile patchset has devargs parsing, fw_update, LSC interrupts, implemented etc. I think it makes testing/reviewing harder to add more code before basic device functionality is missing. What about implementing following main dev_ops and implement a simple datapath, to have minimum working driver, later add features on top of it: dev_configure dev_start dev_stop dev_close dev_infos_get rx_queue_setup tx_queue_setup Also I have comment on putting 'mac_ops' on process_private, I suspect there is a design problem there, please check details in relevant patch. Thanks, Ferruh > For Now just support 2*10g nic,the chip can support > 2*10g,4*10g,4*1g,8*1g,8*10g. > The Feature rx side can support rx-cksum-offload,rss,vlan-filter > flow_clow,uncast_filter,mcast_filter,1588,Jumbo-frame > The Feature tx side can supprt tx-cksum-offload,tso,vxlan-tso > flow director base on ntuple pattern of tcp/udp/ip/ eth_hdr->type > for sriov is also support. > > Because of the chip desgin defect, for multiple-port mode > one pci-bdf will have multiple-port (max can have four ports) > so this code must be care of one bdf init multiple-port. > > v6: > * fixed the doc(rst) format problem advise by Thomas Monjalon > > v5: > * fixed the symbol name require by the style documentation > rx_queue_setup > v4: > * one patch has been forgot to upload :( > > v3: > * fixed http://dpdk.org/patch/129830 FreeBSD 13 compile Issue > * change iobar type to void suggest by Stephen Hemminger > * add KMOD_DEP support for vfio-pci > * change run-cmd argument parse check for invalid extra_args > > v2: > * fixed MAINTAIN maillist fullname format > * fixed driver/net/meson the order issue of new driver to driver list > * improve virtual point function usage suggest by Stephen Hemminger > > > Wenbo Cao (8): > net/rnp: add skeleton > net/rnp: add ethdev probe and remove > net/rnp: add device init and uninit > net/rnp: add mbx basic api feature > net/rnp add reset code for Chip Init process > net/rnp add port info resource init > net/rnp add devargs runtime parsing functions > net/rnp handle device interrupts > >