From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57C8EA0548; Tue, 11 Oct 2022 21:22:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0773240687; Tue, 11 Oct 2022 21:22:01 +0200 (CEST) Received: from guvercin.ceng.metu.edu.tr (guvercin.ceng.metu.edu.tr [144.122.171.43]) by mails.dpdk.org (Postfix) with ESMTP id 13C4C40146 for ; Tue, 11 Oct 2022 21:22:00 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by guvercin.ceng.metu.edu.tr (Postfix) with ESMTP id ECD252C2C2; Tue, 11 Oct 2022 22:21:57 +0300 (+03) X-Virus-Scanned: Debian amavisd-new at ceng.metu.edu.tr Received: from guvercin.ceng.metu.edu.tr ([127.0.0.1]) by localhost (guvercin.ceng.metu.edu.tr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cUtEK5s_-Ixx; Tue, 11 Oct 2022 22:21:47 +0300 (+03) Received: from roundcube.ceng.metu.edu.tr (kanarya.ceng.metu.edu.tr [144.122.171.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: e1885458) by guvercin.ceng.metu.edu.tr (Postfix) with ESMTPSA id 1CD272C061; Tue, 11 Oct 2022 22:21:44 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ceng.metu.edu.tr; s=mail; t=1665516107; bh=WjyuayJTZ5C0Ks47X0co0MKWM8jz3gA2Vzg4AUyJjrs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NEQAVz6xKwuX+7tJ5V5/TkrDqiIj44ng/GQX9+vwHKP+YO37go1YvIVgksVEU52j3 sDWeIaAPxn0BbnY71A/8z9hAE8mUHn/hWI6X39VgXD7oyB0lyRaLMOHGyBIczJTFU+ cjemgF78GPldlxOQNZEVVzOm1JSiy33HHHCW0Nqk= MIME-Version: 1.0 Date: Tue, 11 Oct 2022 22:21:44 +0300 From: Omer Yamac To: David Marchand Cc: dev@dpdk.org, Ferruh Yigit , Bruce Richardson , Thomas Monjalon Subject: Re: [PATCH v2 2/2] drivers: remove the unnecessary version.map In-Reply-To: References: <20221011110850.604496-1-omer.yamac@ceng.metu.edu.tr> <20221011110850.604496-2-omer.yamac@ceng.metu.edu.tr> User-Agent: Roundcube Webmail Message-ID: <0e20fb90e9021512cea9d04e5f50473b@ceng.metu.edu.tr> X-Sender: omer.yamac@ceng.metu.edu.tr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11.10.2022 16:10, David Marchand wrote: > On Tue, Oct 11, 2022 at 1:09 PM Abdullah Ömer Yamaç > wrote: >> >> With the previous patch, some version.map files are not necessary. >> In this patch, we removed them. >> >> Signed-off-by: Abdullah Ömer Yamaç >> Suggested-by: Ferruh Yigit > > I'd like some check added as part of this series. Thank you for this patch. > Something like: > > $ git diff > diff --git a/devtools/check-symbol-maps.sh > b/devtools/check-symbol-maps.sh > index 32e1fa5c8f..9d2f85ed73 100755 > --- a/devtools/check-symbol-maps.sh > +++ b/devtools/check-symbol-maps.sh > @@ -60,4 +60,18 @@ if [ -n "$local_miss_maps" ] ; then > ret=1 > fi > > +find_unneeded_maps () > +{ > + for map in $@ ; do > + [ $(buildtools/map-list-symbol.sh $map | wc -l) != 0 ] || echo > $map > + done > +} > + > +unneeded_maps=$(find_unneeded_maps $@) > +if [ -n "$unneeded_maps" ] ; then > + echo "Found unneeded map files:" > + echo "$unneeded_maps" > + ret=1 > +fi > + > exit $ret > > > It helped me catch: > > $ ./devtools/check-symbol-maps.sh > Found unneeded map files: > drivers/net/mana/version.map That’s my fault, I forgot to rebase my local repo. Thanks