From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 588F541CB1; Thu, 16 Feb 2023 12:17:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B06D42BC9; Thu, 16 Feb 2023 12:17:38 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2089.outbound.protection.outlook.com [40.107.244.89]) by mails.dpdk.org (Postfix) with ESMTP id DAF4540E0F; Thu, 16 Feb 2023 12:17:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OICe+J36F9jamfb86Rhl0/6/qntb4VDkA0ycDr/iFEBwdUpMl23iFhLgQixLezjya1T5OuzAmfVLmmH+6qcsgC2uIFo4H5xAuMlAYiYre4eJOuhPYda+g558zV8RHz8nTA5OKuRr6hbOCuXGrQmd56KpMJhTMKrEH2d8S7RQyESFLoaFxlRIppX+6B9xPwzL+qRtm/q5Tr73G/xC0zdPVeR53MO9ECZnW5ER12qAVjKq8JofsIuvFIX/KTSL3WJGZ1PNEe8iXAdpi0HCAG8uXRP2FDp2JhjxvBedYS1Nx9sx93V/ZkeRnS4XEKUslBFjqIMt/2NoEFIptjsVDz7mzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sx7qhdRZAOHGaHWElxIQ1UtzQMMugrpvam3gcFbC8uk=; b=dDBoGYwUYjXDfpAogR3RHMgjjaJUTz3gwhLUCyUhkxbXcoGhe+mQLPW+Ye2yEhOK0lVjudTGS8k2DTlmjrIQJfHUw98lfUBYSeVr/iJyApFIthLiaOyZJIjU7QSXN3LQf0IQamRABooqS0FY4rv1lYI6rcGC9WIo4zuCFpeFJLC8Z/lSGDY+uUzZCtwv3o/0KsWgEpPccNjf1xHrAmhlh5Lmw0B7ugVUQhAt7AskP2CEKAu2iOxzQo3XBBd8dVIfYJd03Gf2DNez0GGRnmzw9GlfJAE6Zwk3PPqvXCBR/Vz+EA0a+wzv5wtrFItbODRVaDzOtZlQmZ6M1oBlBGpDXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sx7qhdRZAOHGaHWElxIQ1UtzQMMugrpvam3gcFbC8uk=; b=2fHEYKv1VIpudq1ZJPn4N/iJF3Bf77UiOlbkiwwxJFn1cGGAU3a3hWbFoL6NWr7lwz9AUhfTZb3gDUTXJrB5cQGnh9rzCiTZ0hxyWs1bVKbzx8Xb2IEJ9Wq17JRfn3VSVwOvrSP4+D4xtw/Zv9YC6TdaWIGa8e1ZXHj2p94bKLY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB8287.namprd12.prod.outlook.com (2603:10b6:208:3f5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 11:17:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 11:17:34 +0000 Message-ID: <0e323fe5-5c9b-bca1-684f-3ceb07a2771d@amd.com> Date: Thu, 16 Feb 2023 11:17:27 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk Content-Language: en-US To: Nole Zhang , Chaoyong He , Niklas Soderlund , Kevin Traynor Cc: "Xueming(Steven) Li" , "dev@dpdk.org" , Luca Boccassi , oss-drivers , Kevin Liu , "stable@dpdk.org" References: <20230208091544.22122-1-chaoyong.he@corigine.com> <1856a555-e7d5-6dfa-6cf0-c4e170b81482@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P265CA0026.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB8287:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c8de6bb-0d24-4297-d6ea-08db100f66de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kje4X3rdJMeR8/UpKGMwfQ+632F/JGSa3a0s7a+1Y74IOxblsIBOYoTSJMlAMX9uD2DwoP6M/lZ4Lg+/jE77SeYAB71ponUPHkzX+KR5eKgKTaX76s6gEf10RkedzlWCfdd/UsFmPa7DFHZJnzqdENUOGkqMnCMMYabxAsAPeVqG+hCWiBmqPrIl3ZFgIrN1U9cK2JWQ2DmwHk3jQBMQbqi8PKfRMmsui6bw2q4FR3dmsFCN0islXWtKjoUQzZ9ltgkEzI32+pPKcGZ4fEV+lcwhgZ6tmfmulyT8vVIx6LtcN8wMaTUNJWNxPac9NmHysai94dYjHZ3k5RpTPmnG+K5LwVVCc3nBmc/ONbwMj3Zu0KBQdQ18AvbnepYOEFmtFIXbXq5xHnNRbOsiNi29/hfnkedbbm/AWSCY0X95ggE22NELcwyxopaVvfPn2hEEZlOipl3Pplz6dW4fGyLdh1pqX2AO++NKCPHRo40M8Pan5cpqRPB0iCa3GtLnRPpU1OwhQbIUTadqzil6Svxy1LB7czgZv5CZVF01w1rZsPubHi3xSRYKZMc3Mladj6uCkiWM7ZD5TuFaoYJGIOLhBZ4mgua4zglEpXoJAOtxX38C+8uu47t7isQZcVt7o9SCuS3XeprnhQKSJC6hZuBQb+Yki558++HTb8kRDfo59ko1UWm4ouOjTD7A0tunybBw6Msbx+RfCGMUnI+qKEm9eQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(366004)(346002)(376002)(39860400002)(396003)(451199018)(66556008)(66946007)(31696002)(110136005)(83380400001)(2906002)(54906003)(36756003)(66574015)(316002)(66476007)(2616005)(8676002)(966005)(6486002)(44832011)(4326008)(8936002)(53546011)(7416002)(6506007)(66899018)(31686004)(6512007)(186003)(5660300002)(478600001)(86362001)(41300700001)(26005)(6666004)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGw5Y0xtMHV5NHdOSE1LZVNjU1Y3dklnczlGL3hHK1Q2WE9kNlZSQmkyajd5?= =?utf-8?B?ZFk0QTIzdUdWeEtxYUd2YkN6MjZsVmFGdlhaOUZUS3R6RUdRSlhIVUZ6cnEr?= =?utf-8?B?dkY3Tjhoa3dhQytOeFpaZUZ2eXIyZzU3UElYRW41K1UrckRtQmNwdm5FYmhO?= =?utf-8?B?YmNDVVVEZFJmT3dKaUliRFg4ZTRlb0VtR3ZFbGUrVGpmUWFTOVNkd210TWlU?= =?utf-8?B?cDFjTWxZS1ZQbUdhb3RmU2d2c2tGemw0RHV1dnFTMWc4M3VtcVRacHcxN2pF?= =?utf-8?B?WFRhNW45RFpET0lQME5qeDJ3dVZzaitRMDFaM3orUlprVkVjQ3ZYUTdxQ3pL?= =?utf-8?B?SkFtanFPWFEvNVd2QVNuMVhWZG1jbzNjZG8xR3d4QWhzT0lZMmZFUFlWVVF6?= =?utf-8?B?dXRKV3QwR2VhV295cEthMENqT3Ezenh3MnlsVTRiV3NSdVdOT0JzMk5nSDlI?= =?utf-8?B?MUd4WW9YbzZiVVc0OFBxaDVvQlNrUlVpOUJ4YUU1QnZobGNTd1JFVi8vd0hq?= =?utf-8?B?b2JabWZrRzJ4WkI0aHROTlVHS0FsREhVRHZoWmlDQk1qQUk3R2NBVzFlSm5P?= =?utf-8?B?OXFZenVTZktIZHRoWFNlci96ZTh0SGMvWUxBeEN6aWtZVGRORGNwMXpuRW1V?= =?utf-8?B?S2RxQWplL1A5UlBNZnp6Z010V3JXaThRODhjbnRYNStmelNldnd0UmRaUEZS?= =?utf-8?B?Uk1xTmRINlQ0dncrV2krOXpxZHlXckh0QjJFMnVpWTJVbDZ1YjVGSHV5WTZ2?= =?utf-8?B?RlBWQ3BQdlhadHpOd1ZzUk96UFBwa3MxRHFmYTZuZ0QwaFpBZlNSY1g1T2Q3?= =?utf-8?B?VTNReGswQU5iWkVsL3NMK29TdUkyK3F0VS9ybEpwaEhGNGt0Vm5iQjU3TnRC?= =?utf-8?B?VUVnNnFOcEJoTndrUjgzSTNOVUpVcGJRTnZvckErMUhGYmprV2tUcFlJUDJz?= =?utf-8?B?Z3k3b3lDc25aWk5UcDJXVFdVSHptUWZNOGg2TVdJUFZUMVYwR3VlMnZITGE5?= =?utf-8?B?c2VyT05CK1RrZmdiSHNCOGVCbUU3QjE0cnBTYnVZSDZoUDU3ekxNdXJLUFQw?= =?utf-8?B?Z3pRWDZkUS82V1V6NzhZQnNjNk4vZTFZTVlFNEpmZHJJSjJKUVZ6L3lVeUlR?= =?utf-8?B?UjJtTzhJaTNmaExxVEJWVzkyL0t5eXQ4bVEzekc1OG4xeVpJYms4VVRZd3JT?= =?utf-8?B?UGZwMGJHTFVkK0w4Y056VUdvUTlySDF1dzRZYjVQTmhUVVlaTU9nU2N0bkNn?= =?utf-8?B?d0NualBQa1dKTE5xdjI3WHpnL3pYSHJxV2t4V0lEREpLMVAyeCtZQjRia0VK?= =?utf-8?B?QTNEd2NPRmtGSTd3NFM4amR6Vk9MOUNNU2NaZU5qN0VGeUxpdGp2SHdkQ2lt?= =?utf-8?B?Q24wYWJHMEZVWThEWTc1NFFMeXpKaEtITjF0cXJScDF2WUNkbUJ0bmZiVVlQ?= =?utf-8?B?VGwrbXBLRTVhekZkbVVtQnBBRjdCLzdNSjZ5a2d6SnlrZExKVGk1S25NQUk5?= =?utf-8?B?S3FRSzczcWFTcUk0Y2JXc3RuemgycjQyZXFJMm1kOXBQZUE2UWRPZWtRdlRW?= =?utf-8?B?T2ZWZVJEZTkvWmxHVjZ0OC9MTDVaQlVYTlUzNWFnbG1PREVkMFRxQklKR0lo?= =?utf-8?B?YVU4bitCODU2dVR2cEZINFUxdkU4QmpIdW1UNlFxUDJkNUJRbStJYWg3emIw?= =?utf-8?B?Qys2ekF6MFU4L3NhQWplNHJENk5zeGp6RU95UUpyTXBPRjNhekRIUlhERUhx?= =?utf-8?B?T2c4UjIvSkVaTFgxd2lZeW9PQnRnRGdDbTJjSFkzTDg0L1d5ME9VWUJMQnFl?= =?utf-8?B?Vno2a3lDSTlhdk1hSjlVNzJHK2ljMWR5eTM5d3YrbDJjemNLMmcrUGM4ekUr?= =?utf-8?B?NXVHNUpSSnJGeHRnczhLUytHMVZHYzFsTkRWdGE0U1RKa1h3Z3pqRWlSNGhV?= =?utf-8?B?dndHb01hR1hzYjg3YU1rUHBxaFozMzU4RHN4YmltZEM5Z1hjNDJJd3RWdnR5?= =?utf-8?B?U3dEdWJLV1NmR1EzeFBLQTRORXVZRkhVSWVhblFOZEZobktJaS9BZnlZeUtF?= =?utf-8?B?ZnRNVTdwME90MHBpZlpSNDdvaG5PbEF3a0YzM2xEZVZ2Zk1BdFdvTUIyMjR0?= =?utf-8?Q?7zsV+g+F6TrMD91i3LKvGoZt7?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c8de6bb-0d24-4297-d6ea-08db100f66de X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 11:17:34.1656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BXrcoJbSqXQSpsmmmQ3kTCitpbJ+EgTkeA8tpgE21XkWbsS+TC/iV2shvFSMSAxI X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8287 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2023 11:11 AM, Nole Zhang wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Thursday, February 16, 2023 7:00 PM >> To: Chaoyong He ; Niklas Soderlund >> ; Kevin Traynor >> Cc: Xueming(Steven) Li ; dev@dpdk.org; Luca >> Boccassi ; oss-drivers ; Nole >> Zhang ; Kevin Liu ; >> stable@dpdk.org >> Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with >> NFDk >> >> On 2/16/2023 10:41 AM, Chaoyong He wrote: >>> >>> >>>> -----Original Message----- >>>> From: Niklas Soderlund >>>> Sent: Thursday, February 16, 2023 6:37 PM >>>> To: Kevin Traynor >>>> Cc: Ferruh Yigit ; Xueming(Steven) Li >>>> ; Chaoyong He ; >>>> dev@dpdk.org; Luca Boccassi ; oss-drivers >>> drivers@corigine.com>; Nole Zhang ; Kevin >>>> Liu ; stable@dpdk.org >>>> Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware >>>> with NFDk >>>> >>>> Hi Kevin, >>>> >>>> Thanks for your input. >>>> >>>> On 2023-02-16 10:28:34 +0000, Kevin Traynor wrote: >>>>> On 15/02/2023 18:28, Ferruh Yigit wrote: >>>>>> On 2/15/2023 5:47 PM, Niklas Söderlund wrote: >>>>>>> Hi Ferruh, >>>>>>> >>>>>>> Thanks for your continues effort in dealing with NFP patches. >>>>>>> >>>>>>> On 2023-02-15 13:42:01 +0000, Ferruh Yigit wrote: >>>>>>>> On 2/8/2023 9:15 AM, Chaoyong He wrote: >>>>>>>>> From: Peng Zhang >>>>>>>>> >>>>>>>>> 48-bit DMA address is supported in the firmware with NFDk, so >>>>>>>>> enable this feature in PMD now. But the firmware with NFD3 still >>>>>>>>> just support 40-bit DMA address. >>>>>>>>> >>>>>>>>> RX free list descriptor, used by both NFD3 and NFDk, is also >>>>>>>>> modified to support 48-bit DMA address. That's OK because the >>>>>>>>> top bits is always set to 0 when assigned with 40-bit DMA address. >>>>>>>>> >>>>>>>>> Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") >>>>>>>>> Cc: jin.liu@corigine.com >>>>>>>>> Cc: stable@dpdk.org >>>>>>>>> >>>>>>>> >>>>>>>> Why a backport is requested? As far as I understand this is not >>>>>>>> fixing anything but extending device capability. Is this a fix? >>>>>>> >>>>>>> I agree this is a bit of a grey zone. We reasoned this was a fix >>>>>>> as we should have done this from the start in the commit that >>>>>>> added support for NFDk. Are you OK moving forward with this as a >>>>>>> fix or would you prefer we resubmit without the request to backport? >>>>>>> >>>>>> >>>>>> I am not sure, is this change have any potential to change behavior >>>>>> for existing users? >>>>>> Like if one of your user is using 22.11.1 release, and if this >>>>>> patch backported to next LTS version, 22.11.2, will user notice any >> difference? >>>>>> >>>>>> >>>>>> @Luca, @Kevin, what is your comment as LTS maintainers? >>>>>> >>>>> >>>>> A bit difficult to know. If NFDk is not practicably usable without >>>>> it, then it could be considered a fix. If it's just extending to add >>>>> nice-to-have functionality then probably it is not a fix. >>>> >>>> I think we can treat this as a nice-to-have and not something that >>>> makes NFDk unusable. As stated above, we marked this as a Fix as we >>>> *really* should have done this in the commit which added NFDk support. >>>> >>>> @Ferruh, would you prefer we send a v2 or will you drop the Fixes and >>>> CC tags when/if applying? >>>> >>> >>> Actually, the DPDK app using the nfp card with a firmware of NFDk will >> coredump without this patch. >>> And that's the directly reason we consider backport this patch. >>> >> >> It has been long since NFDk FW support added, how a crash missed until this >> point, is it crashing in a edge case or something? >> > Yes, this occur in the server with CPU FT-2000/64, it has 2 PCIE1 x8 and 1 PCIE0 x16, > Pcie x8 can only support 48 bit, but the pcie16 can support 40bit. OK, can you please send a new version of the patch updating patch title and commit log to highlight that patch is fixing a crash. It can be helpful to detail the reason of crash in commit log. >>>>> >>>>> It would need to ensure that it is tested on 22.11 branch and there >>>>> are no regressions. It is only relevant to DPDK 22.11 LTS so Cc >>>>> Xueming who will ultimately decide. >>>>> >>>>> A guide below on some things to consider for this type of backport is >> here: >>>>> http://doc.dpdk.org/guides/contributing/stable.html#what-changes-sho >>>>> ul >>>>> d-be-backported >>>>> >>>>>>>> >>>>>>>>> Signed-off-by: Peng Zhang >>>>>>>>> Reviewed-by: Chaoyong He >>>>>>>>> Reviewed-by: Niklas Söderlund >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>> -- >>>> Kind Regards, >>>> Niklas Söderlund >