From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3B4CD7CEF; Tue, 23 Jan 2018 15:32:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jan 2018 06:32:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,401,1511856000"; d="scan'208";a="24044604" Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.65]) ([10.237.220.65]) by fmsmga004.fm.intel.com with ESMTP; 23 Jan 2018 06:32:40 -0800 To: David Coyle , dev@dpdk.org Cc: stable@dpdk.org References: <1516716855-14805-1-git-send-email-david.coyle@intel.com> From: "Hunt, David" Message-ID: <0e3713d3-b49e-401b-0fbe-ae1053ebb8fe@intel.com> Date: Tue, 23 Jan 2018 14:32:39 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1516716855-14805-1-git-send-email-david.coyle@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix set VF MAC address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2018 14:32:42 -0000 Hi David, On 23/1/2018 2:14 PM, David Coyle wrote: > Current code only sets mac address of first VF. Fix code so that it > continues through the loop and sets the mac address of each VF. > > Fixes: c9a4779135c9 ("examples/vm_power_mgr: set MAC address of VF") > > Signed-off-by: David Coyle > --- > examples/vm_power_manager/main.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c > index a50984d..a9f5ad1 100644 > --- a/examples/vm_power_manager/main.c > +++ b/examples/vm_power_manager/main.c > @@ -290,7 +290,7 @@ main(int argc, char **argv) > for (portid = 0; portid < nb_ports; portid++) { > struct ether_addr eth; > int w, j; > - int ret = -ENOTSUP; > + int ret; > > if ((enabled_port_mask & (1 << portid)) == 0) > continue; > @@ -308,8 +308,7 @@ main(int argc, char **argv) > for (w = 0; w < MAX_VFS; w++) { > eth.addr_bytes[5] = w + 0xf0; > > - if (ret == -ENOTSUP) > - ret = rte_pmd_ixgbe_set_vf_mac_addr(portid, > + ret = rte_pmd_ixgbe_set_vf_mac_addr(portid, > w, ð); > if (ret == -ENOTSUP) > ret = rte_pmd_i40e_set_vf_mac_addr(portid, Acked-by: David Hunt