From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6231AA00C5; Tue, 15 Feb 2022 12:19:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3456F410F3; Tue, 15 Feb 2022 12:19:56 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id C6C9240E78 for ; Tue, 15 Feb 2022 12:19:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644923994; x=1676459994; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=mVjUwHp8Q1QXoEtM3x3WRerxbcaKgNu1A2KdDpJ6FYs=; b=JnJbREloJr0Q0cVz0pwqljvc0TqRCCV3PtgBGP+ahhj0Mw2IxiYCR07c W0GUMUoQP2w9ZmyGAuuvpT6vUuMNKTzr/LTeKA2cTTEBKOyVfFfHcC/7o 3NnLs7QMm0JEPfak0lpwvmCYMBs/4um8HZClaLIscWtDGm0BRfrxA0SkO iBnuT0aQcVhRjY6bIVoSZHdMNZc8xePVnbcwVqZnRiMJpUrxXdXo/pQeg pzj99IRHr3fdk/fX7SL+NTCjKSHUF+3OOIzXe7ZSyNVNidtQk2o0Kbz1W fvSk+9E83mPrZVfrJ6Bu0U9oE00kTJxG+HpEqNTEK7pxa5hG3XH29/xgZ A==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="274903101" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="274903101" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 03:19:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="703604511" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 15 Feb 2022 03:19:53 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 03:19:53 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 03:19:53 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 03:19:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDI0wugfOVEQk+R2wV+eNT5GRrqtR3RgWZ23NMPn+KaYX1lLtNusWsb3lCPgdN0t3KTrxEJeV0tlObn4z1OrH4wX31UgOia/zSfzqd/0DDSZQfTbeFM4TsngIX69YIfv79OPo8WHzYxOq5JvWy12IGSwtPvH8IfT0/KDCJV9kb3pDrR1qxX1NHAwzaosVN3A0nvGP4P9A9suniI6bsB+AFn/Mibxu9qy+Vvri0wThWIOWg+WSRmuBt3tPy05DTVJbIhgkifDvWUQ6rSfIS1cBkn5MRbMGCmI6WxWw87C6xiNhHcDBgeRv+Ncm8sEMVbfOrHxOqQLN2z8C8u361aZxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MhjfeaSAr5s2gLb2ZY7I0NnIVVAbbCdq8ZH25E1Nw4c=; b=hpUIhlQXxdf3m+jCOoRo3B9c/Zptgdjf3jTuwvn6vDs2FNuBzdfN/nT/iMryIpMIFCLKzzVGuTns8XwRnSx4IsIOMn2i6/aedeuRWiNMd6U5gU9T+wkkcXA3bcc1H/EFAcpQBY/a/JDUGkm6fvxn2fvak+a0d/sSJSXkZLrxlsNU/R4z3W6BmlI90cCxV5hI+0px2AOoSS1yOqmyGh03Zq6OSdR6GlKMw6hi8wt8yjZl2wP4vntPQH50wdN3ConDFhY+oCbzbPF1WPnEFlP49meaG+OFXkMIPeI0B42si2iu9YmQnhR5L+DRzLMIcbLHxgJPE7ADN+9sq3HDXuxKow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MN2PR11MB3886.namprd11.prod.outlook.com (2603:10b6:208:137::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Tue, 15 Feb 2022 11:19:50 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 11:19:50 +0000 Message-ID: <0e492107-2325-8f79-7a7f-ad652c40c741@intel.com> Date: Tue, 15 Feb 2022 11:19:45 +0000 Content-Language: en-US To: "Nicolau, Radu" , Jingjing Wu , Beilei Xing CC: , , Kevin Traynor , Luca Boccassi References: <20220210130923.1442905-1-radu.nicolau@intel.com> <05a27976-6664-190c-38b7-9b63c7294973@intel.com> <23e5a111-9402-d6ce-a076-5dbcb24f5937@intel.com> From: Ferruh Yigit Subject: Re: [PATCH] net/iavf: fix segmentation offload buffer size X-User: ferruhy In-Reply-To: <23e5a111-9402-d6ce-a076-5dbcb24f5937@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0521.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 645a3f9f-ba59-428a-8769-08d9f0751512 X-MS-TrafficTypeDiagnostic: MN2PR11MB3886:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:480; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RYIBreYNVLbnIZWSyX2VqJncaIs8YyJXTYbmyUeofUBtgE0QvRz7svtXgsvr58P9lvhHKglbrNVAr4IsE21Fsq9zDFiohbb4XMzXi3tlheSeCFVqWnopGPiwwXL83DXGZ8LPNTlAexC3I3zjBE2uSwOgJUh4x/kJRLtzjmYdZrQwpDWew5nYFfsbLYdE2mhWDWPrngwTgDsF1BYWc/U6W/mB/+yA7G9iDsyvg/moucndubD+kmFtpd2J+r7pRmIe5QUrr8LqmM/sluf447SlbyZvrBrNv8c+2sVhjuxzrbII+qR1FiVVsFXC38U87YdxtEwtALQmdqAgbvDlcDjkV8LcqqNLKrdywM5C9hWBkq/1EjnLluQAEuREMvEF1E+oDdP5JDS9IYPA5+R3YRVfgt+5ujue8rMApTxDVyoZbyne4HN7evEceWR3mbpLavkTe48P71sF2tdLjP7dpzKwnbuFUPDJNghsNouina86zMwB1WRDuyNl3YSFHoGwzBYoqREq6B3MKJenzXsv6ye+sgTdCCPlPNTvRM3ppVOqNK91uedFIy7WD99oihtH0pYubQtTuHJDn2Q5+7rh1BzH1tO3jyCkG5fbjzKN7x4Ratelo3MH+FJalmQ5cjEsP14FmxYvEfsnKs8ev4tPSMQWVY7ZauXpdbKmJU9EI5zHEUMhR0eHpXiPIRI2ZPhkl6ibAOVbMsPTtCQ3Ph6uh8EAIQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(5660300002)(82960400001)(6486002)(4744005)(6512007)(66946007)(66476007)(66556008)(316002)(186003)(508600001)(4326008)(44832011)(8676002)(53546011)(26005)(38100700002)(54906003)(6506007)(2616005)(31686004)(31696002)(8936002)(36756003)(86362001)(6666004)(110136005)(6636002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dE9zUTdoNHl2d0FwYU1UTkpSS3VpVU9DVGJ1RmRWN3EyUU5QeG14SzVWdEQz?= =?utf-8?B?UVRqUmhzeEFwOElRSjh6TXF3eStkTGJJcXpvNWc5cmkzemRERVo3Y3huWUlp?= =?utf-8?B?cUFMYWZmck12d2ZUT0xyN0NSUUlaeEZzZFIxbXBjczE4UGFUbjZzRFYwczJi?= =?utf-8?B?c3FHcER5VXkxSU5jSlgydUdmNzZIRDVoaHR1aHphcEV2V3lGQ0MwSEtKV2VY?= =?utf-8?B?VGp0UDJlYUVCZEIwS1h1QjlRbUNzalBieFNEbVdqY1E2bjlDSzBkSjBuMU9y?= =?utf-8?B?elFTdDdscU5oZWVHb1NhMkMyek0xQ1VJbGtUTkM1UmFtYTMzaUVZd0ZrTHVo?= =?utf-8?B?c1g3NHRLUnpkSzdibEcyc2lNNzhkT1VsNjRPN3R6OE5LOHNYZit2QnBTUVl6?= =?utf-8?B?dFFON2xpVURWZVV0dFpiWUhwQXJZeWx2c1B5QUxKaE1TMEhXNWJqREV0MlBx?= =?utf-8?B?RWpHYXVRQW4yQ0xIeTdPdEkxREgxdWZLb3V4OEJRM2d6SFBIQU9SUnZNRVRE?= =?utf-8?B?bUtkcUxjYXY3UFI0cjJRVzVBUGVNamxkbm9mMDNRM0ZIdi91dlRjNUhWbDE0?= =?utf-8?B?dUFablNNVFBUV2VSUStvcE94YlJJckpHV01KOU9KUm5FdGVGSjBUUDVaL09J?= =?utf-8?B?TU1pWUhEZC9kTjhWZkpMM2tZb2pzQ1ZnT28rcWNsbmZmcDc5MnUvQ1hlcjlY?= =?utf-8?B?N3ljRkRVaHVCV2RwTkJTVGxNNlNEbDg3YitETEZpVlNWTDBTZnZ5aGhjek5I?= =?utf-8?B?Z1E1L1p1WEE3VFhOMWNWcFJqSHVaY0s0OXhObytHRnpqWVlCdmxXL0xhOUU3?= =?utf-8?B?eUNrWExBVENvNE5ReHNhMWpZTEhNaldmUW93Q0c3ZkpOdWUvSENraGJRMkhm?= =?utf-8?B?cjBvemRDTkt5ZXlEUGt2czkyQWVOZktZNlNFMTNXNjYwVSt4SE5WMm5rdExu?= =?utf-8?B?RE8zVEMrWnZNYVY3OEwyekNwN3F0NTZPajYwUUxzNW9EK081R0ZzYTdja3My?= =?utf-8?B?Tklubm5VejI3YnJVbUdzS29icmQyendYRlVUUWE4UEhVV2lqTHdIb2pnSmM4?= =?utf-8?B?TlJXR3pFTFh3N3hYRHlLOUZhZ1YxRHJ5TWl2OGhCVnF5S09hRUwrYUZsZTJE?= =?utf-8?B?dFZqMnd5SUZ1Y0NUOWo2Y2N4cmQ1RG9pYnExNW9HbnRiamxZOExRL3NQR1ll?= =?utf-8?B?T3NGQmFxRWhPeVRxZ0prVVg4bjhCbjdRSXM5QlN0NWM2SDdCY3R2NTY4dGk4?= =?utf-8?B?WEQxYnpZNzJQaVdNQ0lKSnRkNUFSemJQRXo4ZHY5dEhZWFJMbE1peXV5emZX?= =?utf-8?B?UFlIamtNd0E1c2RFWStsV1dQR1Uxem1IRFYxWHIwWThhZXNiczFQQUltWmkv?= =?utf-8?B?bDJpRmV4bS9RRTRqbkpMUjZaWEZMNk1ZRGJTa2RTeVZwQWpML05nNFc5SjVn?= =?utf-8?B?aFhqdXFkOFFOZEVxNXpKL0FUQlVUbGt1UXBlZ2JPUWhOdXMxUUxCaE8wM0ty?= =?utf-8?B?R0RwTkY1VUt1SUhOZ1VsZFE0WHE1T3c5M1ducFpzK25CVEg3MVVRRGtIRllK?= =?utf-8?B?WWp5ekJJU2c4cllDUVREcDlGMG13RjBRWGNFbndmUWVVTmpuZC9lQk5aS2g1?= =?utf-8?B?THY3OFVQMFVCelU4eDJvUUxCSHAwQVlzWTROQ1NvWHpFWnZ6aTVDT0szU2tl?= =?utf-8?B?dEZGbEZRK3UwNU5SUzU3RTBPZFJ1Y2x0bTJwaG1vM1UxNGlDS3Qwc1p3ZWta?= =?utf-8?B?dzlOeG9yOXczdjUzV3QxYWdLbGxjK0k0YnpaYWdPVXluRHRPVTJaclVuWEtF?= =?utf-8?B?WTZnZ2dvVzZXUDcrZXVwbUJvejhFTGVBK25WZ25kZTZMQlJLdWtZZGdqQXA2?= =?utf-8?B?dHpzQk5aTFFlZ3pWRy9YYUJVbmFkUVB0NW5DWTlEeStQdEZ3ZGJ5cVlEZlI2?= =?utf-8?B?RmNySy9aUHVXOXlhKzFVbGU2Ry9lOEFKQ1FjaHoxVW12NE1tc1FmdVd0MTJR?= =?utf-8?B?UFZhb2c4RUpweWVYWFpEVVhkNDJlNmFlamJwQXYwUUs0cTdGUXcvazdKQTRM?= =?utf-8?B?MHhMbHM5ZkJEQ0hGMk02aVVlYmdTTHRRcUFaUzFlMXA5UEZQRk5DSnIybEE5?= =?utf-8?B?Qm9SaUE4c3lEdXZZYVpHT21LQmVESXV3VVZYdVJZeDBFTFNwN2dGOGwyM21w?= =?utf-8?Q?glfV/LZP8/wLjto2uNR+Pag=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 645a3f9f-ba59-428a-8769-08d9f0751512 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 11:19:50.7198 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ct61kJTqbEDlHu7Z42LcG4YYcZlkEcE89OQo5BdVylfbQbbTtmgyekyeY3oXpE/wMYho5DBSA8dzn1HBS3jUPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3886 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2022 10:47 AM, Nicolau, Radu wrote: > > On 2/15/2022 10:06 AM, Ferruh Yigit wrote: >> On 2/10/2022 1:09 PM, Radu Nicolau wrote: >>> This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size >>> being computed for TSO packets. >>> >>> Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") >>> >> >> Commit 'ff8b8bcd2ebe' was already fixing segmentation offload, >> are we having the initial issue back when this patch reverted? >> Is there a fix for that initial issue? > The initial issue was around a very specific usecase - IPsec transport mode TSO and it is very likely back with this revert. But it's a much less severe impact than general traffic TSO. Got it, so this revert brings back an issue, should we document this in the commit log of this patch? Plus should we create a Bugzilla etc to record the introduced issue?