From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4823A054F; Tue, 16 Mar 2021 18:38:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CC0F406A2; Tue, 16 Mar 2021 18:38:38 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 957334069F for <dev@dpdk.org>; Tue, 16 Mar 2021 18:38:36 +0100 (CET) IronPort-SDR: tHvn4hv7VM5Bll3osMhHru6xQ24JQoYSOdtjTHBOk9kdXYXM4+ckjKf0nBfuNPxZHzErwy17jd O8sTrRoKwL9A== X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="189399431" X-IronPort-AV: E=Sophos;i="5.81,254,1610438400"; d="scan'208";a="189399431" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 10:38:35 -0700 IronPort-SDR: 9eTS5akXzGB3z7x2wnpfWnVkWdNue3oTj4msxTUTT4bjrLYicq4twptmKKEBk30UxVETc9sBSD ZBiL6zdcSRhw== X-IronPort-AV: E=Sophos;i="5.81,254,1610438400"; d="scan'208";a="405615171" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.11.157]) ([10.252.11.157]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 10:38:34 -0700 To: Ivan Malov <ivan.malov@oktetlabs.ru>, dev@dpdk.org Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Andy Moreton <amoreton@xilinx.com>, Ori Kam <orika@nvidia.com>, Thomas Monjalon <thomas@monjalon.net> References: <20210312093143.28186-1-ivan.malov@oktetlabs.ru> <20210312110745.31721-1-ivan.malov@oktetlabs.ru> From: Ferruh Yigit <ferruh.yigit@intel.com> X-User: ferruhy Message-ID: <0e5845a3-a06a-b335-959b-77cddee206ee@intel.com> Date: Tue, 16 Mar 2021 17:38:32 +0000 MIME-Version: 1.0 In-Reply-To: <20210312110745.31721-1-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 01/10] ethdev: reuse header definition in flow pattern item ETH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 3/12/2021 11:07 AM, Ivan Malov wrote: > One ought to reuse existing header structs in flow items. > This particular item contains non-header fields, so it's > important to keep the header fields in a separate struct. > Hi Ivan, Andrew, Thanks for following this up and updates. For record, existing deprecation note is: https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst?h=v21.02#n99 Ori, Andrew, Is there any struct left not updated after this patch? > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru> > Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> > Reviewed-by: Andy Moreton <amoreton@xilinx.com> <...>