From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 31F414C99; Fri, 26 Oct 2018 16:23:38 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2018 07:23:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,428,1534834800"; d="scan'208";a="81136698" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.8.177]) ([10.252.8.177]) by fmsmga007.fm.intel.com with ESMTP; 26 Oct 2018 07:23:36 -0700 To: Darek Stojaczyk , dev@dpdk.org Cc: jia.guo@intel.com, stable@dpdk.org References: <20181024101131.17756-1-dariusz.stojaczyk@intel.com> From: "Burakov, Anatoly" Message-ID: <0e6afdfc-2dfa-a9c2-068d-9fe424de0779@intel.com> Date: Fri, 26 Oct 2018 15:23:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181024101131.17756-1-dariusz.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] pci/vfio: fixup rte_intr_callback_unregister() handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 14:23:38 -0000 On 24-Oct-18 11:11 AM, Darek Stojaczyk wrote: > This function is documented to return the number of unregistered > callbacks or negative numbers on error, but pci_vfio checks for > ret != 0 to detect failures. Not anymore. > > Fixes: c115fd000c32 ("vfio: handle hotplug request notifier") > Cc: jia.guo@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Darek Stojaczyk > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly