From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yuanhan Liu <yliu@fridaylinux.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Junjie Chen <junjie.j.chen@intel.com>,
Changpeng Liu <changpeng.liu@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit
Date: Mon, 5 Feb 2018 14:21:47 +0000 [thread overview]
Message-ID: <0e8c66d8-3265-8088-f026-6a13f039cf47@intel.com> (raw)
In-Reply-To: <20180201144742.GR29540@yliu-mob>
On 2/1/2018 2:47 PM, Yuanhan Liu wrote:
> On Wed, Jan 31, 2018 at 05:48:28PM +0000, Stefan Hajnoczi wrote:
>> The vhost_scsi example application negotiates the
>> VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing
>> vrings.
>>
>> In particular, commit e37ff954405addb8ea422426a2d162d00dcad196 ("vhost:
>> support virtqueue interrupt/notification suppression") broke vring call
>> because vq->last_used_idx is never updated by vhost_scsi. The
>> vq->last_used_idx field is not even available via the librte_vhost
>> public API, so VIRTIO_RING_F_EVENT_IDX is currently only usable by the
>> built-in virtio_net.c driver in librte_vhost.
>>
>> This patch drops VIRTIO_RING_F_EVENT_IDX from vhost_scsi so that vring
>> call works again.
>>
>> Cc: Changpeng Liu <changpeng.liu@intel.com>
>> Cc: Junjie Chen <junjie.j.chen@intel.com>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Acked-by: Yuanhan Liu <yliu@fridaylinux.org>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-02-05 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 17:48 Stefan Hajnoczi
2018-02-01 0:29 ` Liu, Changpeng
2018-02-01 14:47 ` Yuanhan Liu
2018-02-05 14:21 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e8c66d8-3265-8088-f026-6a13f039cf47@intel.com \
--to=ferruh.yigit@intel.com \
--cc=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
--cc=junjie.j.chen@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stefanha@redhat.com \
--cc=thomas@monjalon.net \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).