Re: [dpdk-dev] [PATCH v1 2/2] app/testpmd: support extended RSS offload types

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 11/16/2020 5:32 AM, Simei Su wrote:
> This patch adds testpmd cmdline support for eCPRI.
> 
> Signed-off-by: Simei Su <simei.su@intel.com>
> ---
>   app/test-pmd/cmdline.c | 9 ++++++---
>   app/test-pmd/config.c  | 3 ++-
>   2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 5e2881e..e5f3462 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -2164,7 +2164,8 @@ cmd_config_rss_parsed(void *parsed_result,
>   		rss_conf.rss_hf = ETH_RSS_ETH | ETH_RSS_VLAN | ETH_RSS_IP |
>   			ETH_RSS_TCP | ETH_RSS_UDP | ETH_RSS_SCTP |
>   			ETH_RSS_L2_PAYLOAD | ETH_RSS_L2TPV3 | ETH_RSS_ESP |
> -			ETH_RSS_AH | ETH_RSS_PFCP | ETH_RSS_GTPU;
> +			ETH_RSS_AH | ETH_RSS_PFCP | ETH_RSS_GTPU |
> +			ETH_RSS_ECPRI;
>   	else if (!strcmp(res->value, "eth"))
>   		rss_conf.rss_hf = ETH_RSS_ETH;
>   	else if (!strcmp(res->value, "vlan"))
> @@ -2223,6 +2224,8 @@ cmd_config_rss_parsed(void *parsed_result,
>   		rss_conf.rss_hf = ETH_RSS_PPPOE;
>   	else if (!strcmp(res->value, "gtpu"))
>   		rss_conf.rss_hf = ETH_RSS_GTPU;
> +	else if (!strcmp(res->value, "ecpri"))
> +		rss_conf.rss_hf = ETH_RSS_ECPRI;
>   	else if (!strcmp(res->value, "none"))
>   		rss_conf.rss_hf = 0;
>   	else if (!strcmp(res->value, "level-default")) {

Can you please update 'cmd_config_rss.help_str' to add the 'ecpri'?

Also please update 'cmd_help_long_parsed()', "port config all rss ..." cmd to 
add the 'ecpri'.

And please update the documentation 
(doc/guides/testpmd_app_ug/testpmd_funcs.rst), add 'ecpri' to the section "port 
config - RSS"