From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C245DA04E6; Tue, 17 Nov 2020 14:12:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6CF0567C; Tue, 17 Nov 2020 14:12:14 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 62EFB4C90 for ; Tue, 17 Nov 2020 14:12:12 +0100 (CET) IronPort-SDR: PHf+qVLdv1ujxdP/K5qyPCET5HRf0lD5ELkvhuBusw+00lg5Rx6kVOmwngnXmL3XLPFkl7O0sA fveGYzuSEZlQ== X-IronPort-AV: E=McAfee;i="6000,8403,9807"; a="150188353" X-IronPort-AV: E=Sophos;i="5.77,485,1596524400"; d="scan'208";a="150188353" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 05:11:54 -0800 IronPort-SDR: hrTwM/cugPAdUhZndkJfSOcgZ19ZvmEC51kEVi5xJ98Qrtcs6EhP6h8/EeNyxs1Io0rnOfFhs+ PaQJGsvZaicA== X-IronPort-AV: E=Sophos;i="5.77,485,1596524400"; d="scan'208";a="475914833" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.210.196]) ([10.213.210.196]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 05:11:52 -0800 To: Simei Su , qi.z.zhang@intel.com Cc: dev@dpdk.org, junfeng.guo@intel.com, yahui.cao@intel.com, xiao.zhang@intel.com References: <20201116053238.440870-1-simei.su@intel.com> <20201116053238.440870-3-simei.su@intel.com> From: Ferruh Yigit Message-ID: <0ea0b0ff-bff8-c565-af35-4df838b61b5f@intel.com> Date: Tue, 17 Nov 2020 13:11:49 +0000 MIME-Version: 1.0 In-Reply-To: <20201116053238.440870-3-simei.su@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 2/2] app/testpmd: support extended RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/16/2020 5:32 AM, Simei Su wrote: > This patch adds testpmd cmdline support for eCPRI. > > Signed-off-by: Simei Su > --- > app/test-pmd/cmdline.c | 9 ++++++--- > app/test-pmd/config.c | 3 ++- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 5e2881e..e5f3462 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -2164,7 +2164,8 @@ cmd_config_rss_parsed(void *parsed_result, > rss_conf.rss_hf = ETH_RSS_ETH | ETH_RSS_VLAN | ETH_RSS_IP | > ETH_RSS_TCP | ETH_RSS_UDP | ETH_RSS_SCTP | > ETH_RSS_L2_PAYLOAD | ETH_RSS_L2TPV3 | ETH_RSS_ESP | > - ETH_RSS_AH | ETH_RSS_PFCP | ETH_RSS_GTPU; > + ETH_RSS_AH | ETH_RSS_PFCP | ETH_RSS_GTPU | > + ETH_RSS_ECPRI; > else if (!strcmp(res->value, "eth")) > rss_conf.rss_hf = ETH_RSS_ETH; > else if (!strcmp(res->value, "vlan")) > @@ -2223,6 +2224,8 @@ cmd_config_rss_parsed(void *parsed_result, > rss_conf.rss_hf = ETH_RSS_PPPOE; > else if (!strcmp(res->value, "gtpu")) > rss_conf.rss_hf = ETH_RSS_GTPU; > + else if (!strcmp(res->value, "ecpri")) > + rss_conf.rss_hf = ETH_RSS_ECPRI; > else if (!strcmp(res->value, "none")) > rss_conf.rss_hf = 0; > else if (!strcmp(res->value, "level-default")) { Can you please update 'cmd_config_rss.help_str' to add the 'ecpri'? Also please update 'cmd_help_long_parsed()', "port config all rss ..." cmd to add the 'ecpri'. And please update the documentation (doc/guides/testpmd_app_ug/testpmd_funcs.rst), add 'ecpri' to the section "port config - RSS"