From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24943A034F; Tue, 30 Mar 2021 16:06:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A34CA406B4; Tue, 30 Mar 2021 16:06:51 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id AD06040691 for ; Tue, 30 Mar 2021 16:06:49 +0200 (CEST) IronPort-SDR: 5phNvcnzpJNryAYlTkBKiuFtJ5feuy9mMAT/mpFqt+B7aNqtqyn7x1N5UU6JxVxdoDNDFrbabx S6Pcnau83y9A== X-IronPort-AV: E=McAfee;i="6000,8403,9939"; a="211988028" X-IronPort-AV: E=Sophos;i="5.81,291,1610438400"; d="scan'208";a="211988028" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 07:06:48 -0700 IronPort-SDR: do1T4kYnGUL9/LNjAkSfbqVUAuDVsQqdsJGZVNmQ4af/uN2tUbci43fAA2j9of1fu38DAwrPB/ XwUJRctG3H4g== X-IronPort-AV: E=Sophos;i="5.81,291,1610438400"; d="scan'208";a="418185907" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.213.217]) ([10.213.213.217]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 07:06:45 -0700 From: Ferruh Yigit To: Qi Zhang Cc: dev , Thomas Monjalon , Bruce Richardson , Xiao Wang , Jingjing Wu , Beilei Xing , Jeff Guo , Qiming Yang , "Wang, Haiyue" , "Chen, Zhaoyan" , David Marchand , Aaron Conole References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210323110749.2306452-1-qi.z.zhang@intel.com> <20210323110749.2306452-9-qi.z.zhang@intel.com> <536d43c2-bb7b-7a0e-1ea7-a1fa4c4d7422@intel.com> <9c61411a-7088-45fd-7085-e6fe1f8b4af1@intel.com> X-User: ferruhy Message-ID: <0ea2a7ac-473a-a8c8-249a-5acc59a01791@intel.com> Date: Tue, 30 Mar 2021 15:06:41 +0100 MIME-Version: 1.0 In-Reply-To: <9c61411a-7088-45fd-7085-e6fe1f8b4af1@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 8/8] net/igc: refine debug build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/25/2021 3:43 PM, Ferruh Yigit wrote: > On 3/24/2021 8:31 PM, David Marchand wrote: >> On Wed, Mar 24, 2021 at 8:27 PM Ferruh Yigit wrote: >>> >>> On 3/23/2021 11:07 AM, Qi Zhang wrote: >>>> 1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. >>>> 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. >>>> 3. merge RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX >>>> >>>> Signed-off-by: Qi Zhang >>> >>> CI is reporting a build error [1], I don't reproduce the error and I assume it >>> is false positive but can you please check it? >>> >>> Also cc'ed Zhaoyan & Aaron for the possible CI issue. >>> >>> [1] >>> http://mails.dpdk.org/archives/test-report/2021-March/184153.html >>> >> >> Not sure what gcc+debug target is, but I guess it passes the old config item. >> The compat stuff should be placed in rte_config.h (or something >> similar to config/rte_compatibility_defines.h) and not in >> lib/librte_ethdev/rte_ethdev.h. >> >> To reproduce: >> $ meson configure $HOME/builds/build-gcc-static/ >> -Dc_args="-DRTE_LIBRTE_ETHDEV_DEBUG=1" >> $ ./devtools/test-meson-builds.sh > > Thanks for the steps, I can reproduce it. The alias is not working because > 'rte_ethdev.h' where the alias is defined is not included in this path. > > Following update should fix it, what do you think? > > > diff --git a/drivers/net/e1000/base/meson.build > b/drivers/net/e1000/base/meson.build > index d13f693d3eb8..a9f92cbc4770 100644 > --- a/drivers/net/e1000/base/meson.build > +++ b/drivers/net/e1000/base/meson.build > @@ -33,6 +33,6 @@ foreach flag: error_cflags >  endforeach > >  base_lib = static_library('e1000_base', sources, > -       dependencies: static_rte_eal, > +       dependencies: [static_rte_eal,static_rte_ethdev], >         c_args: c_args) >  base_objs = base_lib.extract_all_objects() > diff --git a/drivers/net/e1000/e1000_logs.h b/drivers/net/e1000/e1000_logs.h > index 86f546b0f9ed..210c3447c66c 100644 > --- a/drivers/net/e1000/e1000_logs.h > +++ b/drivers/net/e1000/e1000_logs.h > @@ -7,6 +7,9 @@ > >  #include > > +/* included because of RTE_LIBRTE_ETHDEV_DEBUG alias */ > +#include > + >  extern int e1000_logtype_init; > >  #define PMD_INIT_LOG(level, fmt, args...) \ Hi Qi, Can you make a new version with above fix if it makes sense?