From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12022A04A8; Wed, 26 Jan 2022 10:46:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0B854270B; Wed, 26 Jan 2022 10:46:34 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 3C6264069D; Wed, 26 Jan 2022 10:46:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643190393; x=1674726393; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=v8Nai2MWXQndyEILhXREsmyKudK/AWqB7Dg0VM+6vjM=; b=O2fe3yt8gLKRgp6yLKS6hSbcIw4/EnMLpz5bGPbhGfJAip4nRi/j2980 PVwU/RTg5hKlkGR+Je/AqrCC4KbGUZWX+w0xQ92pBESuWnI8vJ6X/q8P0 1pN/6MpxVR7ESK2FJYMpV/ksEMFsbBg5qgdniYGjEtHiApgGgAlDvQ/ff o/q1re6ZjYheOps+JN8k7hIWVBCVgnM/Ve1q7HpDBGqKpb37E+pV3qZR0 AimGxlvrlQCoOKsrz5HSgS/jGLoapBr9G+3Fvv3qEht7Tvj5H3OnhAAsY RDqklPxYqej6TqjELdoSpdyQ+IivpqlnxqXMzITiqNwuF/jpt9QVKh+7/ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10238"; a="246733850" X-IronPort-AV: E=Sophos;i="5.88,317,1635231600"; d="scan'208";a="246733850" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 01:46:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,317,1635231600"; d="scan'208";a="477434516" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 26 Jan 2022 01:46:32 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 26 Jan 2022 01:46:31 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 26 Jan 2022 17:46:24 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2308.020; Wed, 26 Jan 2022 17:46:24 +0800 From: "Zhang, Qi Z" To: "Xu, Rosen" , "Huang, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Tianfei" , "Yigit, Ferruh" Subject: RE: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function Thread-Topic: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function Thread-Index: AQHYEmVtklTGnJtRkUSw4wca72T9y6x0W/+AgACyULA= Date: Wed, 26 Jan 2022 09:46:23 +0000 Message-ID: <0eaf53a27d5343bc91b46d9b033c8017@intel.com> References: <20220126032953.24695-1-wei.huang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xu, Rosen > Sent: Wednesday, January 26, 2022 3:08 PM > To: Huang, Wei ; dev@dpdk.org; Zhang, Qi Z > > Cc: stable@dpdk.org; Zhang, Tianfei ; Yigit, Fer= ruh > > Subject: RE: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function >=20 > Hi, >=20 > > -----Original Message----- > > From: Huang, Wei > > Sent: Wednesday, January 26, 2022 11:30 > > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > > > Cc: stable@dpdk.org; Zhang, Tianfei ; Yigit, > > Ferruh ; Huang, Wei > > Subject: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function > > > > Use rte_dev_remove() to replace rte_rawdev_pmd_release() in > > ifpga_rawdev_cleanup(), resources occupied by ifpga raw devices such > > as threads can be released correctly. > > > > Fixes: f724a802 ("raw/ifpga: add miscellaneous APIs") > > > > Signed-off-by: Wei Huang > > --- > > drivers/raw/ifpga/ifpga_rawdev.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > > b/drivers/raw/ifpga/ifpga_rawdev.c > > index fdf3c23..88c38aa 100644 > > --- a/drivers/raw/ifpga/ifpga_rawdev.c > > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > > @@ -1787,12 +1787,14 @@ int ifpga_rawdev_partial_reconfigure(struct > > rte_rawdev *dev, int port, void ifpga_rawdev_cleanup(void) { > > struct ifpga_rawdev *dev; > > + struct rte_rawdev *rdev; > > unsigned int i; > > > > for (i =3D 0; i < IFPGA_RAWDEV_NUM; i++) { > > dev =3D &ifpga_rawdevices[i]; > > if (dev->rawdev) { > > - rte_rawdev_pmd_release(dev->rawdev); > > + rdev =3D dev->rawdev; > > + rte_dev_remove(rdev->device); > > dev->rawdev =3D NULL; > > } > > } > > -- > > 1.8.3.1 >=20 > Acked-by: Rosen Xu Applied to dpdk-next-net-intel. Thanks Qi