* [dpdk-dev] [PATCH] app/testbbdev: fix sprintf with snprintf
@ 2019-02-04 7:15 Pallantla Poornima
2019-02-08 14:13 ` Ferruh Yigit
2019-02-11 13:35 ` Mokhtar, Amr
0 siblings, 2 replies; 4+ messages in thread
From: Pallantla Poornima @ 2019-02-04 7:15 UTC (permalink / raw)
To: dev; +Cc: reshma.pattan, amr.mokhtar, Pallantla Poornima, stable
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: f714a18885 ("app/testbbdev: add test application for bbdev")
Cc: stable@dpdk.org
Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
---
app/test-bbdev/test_bbdev.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/test-bbdev/test_bbdev.c b/app/test-bbdev/test_bbdev.c
index a914817bc..b9fc750d3 100644
--- a/app/test-bbdev/test_bbdev.c
+++ b/app/test-bbdev/test_bbdev.c
@@ -788,14 +788,14 @@ test_bbdev_driver_init(void)
/* Initialize the maximum amount of devices */
do {
- sprintf(name_tmp, "%s%i", "name_", num_devs);
+ snprintf(name_tmp, sizeof(name_tmp), "%s%i", "name_", num_devs);
dev2 = rte_bbdev_allocate(name_tmp);
TEST_ASSERT(dev2 != NULL,
"Failed to initialize bbdev driver");
++num_devs;
} while (num_devs < (RTE_BBDEV_MAX_DEVS - 1));
- sprintf(name_tmp, "%s%i", "name_", num_devs);
+ snprintf(name_tmp, sizeof(name_tmp), "%s%i", "name_", num_devs);
dev2 = rte_bbdev_allocate(name_tmp);
TEST_ASSERT(dev2 == NULL, "Failed to initialize bbdev driver number %d "
"more drivers than RTE_BBDEV_MAX_DEVS: %d ", num_devs,
@@ -804,7 +804,7 @@ test_bbdev_driver_init(void)
num_devs--;
while (num_devs >= num_devs_tmp) {
- sprintf(name_tmp, "%s%i", "name_", num_devs);
+ snprintf(name_tmp, sizeof(name_tmp), "%s%i", "name_", num_devs);
dev2 = rte_bbdev_get_named_dev(name_tmp);
TEST_ASSERT_SUCCESS(rte_bbdev_release(dev2),
"Failed to uninitialize bbdev driver %s ",
@@ -825,7 +825,7 @@ test_bbdev_driver_init(void)
TEST_ASSERT_FAIL(rte_bbdev_release(NULL),
"Failed to uninitialize bbdev driver with NULL bbdev");
- sprintf(name_tmp, "%s", "invalid_name");
+ snprintf(name_tmp, sizeof(name_tmp), "%s", "invalid_name");
dev2 = rte_bbdev_get_named_dev(name_tmp);
TEST_ASSERT_FAIL(rte_bbdev_release(dev2),
"Failed to uninitialize bbdev driver with invalid name");
--
2.17.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] app/testbbdev: fix sprintf with snprintf
2019-02-04 7:15 [dpdk-dev] [PATCH] app/testbbdev: fix sprintf with snprintf Pallantla Poornima
@ 2019-02-08 14:13 ` Ferruh Yigit
[not found] ` <7AE31235A30B41498D1C31348DC858BD5B533CD2@IRSMSX103.ger.corp.intel.com>
2019-02-11 13:35 ` Mokhtar, Amr
1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2019-02-08 14:13 UTC (permalink / raw)
To: Pallantla Poornima, dev; +Cc: reshma.pattan, amr.mokhtar, stable
On 2/4/2019 7:15 AM, Pallantla Poornima wrote:
> @@ -825,7 +825,7 @@
>
> test_bbdev_driver_init(void)
>
> TEST_ASSERT_FAIL(rte_bbdev_release(NULL),
> "Failed to uninitialize bbdev driver with NULL bbdev");
> - sprintf(name_tmp, "%s", "invalid_name");
> + snprintf(name_tmp, sizeof(name_tmp), "%s", "invalid_name");
> dev2 = rte_bbdev_get_named_dev(name_tmp);
> TEST_ASSERT_FAIL(rte_bbdev_release(dev2),
> "Failed to uninitialize bbdev driver with invalid name");
Can use strlcpy() instead of snprintf() here.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] app/testbbdev: fix sprintf with snprintf
2019-02-04 7:15 [dpdk-dev] [PATCH] app/testbbdev: fix sprintf with snprintf Pallantla Poornima
2019-02-08 14:13 ` Ferruh Yigit
@ 2019-02-11 13:35 ` Mokhtar, Amr
1 sibling, 0 replies; 4+ messages in thread
From: Mokhtar, Amr @ 2019-02-11 13:35 UTC (permalink / raw)
To: Poornima, PallantlaX, dev; +Cc: Pattan, Reshma, stable
> -----Original Message-----
> From: Poornima, PallantlaX
> Sent: Monday 4 February 2019 07:16
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Mokhtar, Amr
> <amr.mokhtar@intel.com>; Poornima, PallantlaX
> <pallantlax.poornima@intel.com>; stable@dpdk.org
> Subject: [PATCH] app/testbbdev: fix sprintf with snprintf
>
> sprintf function is not secure as it doesn't check the length of string.
> More secure function snprintf is used.
>
> Fixes: f714a18885 ("app/testbbdev: add test application for bbdev")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> ---
Acked-by: Amr Mokhtar <amr.mokhtar@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-15 11:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-04 7:15 [dpdk-dev] [PATCH] app/testbbdev: fix sprintf with snprintf Pallantla Poornima
2019-02-08 14:13 ` Ferruh Yigit
[not found] ` <7AE31235A30B41498D1C31348DC858BD5B533CD2@IRSMSX103.ger.corp.intel.com>
2019-02-15 11:30 ` Mokhtar, Amr
2019-02-11 13:35 ` Mokhtar, Amr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).