DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/virtio: fix memory leak in dev close
@ 2021-07-25  2:03 Gaoxiang Liu
  2021-07-26  8:42 ` Xia, Chenbo
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Gaoxiang Liu @ 2021-07-25  2:03 UTC (permalink / raw)
  To: Maxime Coquelin, Chenbo Xia; +Cc: dev, liugaoxiang, Gaoxiang Liu

Free the "intr_handle" memory in virtio_user_dev_uninit() to
avoid memory leak.
when virtio user dev closes, the "intr_handle" memory is not freeed
that is alloced in virtio_user_fill_intr_handle().

Fixes: 7f468b2ebfad ("net/virtio: release port upon close")

Signed-off-by: Gaoxiang Liu <liugaoxiang@huawei.com>
---
 drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index 1cd1e95f4..16c58710d 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -654,6 +654,13 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
 void
 virtio_user_dev_uninit(struct virtio_user_dev *dev)
 {
+	struct rte_eth_dev *eth_dev = &rte_eth_devices[dev->hw.port_id];
+
+	if (eth_dev->intr_handle) {
+		free(eth_dev->intr_handle);
+		eth_dev->intr_handle = NULL;
+	}
+
 	virtio_user_stop_device(dev);
 
 	rte_mem_event_callback_unregister(VIRTIO_USER_MEM_EVENT_CLB_NAME, dev);
-- 
2.32.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-07-28  6:51 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-25  2:03 [dpdk-dev] [PATCH] net/virtio: fix memory leak in dev close Gaoxiang Liu
2021-07-26  8:42 ` Xia, Chenbo
2021-07-26 11:38   ` 刘高翔
2021-07-26 11:59 ` [dpdk-dev] [PATCH] net/virtio: fix memory leak of interrupt handle Gaoxiang Liu
2021-07-26 12:54   ` Maxime Coquelin
2021-07-26 14:42 ` Gaoxiang Liu
2021-07-27  1:52   ` Xia, Chenbo
2021-07-27  1:54     ` Xia, Chenbo
2021-07-28  6:51   ` Xia, Chenbo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).