From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9D835A48F for ; Mon, 15 Jan 2018 16:33:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2018 07:33:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,364,1511856000"; d="scan'208";a="195701531" Received: from jguo15x-mobl3.ccr.corp.intel.com (HELO [10.255.24.67]) ([10.255.24.67]) by fmsmga006.fm.intel.com with ESMTP; 15 Jan 2018 07:33:50 -0800 To: Thomas Monjalon References: <1515575544-2141-3-git-send-email-jia.guo@intel.com> <5621685.YHClJoWfgs@xps> <3360990.PGMcgsB7sd@xps> Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com, konstantin.ananyev@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, jingjing.wu@intel.com, helin.zhang@intel.com, motih@mellanox.com From: "Guo, Jia" Message-ID: <0ebf34d6-aae4-6646-dd72-75d6c18dcb5d@intel.com> Date: Mon, 15 Jan 2018 23:33:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <3360990.PGMcgsB7sd@xps> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH V10 2/2] eal: add uevent pass and process function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 15:33:54 -0000 On 1/15/2018 7:29 PM, Thomas Monjalon wrote: > 15/01/2018 11:52, Guo, Jia: >> On 1/15/2018 7:24 AM, Thomas Monjalon wrote: >>> 11/01/2018 15:05, Jeff Guo: >>>> +enum rte_dev_subsystem { >>>> + RTE_DEV_SUBSYSTEM_UIO, >>>> + RTE_DEV_SUBSYSTEM_VFIO, >>>> + RTE_DEV_SUBSYSTEM_PCI, >>>> + RTE_DEV_SUBSYSTEM_MAX >>>> +}; >>> I don't think PCI and UIO/VFIO should be described at the same level. >>> Can you re-use the enum rte_kernel_driver? >> rte_kernel_driver might be not qualify for that use, since that is the event sumsystem, it include pci/uio/vfio, such strings to identify each subsystem. i will modify it to be rte_dev_event_subsystem. >> >> I don't understand this classification. >> A device can be both PCI and VFIO. yes , i think that might be a little strange, but what i saw in the uevent message is that , the item of subsystem info from kernel side is pci sometimes, but some time is uio, i don't know if it is good to defferentiy them by "subsystem " or "driver" or other. let me think about it more.