DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>,
	dev@dpdk.org, Zhihong Wang <zhihong.wang@intel.com>,
	Cunming Liang <cunming.liang@intel.com>,
	Tiwei Bie <tiwei.bie@intel.com>
Cc: James R Harris <james.r.harris@intel.com>,
	Changpeng Liu <changpeng.liu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] vhost: add external message handling callbacks to the public API
Date: Mon, 21 Jan 2019 09:25:37 +0100	[thread overview]
Message-ID: <0ecaf267-dd48-3ec5-c6dd-f23c802d160b@redhat.com> (raw)
In-Reply-To: <20190117153226.72792-1-dariusz.stojaczyk@intel.com>



On 1/17/19 4:32 PM, Darek Stojaczyk wrote:
> External message callbacks are used e.g. by vhost crypto
> to parse crypto-specific vhost-user messages.
> 
> We are now publishing the API to register those callbacks,
> so that other backends outside of DPDK can use them as well.
> 
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>   lib/librte_vhost/rte_vhost.h           |  69 ++++++++++++++
>   lib/librte_vhost/rte_vhost_version.map |   1 +
>   lib/librte_vhost/vhost.c               |  13 +++
>   lib/librte_vhost/vhost.h               |  54 +----------
>   lib/librte_vhost/vhost_crypto.c        |  12 +--
>   lib/librte_vhost/vhost_user.c          | 123 +++++++++++++------------
>   6 files changed, 153 insertions(+), 119 deletions(-)
> 


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I'll apply it however only for v19.05 because API changes should
be submitted early in the release cycle (before -rc1, -rc2 at he
latest).

Thanks!
Maxime

  reply	other threads:[~2019-01-21  8:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  4:28 [dpdk-dev] [PATCH v2] " Darek Stojaczyk
2019-01-15 11:22 ` Tiwei Bie
2019-01-16 12:22   ` Stojaczyk, Dariusz
2019-01-17 15:32 ` [dpdk-dev] [PATCH v3] " Darek Stojaczyk
2019-01-21  8:25   ` Maxime Coquelin [this message]
2019-02-08 18:04   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ecaf267-dd48-3ec5-c6dd-f23c802d160b@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=changpeng.liu@intel.com \
    --cc=cunming.liang@intel.com \
    --cc=dariusz.stojaczyk@intel.com \
    --cc=dev@dpdk.org \
    --cc=james.r.harris@intel.com \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).