From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0F809324D for ; Mon, 21 Jan 2019 09:25:46 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0EF38C0C8CF2; Mon, 21 Jan 2019 08:25:45 +0000 (UTC) Received: from [10.36.112.30] (ovpn-112-30.ams2.redhat.com [10.36.112.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 602A96246A; Mon, 21 Jan 2019 08:25:41 +0000 (UTC) To: Darek Stojaczyk , dev@dpdk.org, Zhihong Wang , Cunming Liang , Tiwei Bie Cc: James R Harris , Changpeng Liu References: <20190114042829.24499-1-dariusz.stojaczyk@intel.com> <20190117153226.72792-1-dariusz.stojaczyk@intel.com> From: Maxime Coquelin Message-ID: <0ecaf267-dd48-3ec5-c6dd-f23c802d160b@redhat.com> Date: Mon, 21 Jan 2019 09:25:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190117153226.72792-1-dariusz.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 21 Jan 2019 08:25:45 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3] vhost: add external message handling callbacks to the public API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 08:25:46 -0000 On 1/17/19 4:32 PM, Darek Stojaczyk wrote: > External message callbacks are used e.g. by vhost crypto > to parse crypto-specific vhost-user messages. > > We are now publishing the API to register those callbacks, > so that other backends outside of DPDK can use them as well. > > Signed-off-by: Darek Stojaczyk > Reviewed-by: Tiwei Bie > --- > lib/librte_vhost/rte_vhost.h | 69 ++++++++++++++ > lib/librte_vhost/rte_vhost_version.map | 1 + > lib/librte_vhost/vhost.c | 13 +++ > lib/librte_vhost/vhost.h | 54 +---------- > lib/librte_vhost/vhost_crypto.c | 12 +-- > lib/librte_vhost/vhost_user.c | 123 +++++++++++++------------ > 6 files changed, 153 insertions(+), 119 deletions(-) > Reviewed-by: Maxime Coquelin I'll apply it however only for v19.05 because API changes should be submitted early in the release cycle (before -rc1, -rc2 at he latest). Thanks! Maxime