From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"Ruifeng.Wang@arm.com" <Ruifeng.Wang@arm.com>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC PATCH v1] config/arm: fix native machine args
Date: Tue, 2 Feb 2021 07:40:51 +0000 [thread overview]
Message-ID: <0ecee49ca53d44feab211ec7f11df865@pantheon.tech> (raw)
In-Reply-To: <84853387.Bgvu03jNn4@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, February 1, 2021 4:16 PM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: bruce.richardson@intel.com; Ruifeng.Wang@arm.com;
> Honnappa.Nagarahalli@arm.com; jerinjacobk@gmail.com;
> ferruh.yigit@intel.com; dev@dpdk.org
> Subject: Re: [RFC PATCH v1] config/arm: fix native machine args
>
> 01/02/2021 15:55, Juraj Linkeš:
> > There are compiler issues when building with -mcpu=native with popular
> > compilers, such as GCC-8.4 and clang (which doesn't define
> > __ARM_FEATURE_ATOMIC).
>
> What are the issues? Maybe worth pasting a log.
>
I can include this in the commit log from GCC-8.4 (the same thing works with GCC-10.2):
In file included from ../lib/librte_eal/arm/include/rte_vect.h:11,
from ../lib/librte_net/net_crc_neon.c:10:
../lib/librte_net/net_crc_neon.c: In function ‘crcr32_folding_round’:
/usr/lib/gcc/aarch64-linux-gnu/8/include/arm_neon.h:26094:1: error: inlining failed in call to always_inline ‘vmull_p64’: target specific option mismatch
vmull_p64 (poly64_t a, poly64_t b)
^~~~~~~~~
../lib/librte_net/net_crc_neon.c:50:20: note: called from here
uint64x2_t tmp1 = vreinterpretq_u64_p128(vmull_p64(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vgetq_lane_p64(vreinterpretq_p64_u64(fold), 0),
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vgetq_lane_p64(vreinterpretq_p64_u64(precomp), 1)));
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
And for clang:
gcc -E -dM -mcpu="native" - < /dev/null | grep __ARM_FEATURE_ATOMICS
#define __ARM_FEATURE_ATOMICS 1 # gcc support
clang-9 -E -dM -mcpu="native" - < /dev/null | grep __ARM_FEATURE_ATOMICS
<no output> # clang no support
> > Fix this by always specifying the proper machine args and never using
> > the native flags.
>
> The title says "fix" but it seems to be "remove".
Yes. The fix is to remove the usage of native flags and instead always use the part_number flags.
>
> [...]
> > -native_machine_args = ['-mcpu=native']
>
> This is the culprit?
> Could you provide a "Fixes:" line?
There already is one:
Fixes: 78ac8eac7e8a ("config/arm: use native machine build arguments")
>
>
next prev parent reply other threads:[~2021-02-02 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 14:55 Juraj Linkeš
2021-02-01 15:16 ` Thomas Monjalon
2021-02-02 7:40 ` Juraj Linkeš [this message]
2021-02-02 9:05 ` [dpdk-dev] [RFC PATCH v2] config/arm: replace " Juraj Linkeš
2021-02-02 9:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ecee49ca53d44feab211ec7f11df865@pantheon.tech \
--to=juraj.linkes@pantheon.tech \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).