DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Guo, Jia" <jia.guo@intel.com>,
	Prateek Agarwal <pratekag@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d...
Date: Mon, 9 Nov 2020 17:44:06 +0000
Message-ID: <0ed1c11c-095b-4f98-9074-a82e3abba900@intel.com> (raw)
In-Reply-To: <c7d3c2b4d99648a2b409bba1f2367da4@intel.com>

On 11/9/2020 9:49 AM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Guo, Jia
>> Sent: Monday, November 9, 2020 2:24 PM
>> To: Prateek Agarwal <pratekag@gmail.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern
>> "C". Library headers work directly in cpp code. Linking errors thrown due to the
>> absence of this change in i40e pmd header does not help in resolving the
>> problem. I needed this header d...
>>
>> Hi, Agarwal
>>
>>> -----Original Message-----
>>> From: Prateek Agarwal <pratekag@gmail.com>
>>> Sent: Saturday, November 7, 2020 5:01 PM
>>> To: Guo, Jia <jia.guo@intel.com>
>>> Cc: dev@dpdk.org; Prateek Agarwal <pratekag@gmail.com>
>>> Subject: [PATCH] Made i40 header CPP compatible using extern "C".
>>> Library headers work directly in cpp code. Linking errors thrown due
>>> to the absence of this change in i40e pmd header does not help in
>>> resolving the problem. I needed this header directly to use...
>>>
>>
>> Obviously that is not you want to merge the title and the commit log. Please
>> separate it and update one new version.
> 
> 
> Fixed the format during merge as below
> 
> net/i40e: add extern "C" for cpp compile
> 
> Add extern "C" in rte_pmd_i40e.h when be compiled with cpp.
> 
> Applied to dpdk-next-net-intel.
> 

Hi Prateek,

In the git history, we have your name as:
"Prateek Agarwal <prateekag@cse.iitb.ac.in>"

We are trying to keep authors unique in the git history, as much as possible, 
will be OK to continue with the one in the git history?

  reply	other threads:[~2020-11-09 17:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09  6:24 [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header directly to us Guo, Jia
2020-11-09  9:49 ` [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d Zhang, Qi Z
2020-11-09 17:44   ` Ferruh Yigit [this message]
2020-11-10 12:44     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ed1c11c-095b-4f98-9074-a82e3abba900@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    --cc=pratekag@gmail.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git