From: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Wiles, Keith" <keith.wiles@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ophir Munk <ophirmu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
Pascal Mazon <pascal.mazon@6wind.com>,
Olga Shern <olgas@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file
Date: Thu, 23 Aug 2018 13:09:50 +0100 [thread overview]
Message-ID: <0f1ec67b-58f1-98ab-74bb-24e7f65f0d36@intel.com> (raw)
In-Reply-To: <09D1AFC9-52F2-49D6-A54B-76F8FCFB383F@intel.com>
On 7/5/2018 1:34 PM, Wiles, Keith wrote:
>
>
>> On Jul 4, 2018, at 3:11 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
>>
>> 04/07/2018 21:47, Ferruh Yigit:
>>> On 6/12/2018 3:02 PM, Ophir Munk wrote:
>>>> Please note that other than cloning iproute2 we also need to install clang and llvm tools versions 3.7 and upper.
>>>> Not sure there are clang and llvm packages of the required versions for the common distributions.
>>>> I compiled the tools source code and installed them manually.
>>>
>>> Hi Keith, Thomas,
>>>
>>> What do you suggest on this patch?
>>>
>>> The "tap_bpf_program.c" is already withing the tap pmd this patch improves the
>>> doc about how to compile it, although it may not be so user friendly as Keith
>>> pointed, I believe better to get doc improvement here.
>>>
>>> And there is a code update "+#include "bpf_api.h", which includes a iproute2
>>> header, I am not sure about this one and how to manage this dependency.
>>
>> If you feel it needs some improvement, we can postpone it for 18.11.
>> The most important is to have a patch to reference when somebody asks.
>>
>> It can be improved and merged later, no pressure.
>
> I agree.
Hi Ophir,
Are you planning a new version of patch for this release?
Thanks,
ferruh
prev parent reply other threads:[~2018-08-23 12:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 16:06 Ophir Munk
[not found] ` <A1755B7A-CDB5-4A55-9B44-9C9DEFDA9C88@intel.com>
2018-06-12 12:26 ` Thomas Monjalon
2018-06-12 12:36 ` Wiles, Keith
2018-06-12 12:58 ` Thomas Monjalon
2018-06-12 13:33 ` Wiles, Keith
2018-06-12 13:44 ` Thomas Monjalon
2018-06-12 13:52 ` Wiles, Keith
2018-06-12 14:02 ` Ophir Munk
2018-07-04 19:47 ` Ferruh Yigit
2018-07-04 20:11 ` Thomas Monjalon
2018-07-05 12:34 ` Wiles, Keith
2018-08-23 12:09 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f1ec67b-58f1-98ab-74bb-24e7f65f0d36@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=pascal.mazon@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).