From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 107E2A04FF; Tue, 22 Mar 2022 10:12:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A34B6427ED; Tue, 22 Mar 2022 10:12:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8835A410E5 for ; Tue, 22 Mar 2022 10:12:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647940374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wsc3Bzut5R5ydGhCzBVPpVPK41mzGiqzchpqi8L8uC0=; b=d+AN7RpUiIOV9uHRjL511YJNMNlLJTKhl7gkb4X1M+uxS4dP7qj7CmZj4jih7ndLu98eek na/97qwBpnbgcBGlxZ7776lREo1k+gsOHstzOaWTTnfJq92gEHkAYG7CjUUML/3SmFqNpr 6sV+VK1pn4JAuLwtJGkKxV1fNnExaiQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-312-dyGcRI4dN4uDSWXTX5JfJg-1; Tue, 22 Mar 2022 05:12:53 -0400 X-MC-Unique: dyGcRI4dN4uDSWXTX5JfJg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9A3EC100B8EA; Tue, 22 Mar 2022 09:12:52 +0000 (UTC) Received: from [10.39.208.2] (unknown [10.39.208.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B44F4112132C; Tue, 22 Mar 2022 09:12:51 +0000 (UTC) Message-ID: <0f399057-6a7f-1d7c-dbae-4d07b0f80786@redhat.com> Date: Tue, 22 Mar 2022 10:12:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 02/15] vhost: add vdpa ops for blk device To: Andy Pei , dev@dpdk.org Cc: chenbo.xia@intel.com, gang.cao@intel.com, changpeng.liu@intel.com References: <1643093258-47258-2-git-send-email-andy.pei@intel.com> <1643425417-215270-1-git-send-email-andy.pei@intel.com> <1643425417-215270-3-git-send-email-andy.pei@intel.com> From: Maxime Coquelin In-Reply-To: <1643425417-215270-3-git-send-email-andy.pei@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/29/22 04:03, Andy Pei wrote: > Get_config and set_config are necessary ops for blk device. > Add get_config and set_config ops to vdpa ops. > > Signed-off-by: Andy Pei > --- > lib/vhost/vdpa_driver.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/lib/vhost/vdpa_driver.h b/lib/vhost/vdpa_driver.h > index fc2d6ac..9a23db9 100644 > --- a/lib/vhost/vdpa_driver.h > +++ b/lib/vhost/vdpa_driver.h > @@ -65,8 +65,12 @@ struct rte_vdpa_dev_ops { > /** Reset statistics of the queue */ > int (*reset_stats)(struct rte_vdpa_device *dev, int qid); > > - /** Reserved for future extension */ > - void *reserved[2]; > + /** Get the device configuration space */ > + int (*get_config)(int vid, uint8_t *config, uint32_t len); > + > + /** Set the device configuration space */ > + int (*set_config)(int vid, uint8_t *config, uint32_t offset, > + uint32_t size, uint32_t flags); > }; > > /** Reviewed-by: Maxime Coquelin Thanks, Maxime