From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC869428E7; Fri, 7 Apr 2023 19:08:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 59DED40E03; Fri, 7 Apr 2023 19:08:12 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2081.outbound.protection.outlook.com [40.107.93.81]) by mails.dpdk.org (Postfix) with ESMTP id C70AB40150; Fri, 7 Apr 2023 19:08:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mMJ8ntsnpT1YIB+m2MOVDpdqC9dN9B8SazT1MFcPRMYePcZltwzkepsYmI5Z8cwigqSTF+fECnRvHgHucxIy2T5uV/uu2LB+lL2K8XzKHtnsAhhn+N7JtmGgHa8r7PRvMlnERdUQFXKnY76e13SXnBJq8TxcNY5WvwboccA04gOFf/YK7nua3FHIs4IDdRNYSLqDSg4vDQWjfGX+HBFMcAw7AcyS9URfvx854AiCQcal76jsUhL8hdyqPIwxU6J7kYEjc8SIFE2tEblV9xVLBoVMpzZTii+PLXHmCUprvqad7tF9W6PIQPLgLvnMkTxTZzUHX5unDqrhZkk9ffWjqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f7jNRswfo7OFlucxH5QLRsTmIkItW0qSB2KENPaycJM=; b=YNGNxSdqvFwavbuHOLm0y0N927hpxgQUWFOUmWVuDuOosma2qbA6pppcIJhM43AqrSzPyHmL703I0oyg7Qs9cX7itKzLOIXSlf2V7es+Wp2fEKppa5X4CPslRINRD7S2g9JvRLSNXlBbkM3cHq1gQRfWaUuwem+2V4otTrG89DKfYNvwaCdy9GRnZcEKmQY3MzdSECDcfPzaOSvEcbVWB5qRUQ/pDAKNiRe7gNPwcf7WFIzYU742DsOBCHU30oiLM7dHuWDASF6ffgajd/YKVgZfOeACu+HNgMzw17EyQA3UGTnXbCbyLk1LR0siy/3je4qEZV3P0CnV6hishoyFtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f7jNRswfo7OFlucxH5QLRsTmIkItW0qSB2KENPaycJM=; b=zKMwx0/MLO62RbJmjf5zzHU2VOi6N/FShTgLQ+f5gLNaboE85QpG2fV25F586Eh7L+rCuPenjbEYAETAnGxJbQ7lwsWroWSySFcMjyErroFWkjFLo77zS4J3Gaseq7qNcCzDywQJKSHq7NeEmeQxoKCIK8UmQKwmlMPeBRhmgg4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4354.namprd12.prod.outlook.com (2603:10b6:5:28f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Fri, 7 Apr 2023 17:08:08 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::5e2c:c0ed:88a6:a4c7]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::5e2c:c0ed:88a6:a4c7%6]) with mapi id 15.20.6277.034; Fri, 7 Apr 2023 17:08:08 +0000 Message-ID: <0f41fcd2-eee0-4eb4-b9d2-045f917f009a@amd.com> Date: Fri, 7 Apr 2023 18:08:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: Dongdong Liu , jerinj@marvell.com, dev@dpdk.org, Yisen Zhuang , Huisong Li , "Min Hu (Connor)" Cc: thomas@monjalon.net, david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru, stable@dpdk.org References: <20230404065525.3313249-1-jerinj@marvell.com> <9edb30d6-e4c7-3c72-d95a-e46eb486886b@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH] net/hns3: fix build warning In-Reply-To: <9edb30d6-e4c7-3c72-d95a-e46eb486886b@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0154.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4354:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cfcf4fa-d449-4695-49bc-08db378aa8f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WrfbXOqc1ySDptS+ZfVh71iChl2+VK8VZNJWUoQyHfh+cAMxw0RGMJfNJZW3M2K5D8RLdteYV6Jm6bdSEP/xb2vs1VM/W+/M+ZB2LRFJ0bXxeDegb3aOCWA1XNet6dpsBOZ1rkAFx6XYNCPDHjKiB8WPoDbnO0OocbW0K++9gPdjWmwTuUmO25sa4z4IAtGUFNnbIwgrrAYPTBwbti8ObqbM5Rmw32deMXLxJ8G9B0n7AfmCBDAiNNYe5elNRmpq7rISfYUsBppV8ASlqVQFs56LC1LQaEHXm1zEZgSyFcBVAiSX139xLAJpNETFtT5QcAXDvjtYWC3iaV6J5fRQOk6oKG61cJ7bd8l+f4Ry0MQ+UpKkq7k4qDFPqbYL7OwMAmCGz7xk8eXFaee46KecBtBGhRNC9OLGeEwD8Wf8CrRYpf+OP4p/GjKLtn5rUPD8X9VUL/tzT0wBz9Bvva0B97XrzUzc76ormhYzB3bL/An8kco62uKvltIOXSinyjWttt3zGvtxy8CMVN0lgN99sjlsQSnNgHtSyPIWmouSCxV8RmyVgxHTDPMqYnUOodSUNU0G/5LxzFODNSMHXf+mOL1d4V52IuxDfW8HAw8c7UOQ326f7lKY9t6YF1R/6xbGpOoAlG3RyGMw4dD0EwVtuA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(366004)(136003)(346002)(376002)(451199021)(44832011)(8936002)(31686004)(41300700001)(4744005)(8676002)(66946007)(38100700002)(66556008)(66476007)(4326008)(110136005)(36756003)(2906002)(31696002)(5660300002)(478600001)(6486002)(7416002)(6512007)(6506007)(26005)(316002)(53546011)(186003)(6666004)(86362001)(2616005)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3BMZjNDSGtDTXFTbndJS243UkpwUzZ2QVhWSVFNMkJHeUxKS2xLRGVMeUxo?= =?utf-8?B?Mml1ZjFFemtjQ2ZWWU1jRUFHQk5YckdBbTdqcFBRR0o2QnBYUzkydU11SGZH?= =?utf-8?B?d1pHRjVUejBPczAzYis4V0lGMlM2bEp1MlRGaXMrS2dkQXY4bVcwUGx2bGMx?= =?utf-8?B?TXYxRjI0RmIvOGE3K041L01RbzFoNjRtalpIclFyREIyL3plOFZuRHZmT0lY?= =?utf-8?B?eGt5TWY1bnkrdCtwcFFtL0d1YVNqdFlDS3ZtaFE3aFcrQlF5WWs1MWFyS0xE?= =?utf-8?B?Y0R0Vk9kRDU4U2ozTE5sT0N1UjZiM293SFAxSkN3ZmJEWFFWZUtpSXZRN0JL?= =?utf-8?B?dDkzVGxUZEs2TW5BdnJyMGNZWDVKd0RVQU9tdEVZZEdLcllQakQ2SE5BQlQ2?= =?utf-8?B?VWwwMVpldjdXVDVyVEhhb005U2ZTU0xBdXU1MVNMWVZ2V1g4Rzl5VnNIK1JX?= =?utf-8?B?ZldXK1hTWnZ2eW1EUVcraTMvTG5uL0lScjJ6T1VMd0M1Q2cvTWpsNzRYUjhZ?= =?utf-8?B?NklrTjRkU3dxcGxsbmg4eUFyUmFPemR2QXQ1WkcrVXhGZlh5a1JMckwrWDlJ?= =?utf-8?B?T0M4em9mY1lsZCtHUWhINWhmaVB3OEJ5MnAwSTFIY2VVTld3bUxGVUZPVTdD?= =?utf-8?B?RWlqZ0pwd1o2VDdrL0w4dlZxWFZjTUZQaDNyU3NEQ0xkcnFXRFZCTTFhUUox?= =?utf-8?B?SmpMMHAyVjdjbDN5NUZsUmpqSjE2VEtQL2ZZVEdnaWFrWVRicGVCdG8zT2ND?= =?utf-8?B?bEZxaFRXMitQcHBGS2RFRDRKTFJoMkhGTG5NbHBOVllMTWJFU3A5bElvRVZn?= =?utf-8?B?d25sdEErNEJnb01nMlV4d21lZWdLbURGaHZxczRjc2p6d1AzanFUYm1FUHht?= =?utf-8?B?Wms1TmozS1h6MEdnT0xsMDcrQnp0UU1lM2RBTzJRVGg1Q3BlQ0RsNEFZWDlJ?= =?utf-8?B?ZjA1ZHlpY1JQakZvRGJpRUY3VGlWQ2JiM1JPVjhrMUNDZVQxeE5mbUp4QTZK?= =?utf-8?B?aTl0VExIK1lLZzdqTi9Qdk1mYzRTWFJtLzhKQXA5MTcweUtnMXYxS2l3RUZT?= =?utf-8?B?K0xKdUFWVnZDclB1cmlORmI5VjFwSUh3b01QV1hINTJxdm9WNmtCRC9IY3pJ?= =?utf-8?B?QnRqKy9uamFXU3hlN21DZWoveEhvYzZ2a1lKN0k3aXUwaG5Nc3V3Rm9oYzlB?= =?utf-8?B?MGZzbTVqRkRpWGVHdm9Pak5LLy9sVWJzbkZGcDFCNmpZOFZORS9sRlpXcjAx?= =?utf-8?B?YjJ1ZDQ3blpEcG5zc1dydjFTVHN3SmJQVXRhR1dHdmw3VlZmK0Z5U1VrT0xE?= =?utf-8?B?a0VBMlFEbGM0UThJREZBdmJ4ZHc4akdZdkc2MjNIRlhWd3JHK1g0WVNBVkR1?= =?utf-8?B?VTFPU2RVUUM2aHBNdG4wamZKOVB2N3lOQ205YmFNSmVMS0FlaGlnS2V3ajJl?= =?utf-8?B?aUIvZVdMOU83c09QbVFWRzcrVDY4WWlvT1RHN0tLa1MrcjFCVFpaRi9iYk43?= =?utf-8?B?K0VDMERSbW1udmY0TWEwYkxWSzhvaXFFR2ptb3NESTE3QmdweGRIMFpoeE1M?= =?utf-8?B?KzU1bGUzbG9ic0grL0tLUk9sRnRIblBBV1pITjU5SUdSTm5kYk53eEtDRTBQ?= =?utf-8?B?eWswa1BPTGF6SjVlbWRsekhPVnhkQmlZbG50ME5UUTN2RmR5L1lEMzhXWFli?= =?utf-8?B?TEpPY2QzUi96UkxVZGhuQjBlcEVDM0tFNU1PbkN6NU96V3FWcWpvUFpZK3hZ?= =?utf-8?B?bGJFamc1eXJWQUk2aEgyQWNJaUxDeUV1Nm02RHNvNEdMNndqRjRXeUpSRlZ5?= =?utf-8?B?RGFzY1IxbThBYkNQTS9iVmlVN05qNTQ5WForTlNkVkFEYzQ0QmdEMVNCWHo4?= =?utf-8?B?UElCUG5MZ0R6aGZLQVF1b0ZDZTdGYkYwdGc5Kzc4b3U5VmtNaVJBa1YzSmlY?= =?utf-8?B?bVVoL2htMnYwUVM5dER5MHJTNXBBSUk1VnEyaFloRFJ4SWZaRDZDUHpyWk5C?= =?utf-8?B?RXppWUh4cHJWT0pPcVVRdFd4bEQrTFlmSnF5RHVoT1NTelRQRHN1RmxkU1F1?= =?utf-8?B?c0N1VUUzQmdJZitmVVE5aVpqb1ZrejFkTzRtZUF6VnpiV25aN0RYWXB2Ukha?= =?utf-8?Q?qldIqKEsp+p1+7Xe3ryI/ubwn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cfcf4fa-d449-4695-49bc-08db378aa8f9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2023 17:08:08.6775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vj8UDZlDBL1ryvZ4xdXZPxxDkC7wIy3U3UWhuqJejRoFtXpP+7iiE8V1IBjusMjW X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4354 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/4/2023 9:22 AM, Dongdong Liu wrote: > Hi Jerin > > Many thanks for fixing the warning. > On 2023/4/4 14:55, jerinj@marvell.com wrote: >> From: Jerin Jacob >> >> aarch64 gcc 12.2.0 build complain with below warning[1]. >> Move the new_link initialization upwards to fix the warning. >> >> Compiling C object >> drivers/libtmp_rte_net_hns3.a.p/net_hns3_hns3_ethdev.c.o >> drivers/net/hns3/hns3_ethdev.c: In function ‘hns3_dev_link_update’: >> drivers/net/hns3/hns3_ethdev.c:2249:1: warning: ‘new_link’ may be >> used uninitialized [-Wmaybe-uninitialized] > It looks like a false positive from the logic of the code. > Anyway, this warning can be fixed by this patch, so > Acked-by: Dongdong Liu > Agree that it looks false positive. Moving memset upwards does unnecessary memset for some case but this can be OK for control path function. Applied to dpdk-next-net/main, thanks.