From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Sarosh Arif <sarosh.arif@emumba.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5] testpmd: add speed capability in device info
Date: Fri, 9 Oct 2020 10:27:40 +0100 [thread overview]
Message-ID: <0f504a2a-d8ff-5fe2-7cdc-80ee770e6e7e@intel.com> (raw)
In-Reply-To: <20201008182513.369420-1-sarosh.arif@emumba.com>
On 10/8/2020 7:25 PM, Sarosh Arif wrote:
> Called rte_eth_dev_info_get() in testpmd, to get device info
> so that speed capabilities can be printed under "show device info"
>
> Bugzilla ID: 496
> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> ---
> app/test-pmd/config.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 30bee3324..68a7de7cf 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -507,6 +507,46 @@ static int bus_match_all(const struct rte_bus *bus, const void *data)
> return 0;
> }
>
> +static void
> +device_infos_display_speeds(uint32_t speed_capa)
> +{
> + printf("\n\tDevice speed capability:");
> + if (speed_capa == ETH_LINK_SPEED_AUTONEG)
> + printf(" Autonegotiate (all speeds)");
> + if (speed_capa & ETH_LINK_SPEED_FIXED)
> + printf(" Disable autonegotiate (fixed speed) ");
> + if (speed_capa & ETH_LINK_SPEED_10M_HD)
> + printf(" 10 Mbps half-duplex ");
> + if (speed_capa & ETH_LINK_SPEED_10M)
> + printf(" 10 Mbps full-duplex ");
> + if (speed_capa & ETH_LINK_SPEED_100M_HD)
> + printf(" 100 Mbps half-duplex ");
> + if (speed_capa & ETH_LINK_SPEED_100M)
> + printf(" 100 Mbps full-duplex ");
> + if (speed_capa & ETH_LINK_SPEED_1G)
> + printf(" 1 Gbps ");
> + if (speed_capa & ETH_LINK_SPEED_2_5G)
> + printf(" 2.5 Gbps ");
> + if (speed_capa & ETH_LINK_SPEED_5G)
> + printf(" 5 Gbps ");
> + if (speed_capa & ETH_LINK_SPEED_10G)
> + printf(" 10 Gbps ");
> + if (speed_capa & ETH_LINK_SPEED_20G)
> + printf(" 20 Gbps ");
> + if (speed_capa & ETH_LINK_SPEED_25G)
> + printf(" 25 Gbps ");
> + if (speed_capa & ETH_LINK_SPEED_40G)
> + printf(" 40 Gbps ");
> + if (speed_capa & ETH_LINK_SPEED_50G)
> + printf(" 50 Gbps ");
> + if (speed_capa & ETH_LINK_SPEED_56G)
> + printf(" 56 Gbps ");
> + if (speed_capa & ETH_LINK_SPEED_100G)
> + printf(" 100 Gbps ");
> + if (speed_capa & ETH_LINK_SPEED_200G)
> + printf(" 200 Gbps ");
> +}
> +
> void
> device_infos_display(const char *identifier)
> {
> @@ -518,6 +558,7 @@ device_infos_display(const char *identifier)
> struct rte_device *dev;
> struct rte_devargs da;
> portid_t port_id;
> + struct rte_eth_dev_info dev_info;
> char devstr[128];
>
> memset(&da, 0, sizeof(da));
> @@ -569,6 +610,8 @@ device_infos_display(const char *identifier)
> &mac_addr);
> rte_eth_dev_get_name_by_port(port_id, name);
> printf("\n\tDevice name: %s", name);
> + if (rte_eth_dev_info_get(port_id, &dev_info) > 0)
My bad, this should be (rte_eth_dev_info_get(port_id, &dev_info) == 0), I can
fix while merging.
Except from above,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2020-10-09 9:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 6:23 [dpdk-dev] [PATCH] " Sarosh Arif
2020-09-08 8:36 ` Sarosh Arif
2020-09-08 11:55 ` Ferruh Yigit
2020-09-17 15:56 ` Ferruh Yigit
2020-09-21 11:22 ` Sarosh Arif
2020-09-28 10:01 ` [dpdk-dev] [PATCH v2] " Sarosh Arif
2020-10-04 8:51 ` Asaf Penso
2020-10-07 15:30 ` Ferruh Yigit
2020-10-08 11:49 ` [dpdk-dev] [PATCH v3] " Sarosh Arif
2020-10-08 16:14 ` Ferruh Yigit
2020-10-08 18:11 ` [dpdk-dev] [PATCH v4] " Sarosh Arif
2020-10-08 18:25 ` [dpdk-dev] [PATCH v5] " Sarosh Arif
2020-10-09 9:27 ` Ferruh Yigit [this message]
2020-10-09 11:53 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f504a2a-d8ff-5fe2-7cdc-80ee770e6e7e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=sarosh.arif@emumba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).