From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C71FA034F; Fri, 12 Nov 2021 15:30:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E50B8410EA; Fri, 12 Nov 2021 15:30:16 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 12D6A40692 for ; Fri, 12 Nov 2021 15:30:14 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10165"; a="293963074" X-IronPort-AV: E=Sophos;i="5.87,229,1631602800"; d="scan'208";a="293963074" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2021 06:30:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,229,1631602800"; d="scan'208";a="493022840" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 12 Nov 2021 06:30:12 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 12 Nov 2021 06:30:11 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 12 Nov 2021 06:30:11 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 12 Nov 2021 06:30:11 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 12 Nov 2021 06:30:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DBv1/ugmQaQ5DYdUB6egT85Cg6mYB+8XhAhxJSW18m2GjvCg7fkfQISgUFO50i+mL0kroVuYcxbTwAtmWeeLl3kyIPFZk9Dlaub3rHk3iB5Qq7ovUVesl3YlaRMDqkOez6mEL5RBELrOG8Z27YXVKjSBXHclm+ZPLIEG+vWGK+A0/CxwSXTHV/dMy5Rusgh+oZH9AoiXG6tAJa02A0HX27b+n6Jg52bHD+/ADxdpeRy9sqhHK7y//APVdA56yMss1hTbClWUUVKrokhiXYAxbC+3URxCL/ybcAl9MIlldlAbtVCdu0fGMfvr0c/56ddE17gxXgaPlWHkci030keHlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sRcuWsTb5v5DMu2+Ou7GdfeW3tGLXrG2SZxxEOyGQtI=; b=HkvoeRPu2QoQme0OmZUR55oJaLNogBKu5x5Sl281dMUAOKbwP7lAW6alwbAeFSrp22ULce/fg7LUKu5o7pak34+Lp1nZyDat2yQERHblEtcul7SB8uOhJGl4tqF71qQ4PqFD3LQ29MGfgl0iqmavxN7eG3arEN2BkRlWK2bFCuoms+6ZrbUjw7fc1XWMDXRn/pQYbM/3ADUbYCeymJYrD2e9pZyAIzVJ3/cQjEF7mIIFR+LK+6myHEUkx8kC/+0PqEBOljtyA3VLKYC7d1qR4ZkNhx/fFdL0zekuTXzbya9Yd+nJClLQteYPqOGTmP8zUCUOSBHRLL7zzonvbyoFqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sRcuWsTb5v5DMu2+Ou7GdfeW3tGLXrG2SZxxEOyGQtI=; b=S8DlFUm0p9FkQ3F2owTFvpMMXRBDlY5fn192f895nMzAQqaB3yItx40ngWZHA0/lZQ8hJMIWh/j3fLeyEDC6QIhycyb+SqM9lbv2ny7R6MZZ+5bVHdnVe4M4Usu97CnGEbt2yr5FLpWtsraqXt8TVKYA8CoC/yOln2Um9VHPG7w= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB5012.namprd11.prod.outlook.com (2603:10b6:303:90::18) by MWHPR11MB2045.namprd11.prod.outlook.com (2603:10b6:300:29::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Fri, 12 Nov 2021 14:30:07 +0000 Received: from CO1PR11MB5012.namprd11.prod.outlook.com ([fe80::442b:2192:c62b:c6c3]) by CO1PR11MB5012.namprd11.prod.outlook.com ([fe80::442b:2192:c62b:c6c3%9]) with mapi id 15.20.4690.019; Fri, 12 Nov 2021 14:30:07 +0000 Message-ID: <0f722066-1f6b-7730-6b86-6efef829cacf@intel.com> Date: Fri, 12 Nov 2021 15:29:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.3.0 Subject: Re: [PATCH 1/7] app/test: fix unused but set variables Content-Language: en-US To: Conor Walsh , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20211112140111.922171-1-conor.walsh@intel.com> <20211112140111.922171-2-conor.walsh@intel.com> From: "Medvedkin, Vladimir" In-Reply-To: <20211112140111.922171-2-conor.walsh@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0201.eurprd04.prod.outlook.com (2603:10a6:10:28d::26) To CO1PR11MB5012.namprd11.prod.outlook.com (2603:10b6:303:90::18) MIME-Version: 1.0 Received: from [192.198.151.52] (192.198.151.52) by DU2PR04CA0201.eurprd04.prod.outlook.com (2603:10a6:10:28d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Fri, 12 Nov 2021 14:29:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3487f45e-0d04-4ea1-c134-08d9a5e8ecc9 X-MS-TrafficTypeDiagnostic: MWHPR11MB2045: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1332; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T2+gQDWl4+8nVwsLdQWmpLOWVOeraR9KMFQ2q7ty5eTyvhfK8NinpFC8rxsXBrHyYZCt4GYseAKLkul1p00wdJI8Okrj5fV2Rb7CIPsPI47T+lCPDjDMfUkzwruVOnNJFdqyRPGHbEHA8P8dei0Jb+H+q+ikw924tq0JUEfF4E6osCN18qlknH5IER4M+z7B2hjhYfvCkQB06q8pt+hcb6BUv+fo2gojaW7VUi2w7T0dwJ3/W8ad/jt9mKnZ5QXB5H+N1GTN04S7zNc+YR2sjpcE+iSHR4uaBwgn0Kg/3ycu8Dr2LhlbGMvNYKvfNrucjvD3C8ovxpo0YXvwSvnQK5cmdzE3Nl5lWabeVrnMBqngLpca2DwwLJmOhuKSU2mUfR5Hsgs8lGEmCpSL2Z2l5ovrN+D7tpqUwVm/YdYcArCVwFHEP2/iYIIwhJ11+2u3UnNO1KhJ5NlbQP3X32Tq2bzI6BCcxQl9IiBEqhZm6tnac6IuBykC5UO8xyV7kjgb8uYu+sg7GoL70dYd/En46wAgpJWhlkZqxni3U43oW85su1x8jikhzVcz8Fm+kTFzr/7LwSqIrHpUI4OyWpGUsyVuMPrWvrf3G30VSmx/YbpO9hs3D1mlXf58OrD+Yy5gwCwslaQGxAE+MhHq3GGvMMm37fEtNgrSkCYc0OJwynIPNj2FDZviRx/eDT5FYJeap4UuXTzetQNC2RDElJU+Vnv1MqQ19dENokdRnJdlCJ+wOL+kNR3+5nSiL72mqT03t9ckFCgpwAhSE5yX/UyMGQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5012.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(956004)(86362001)(5660300002)(6486002)(2906002)(508600001)(7416002)(8676002)(26005)(7406005)(36756003)(6666004)(31696002)(4326008)(38100700002)(186003)(8936002)(316002)(16576012)(31686004)(66946007)(6706004)(82960400001)(83380400001)(66556008)(66476007)(53546011)(2616005)(107886003)(3940600001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlNyajVyWlFYZXhyQnlrRFpnYUIxVUhLQzFTUmhkMTJWZDVPL2EzRGR4d1Ny?= =?utf-8?B?Q2E1aG1KU2R3OFpscUE0TjhpRTdxdDc5SHFvUUpiSFV0aENnYk4yRUFKTHVS?= =?utf-8?B?dHRKRmMwS010bTJZbzhKVnhGQ092YzZPREZtcGVjWjNjVFlLYURldGd4ZVMw?= =?utf-8?B?eXQ2bTNJTEFTUnhtcHNtWDZmZlZQT0JXWXRQWW5leklXTGtZZEhScTFPeisv?= =?utf-8?B?MTAva1pQTVhlVmZlRkxpeHJsS1RxYjNPQU1GTHRTK3NtbVhMSGJsdHM4Nzk5?= =?utf-8?B?WEdPWGVtVjVFbE5YWXhDSUtpbHgzSFJaY3dDQnpacFM3ZlRBcTBlTzV1eGhS?= =?utf-8?B?eVhiUEtvOG9qTXhBRTVQWG1vZDVUMEZuUEE5bjBuam8ybTNKcTU0Y0VYaTVa?= =?utf-8?B?cm9jcVhZZHFManppU2tRcEo1VkRmcUtSOGVoVWpJRWZQRHZTYnRVOVJyV0gw?= =?utf-8?B?VDhCN2pzMFdST1JoTlh3V1Z6NkthNVVMZnhjSlhMZVBhTHRiZkNySFYxbkp1?= =?utf-8?B?SU5JRXpWRTExWDRGWE03MnYxSmRaeFN0d200alhOTzZqajNEYVl4MXF2V1hw?= =?utf-8?B?RTZIa1g3UkJqZEFkVlJmdVh6ZXpKZElVbTZSbnkyYU5wcXZxelBzWElnYW1E?= =?utf-8?B?cXBZRlFvaUVKbm10UnZVOFFmL0FEa08xRDc4WFl5MlZmd1VqaCtjVlJ5MUdQ?= =?utf-8?B?RTN1SHgzV2JBNC9SOXoyR0ZlRGpyZnFLWGx1RmFodjAwb0EySU4waS8wTGlE?= =?utf-8?B?b1lXZWJrQm5Fb3BDMFJEV0NkQ1c5VFpDQ2t2dHNLc2ZvUmdHS0tpQmpYZUwv?= =?utf-8?B?UHA4Z21RY0FDdUdpeVMvUnc2bG5DWDFGT3JvOXd3SHFUdVZYRWdoTmRlSm82?= =?utf-8?B?djhNZ3YybkpZRTBpRnAxUFNRM2psWHFtczRPRVVMNkMyRExYNlcwODhYSTE3?= =?utf-8?B?NC9xNTJXV3V5M3FNTnAzRjRoYnBGVkVsbGxnWnl4bWFKR0Z0bVQ2ZmllVUZl?= =?utf-8?B?a2tLeG40TW1FejhFSkJaaExiUWNZQ1k0YkFRbEw4YU9qSTNaaFJUU1dYSHFt?= =?utf-8?B?MEtwbkVTZzJTbEt6bzc5elZXdTUyL2lVdW9PNW1FQnlIMWlsUTFwdWpEZFkz?= =?utf-8?B?cHRoYlBuNW1xNURCSnoxMmZ6WkZKV3gyZ0EyR0tIMCtJLzloRUhYTkJLOW5r?= =?utf-8?B?cDdFVUREdVdFWVRIcjkyaGlRV0t1R3VTVFFmcUZ1NWJjT21ueE1GM2s1OU9P?= =?utf-8?B?enJXKzVqODE0S0x0UVpWM05RSThlMzl1clhnYUNGSUpCcm5YMnBUNE5mamth?= =?utf-8?B?NnJjeXNESEYvcmgzOGJNenpaTU1oSjdjakVkU0oxa2ljQ2k4UG1KRHNueU9s?= =?utf-8?B?Mlk3aEtSTTEyUDcxNHZjUkF3bnN3ZEdtalMwSFQ2Ym5UQ044RjdaTjBWdm10?= =?utf-8?B?Tkg0MWFXMEIvc0xJWTMxVERTejZvaC9VVStUbHhBTkt0aGdmOFZHd2wvTTJN?= =?utf-8?B?WDI2SVkwdWIrelFTNDVUTnhTOHpyK3cySjBNdWtkU2NQcXE5dDB3K2JJc1cy?= =?utf-8?B?WW1nZ3d6SDY4cmozQm1PY0dkL2pFV09xaG9LTkY3NUtXdXY3MHpiR25RZTdt?= =?utf-8?B?ZXJOUWdOdVNzeEtzZm1VYURPUFJabit6aGdEK2pJVUVRblhRMndBeUZvWllD?= =?utf-8?B?NllhZStXaW5ZMkJqZ0t2RzFBUklnNnJkOUNjWExYYUZSOHQ1TkxycjIvU2sv?= =?utf-8?B?ZEEvMkx4WG05aXpxQjdwMlYyaWh4cXNQaXJZYldXeTYwdUZSWkE2VVk5UzlS?= =?utf-8?B?ZWNjbTBWKzl4Z3hpNFI5Wk80MWNYMFJDNHRYTHNUWHArelBCcnZLVmVKUldt?= =?utf-8?B?TmRxYnhUSmRhVmdodTQybnhTR2k1UG1jZEM1eWZkc1J2bURScGVjalFPNjIv?= =?utf-8?B?VldyQmZqU3hNNUdWeVFUYmtOakJhbnBHaUgyTUU2dXA4YU9ZbUY4VFd3Zm5Y?= =?utf-8?B?VGdjSzl3aysva2dsZHpJaXlmVkx0bEt5UGdZYlJUU1JFSkdVcUlqNnZIS0x1?= =?utf-8?B?VjlkRjFVcFNoUzNrRHA4bmZpOXBnR0pFNWFZQ09qNHJDRjg1U2VydUlFSlBs?= =?utf-8?B?ejhsaGo5b3pTeHFwSENwUnlMcU1HcnVtUVJqUWljdHU4bG83dXN3c2w1RHVE?= =?utf-8?B?WUYvWWFYUDJVY0lwZlZ4TXp2MTJhU0JRZnd1TmZDNXhIbnV0WjZzUDZBVEwv?= =?utf-8?B?TVhhbTNrN0RTRGYrOHE2MGJvQlBBPT0=?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3487f45e-0d04-4ea1-c134-08d9a5e8ecc9 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5012.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2021 14:30:07.6721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hVPOZsyOPyX4tMU+FXEEwmKRC7AbiwwF9rOrJKjh0Y0brZKzR+hqTct/KuEXp2/mIt9eG/iip6SXEIiRjjwzeh6C4sEFcQEkHNbUWGOpyl0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2045 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/11/2021 15:01, Conor Walsh wrote: > This patch fixes unused but set variables within the following test apps: > - test distributor perf > - test thash perf > > Bugzilla ID: 881 > > Fixes: c0de0eb82e40 ("distributor: switch over to new API") > Fixes: 239fffe0402e ("test/thash: add performance tests for Toeplitz hash") > > Signed-off-by: Conor Walsh > Reported-by: Liang Longfeng > --- > app/test/test_distributor_perf.c | 3 --- > app/test/test_thash_perf.c | 2 ++ > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c > index fdbeae6d2f..92e330f194 100644 > --- a/app/test/test_distributor_perf.c > +++ b/app/test/test_distributor_perf.c > @@ -108,7 +108,6 @@ static int > handle_work(void *arg) > { > struct rte_distributor *d = arg; > - unsigned int count = 0; > unsigned int num = 0; > int i; > unsigned int id = __atomic_fetch_add(&worker_idx, 1, __ATOMIC_RELAXED); > @@ -120,11 +119,9 @@ handle_work(void *arg) > num = rte_distributor_get_pkt(d, id, buf, buf, num); > while (!quit) { > worker_stats[id].handled_packets += num; > - count += num; > num = rte_distributor_get_pkt(d, id, buf, buf, num); > } > worker_stats[id].handled_packets += num; > - count += num; > rte_distributor_return_pkt(d, id, buf, num); > return 0; > } > diff --git a/app/test/test_thash_perf.c b/app/test/test_thash_perf.c > index 7aa9360120..c95785d8bb 100644 > --- a/app/test/test_thash_perf.c > +++ b/app/test/test_thash_perf.c > @@ -61,6 +61,8 @@ run_rss_calc(uint32_t *tuples[BATCH_SZ], enum test_rss_type type, int len, > } > end_tsc = rte_rdtsc_precise(); > > + RTE_SET_USED(hash); > + > return end_tsc - start_tsc; > } > > Acked-by: Vladimir Medvedkin -- Regards, Vladimir