From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B7B76432FA;
	Sat, 11 Nov 2023 04:09:17 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 82D14402A6;
	Sat, 11 Nov 2023 04:09:17 +0100 (CET)
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
 by mails.dpdk.org (Postfix) with ESMTP id C90AF4025C
 for <dev@dpdk.org>; Sat, 11 Nov 2023 04:09:15 +0100 (CET)
Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.55])
 by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SS0v86cTDz1P7lT;
 Sat, 11 Nov 2023 11:05:56 +0800 (CST)
Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com
 (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Sat, 11 Nov
 2023 11:09:10 +0800
Message-ID: <0f72b4ae-7c12-5502-bd47-862ad0e94211@huawei.com>
Date: Sat, 11 Nov 2023 11:09:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] app/testpmd: support config offloads for all ports
To: Ferruh Yigit <ferruh.yigit@amd.com>, Dengdui Huang
 <huangdengdui@huawei.com>, <dev@dpdk.org>
CC: <stephen@networkplumber.org>, <aman.deep.singh@intel.com>,
 <yuying.zhang@intel.com>, <liuyonglong@huawei.com>, <liudongdong3@huawei.com>
References: <20231110091013.1737957-1-huangdengdui@huawei.com>
 <820ded2a-d934-4e3d-91c9-9d76d9294348@amd.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <820ded2a-d934-4e3d-91c9-9d76d9294348@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.121.59]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 kwepemm000004.china.huawei.com (7.193.23.18)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org


在 2023/11/11 10:50, Ferruh Yigit 写道:
> On 11/10/2023 9:10 AM, Dengdui Huang wrote:
>> Support config Rx/Tx offload for all ports in following commands:
>> 1. port config all rx_offload (offloading) (on|off)
>> 2. port config all tx_offload (offloading) (on|off)
>>
>> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
>> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
>>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> <...>
>
>> @@ -11230,6 +11238,79 @@ static cmdline_parse_inst_t cmd_config_per_port_rx_offload = {
>>   	}
>>   };
>>   
>> +/* Enable/Disable a per port offloading */
>>
> Comment needs to be updated for 'all' port, and it may be good to add
> Rx, like:
>
> /* Enable/Disable all port Rx offloading */
>
> Similar comment is for Tx code.

+1

Acked-by: Huisong Li <lihuisong@huawei.com>

>
>
> As this is only a minor change and rest looks good to me, I will update
> while merging.
>
> .