From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD809A0543; Tue, 4 Oct 2022 08:30:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5CFAB40DDC; Tue, 4 Oct 2022 08:30:55 +0200 (CEST) Received: from guvercin.ceng.metu.edu.tr (guvercin.ceng.metu.edu.tr [144.122.171.43]) by mails.dpdk.org (Postfix) with ESMTP id 8808740A87 for ; Tue, 4 Oct 2022 08:30:54 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by guvercin.ceng.metu.edu.tr (Postfix) with ESMTP id DC4AB2C649; Tue, 4 Oct 2022 09:30:53 +0300 (+03) X-Virus-Scanned: Debian amavisd-new at ceng.metu.edu.tr Received: from guvercin.ceng.metu.edu.tr ([127.0.0.1]) by localhost (guvercin.ceng.metu.edu.tr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KQP35oWQZM-t; Tue, 4 Oct 2022 09:30:41 +0300 (+03) Received: from roundcube.ceng.metu.edu.tr (kanarya.ceng.metu.edu.tr [144.122.171.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: e1885458) by guvercin.ceng.metu.edu.tr (Postfix) with ESMTPSA id 6F8A02C261; Tue, 4 Oct 2022 09:30:39 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ceng.metu.edu.tr; s=mail; t=1664865041; bh=LNU7tvFmOp4aQg3poqYdq4apnIlvjPXQx1oeqMY6Sqc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G1/iHeUA/ypI1eea9tUUTEifervVNs5K2Ihyo+JITPbk3DH4J1bghSZz13TESAiSa RS4jC2SJJzgij2f8q94LtLLlhGwla0AHuWvNITcX3FhTm3z1gPANJJyQfci3GgrBxg tfK2efP73iRZqlxhnhlR5FbZAp7yGJoRgeyw/Qgo= MIME-Version: 1.0 Date: Tue, 04 Oct 2022 09:30:39 +0300 From: Omer Yamac To: Bruce Richardson Cc: dev@dpdk.org, ferruh.yigit@amd.com Subject: Re: [PATCH] drivers: suggestion on removing empty version.map files In-Reply-To: References: <20221003065203.555038-1-omer.yamac@ceng.metu.edu.tr> <10e1b3c74bbaba4bcca8fadcddf8a7a4@ceng.metu.edu.tr> User-Agent: Roundcube Webmail Message-ID: <0f7fe73d49f820e4a1a1d56f9b535bfc@ceng.metu.edu.tr> X-Sender: omer.yamac@ceng.metu.edu.tr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 03.10.2022 17:01, Bruce Richardson wrote: > On Mon, Oct 03, 2022 at 04:59:18PM +0300, Omer Yamac wrote: >> >> >> On 03.10.2022 12:19, Bruce Richardson wrote: >> > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote: >> > > In this patch, we remove all version.map files which include >> > > only the below part: >> > > `DPDK_23 { >> > > local: *; >> > > };` >> > > >> > > Then we modify the meson.build to be able to compile without >> > > version.map >> > > >> > > Signed-off-by: Abdullah Ömer Yamaç >> > > Suggested-by: Ferruh Yigit >> > > --- >> > >> > I think you need to flag this as depending on us bumping the meson >> > version >> > requirement up to 0.53 as has been proposed. This doesn't work with 0.4x >> > versions. >> > >> Thanks for your warnings. >> Instead of using fs module, I will use python script that checks file >> exist >> or not. >> If it is okay, I will resubmit the patch. > > I'd rather not go down that road unless we really need to. Right now > the > empty version.map files are pretty much harmless, so there is no > compelling > need to change. Therefore, I'd rather wait to have the meson version > bumped > to 0.53 and then have this patch applied, without having to worry about > using script fallbacks. I understood; but one thing I'm not sure what should I do? I don't know how can I flag the meson requirement. Is there any special method or just a comment in the commit? > > /Bruce Thanks